From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2CECA9EA9 for ; Fri, 18 Oct 2019 19:00:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCB2221897 for ; Fri, 18 Oct 2019 19:00:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fGjlwqaP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2443214AbfJRTAo (ORCPT ); Fri, 18 Oct 2019 15:00:44 -0400 Received: from mail-ua1-f68.google.com ([209.85.222.68]:35025 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2443193AbfJRTAn (ORCPT ); Fri, 18 Oct 2019 15:00:43 -0400 Received: by mail-ua1-f68.google.com with SMTP id n41so2052582uae.2 for ; Fri, 18 Oct 2019 12:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dHnooVFY2SD/hhEM3K3r0PH8N73JFv2NbOv8bRM4m2E=; b=fGjlwqaPn26KxRb9o+F4zrhfo5SkElhAWo4zrZYkQX9pYzl+Gat5G9cEzwzzgLT0yN 01vXJtveJQV2qNvuL3dsYa3uHnA44CbQiyZWnm0OfAnXngfbQBE6/GoC7xkKTjBJoQ1W I3TlO2mOikI6Kr/w+ct+2TTOTmiNs0XrL0v8Qsjwm5i6295ZB9suC9+VQPpZngTAqbXp lbTN8AhrIsPleMkGbxdHNZqq0UgR8TbuoHXfoDLAHfBp5Dt4CXqh/ghNRZE/atlkwC4C f/z8a9w78sIenvmPm6uGln+51flj9Z7ABSXfofYGZvMWcJmJ0vLmRcx9Etw4H3lXK2ux qiHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dHnooVFY2SD/hhEM3K3r0PH8N73JFv2NbOv8bRM4m2E=; b=F+Z1K9ZqJQ8jelnJh4CVmdY8ELCH1ko/RkJhz47SqmI0Gd5JXefqpZ64+yG+MSq9bU HUDSoi9GwnsZLtsuEjFffoLDj7PoS8ru7rasp5E/dJ53UwVUvXtqRwcL5L179ZGsFIoH GgEn4u8PyZbdLDhALSSgJtYSNbAkEOLp8vBmdOh4FTkofMvTmilbd1cN15gy2EvcNe6D wgZIFq+7PPb3yBlwen5A181oiivcxKfz3R2V0TFsZGX7Bty3BFxHA90iILdGoB0w+8zh JC/WF+TFLJh/ja1tg32oHlUsAcyOLuCcXaYk0cBKqTpSXQ4CV37Zt5roCL4snavikVUa hrRQ== X-Gm-Message-State: APjAAAUC3rV669fdES40vIrOleVZijGsQ9xfvQxhBFZKNomBRlbh80Qq bD/7CkHeLJZnjRHLm7UsH7N+mg7W6IlKmiWkBX6oNw== X-Google-Smtp-Source: APXvYqy+QiLkN9pfvjcYpnB+QYepyp79m5l6k8r6HsNNtj0nqOOoe5lpxNRIDuav5cK0cYo+BuFsIE1uUC/SJFG20xg= X-Received: by 2002:a1f:b202:: with SMTP id b2mr6191356vkf.59.1571425241664; Fri, 18 Oct 2019 12:00:41 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-6-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Fri, 18 Oct 2019 12:00:30 -0700 Message-ID: Subject: Re: [PATCH 05/18] arm64: kbuild: reserve reg x18 from general allocation by the compiler To: Nick Desaulniers Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , clang-built-linux , Kernel Hardening , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 18, 2019 at 10:32 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > and remove the mention from > > the LL/SC compiler flag override. > > was that cut/dropped from this patch? > > > > > Link: https://patchwork.kernel.org/patch/9836881/ > > ^ Looks like it. Maybe it doesn't matter, but if sending a V2, maybe > the commit message to be updated? True. The original patch is from 2017 and the relevant part of arm64/lib/Makefile no longer exists. I'll update this accordingly. > I like how this does not conditionally reserve it based on the CONFIG > for SCS. Hopefully later patches don't wrap it, but I haven't looked > through all of them yet. In a later patch x18 is only reserved with SCS. I'm fine with dropping that patch and reserving it always, but wouldn't mind hearing thoughts from the maintainers about this first. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E53DCA9EA9 for ; Fri, 18 Oct 2019 19:00:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B48D21897 for ; Fri, 18 Oct 2019 19:00:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WtdUrwDP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="fGjlwqaP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B48D21897 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0P8ktVvkHOR0sN8DddpiAIyIWh+yJhUbNZ9j1f/y1Q0=; b=WtdUrwDPQ0+JbY diM1xFaPAQx3l2YtV93lhsaHQ5F218noCvLQaPhATQ9jqwsShS891MOtGmFnlKOUqsfWtxoPZXK9+ KbmN0NQ55SdN8bej3bEYpn5xQ7Sj4MNBjevBJe/8X3XmzxZEcBHi+QV8/Oh4hePK4rFSw+D0oI/tk MJn4KlmuZPJiP5OljU8s9i4Pek2gHOCeztucs29Sf2IV75nz8uOK2c5ed9iLIsfkiXMjQmQiyG5yR hCJOS91QjWF1ODsmiCnzORJKVgwmRWwetV1QQwTa8s9iV8506GIEI0VbvkjCmqvNRluqcZPVXO6Yt H3nj2UKKNKYIG7ItlFfQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLXUV-0005Jo-1o; Fri, 18 Oct 2019 19:00:47 +0000 Received: from mail-ua1-x944.google.com ([2607:f8b0:4864:20::944]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLXUR-0005JA-9p for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2019 19:00:44 +0000 Received: by mail-ua1-x944.google.com with SMTP id n2so2036275ual.11 for ; Fri, 18 Oct 2019 12:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dHnooVFY2SD/hhEM3K3r0PH8N73JFv2NbOv8bRM4m2E=; b=fGjlwqaPn26KxRb9o+F4zrhfo5SkElhAWo4zrZYkQX9pYzl+Gat5G9cEzwzzgLT0yN 01vXJtveJQV2qNvuL3dsYa3uHnA44CbQiyZWnm0OfAnXngfbQBE6/GoC7xkKTjBJoQ1W I3TlO2mOikI6Kr/w+ct+2TTOTmiNs0XrL0v8Qsjwm5i6295ZB9suC9+VQPpZngTAqbXp lbTN8AhrIsPleMkGbxdHNZqq0UgR8TbuoHXfoDLAHfBp5Dt4CXqh/ghNRZE/atlkwC4C f/z8a9w78sIenvmPm6uGln+51flj9Z7ABSXfofYGZvMWcJmJ0vLmRcx9Etw4H3lXK2ux qiHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dHnooVFY2SD/hhEM3K3r0PH8N73JFv2NbOv8bRM4m2E=; b=tpqC/teudn7u88gRIEmFo5UyHZ8QOwLDBa8bGbvkdmyvhPnM5h22rqimrh1dMZyBWA PGZbsWwe8glAD6Xa1Dpskzw1n32QIRY+B1KdcvzPtDdY3UAMAj4tNWxdkGzQ2tV9RHSP CiW9IdaHLw1V8ZCo5DMSlG/yWJ0nR/4HCUqSQ4CXrMyXd9/H9VHhMXtwAxW0e+u9iZJy +GsOa84QtTC29NhzPTM8alTZVlBigaHFt9/CuUTUzVX4ytqYiKrMsNOwGu6V4ZQaZRdH lbdmHOOtMw6BRynZFz5yrwfjMQ2g9RLY59CbADP+aYKUwxgEqBoUz3jBb0df4mSV/vqa C/Nw== X-Gm-Message-State: APjAAAUfuFg9BgXjGTjOyI5jWWIbrymZYVBhVXYfJF0i9C1CAccTcTr0 9qBvyAj8N0RROtwW41ADH4LE+jfVE08M1ci9Rd6yXA== X-Google-Smtp-Source: APXvYqy+QiLkN9pfvjcYpnB+QYepyp79m5l6k8r6HsNNtj0nqOOoe5lpxNRIDuav5cK0cYo+BuFsIE1uUC/SJFG20xg= X-Received: by 2002:a1f:b202:: with SMTP id b2mr6191356vkf.59.1571425241664; Fri, 18 Oct 2019 12:00:41 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-6-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Fri, 18 Oct 2019 12:00:30 -0700 Message-ID: Subject: Re: [PATCH 05/18] arm64: kbuild: reserve reg x18 from general allocation by the compiler To: Nick Desaulniers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191018_120043_362826_FD921508 X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Catalin Marinas , Kernel Hardening , LKML , Steven Rostedt , clang-built-linux , Laura Abbott , Will Deacon , Dave Martin , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 18, 2019 at 10:32 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > and remove the mention from > > the LL/SC compiler flag override. > > was that cut/dropped from this patch? > > > > > Link: https://patchwork.kernel.org/patch/9836881/ > > ^ Looks like it. Maybe it doesn't matter, but if sending a V2, maybe > the commit message to be updated? True. The original patch is from 2017 and the relevant part of arm64/lib/Makefile no longer exists. I'll update this accordingly. > I like how this does not conditionally reserve it based on the CONFIG > for SCS. Hopefully later patches don't wrap it, but I haven't looked > through all of them yet. In a later patch x18 is only reserved with SCS. I'm fine with dropping that patch and reserving it always, but wouldn't mind hearing thoughts from the maintainers about this first. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02DF1CA9EA9 for ; Fri, 18 Oct 2019 19:01:02 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 511FC2070B for ; Fri, 18 Oct 2019 19:01:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fGjlwqaP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 511FC2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17057-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 7645 invoked by uid 550); 18 Oct 2019 19:00:54 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 7624 invoked from network); 18 Oct 2019 19:00:54 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dHnooVFY2SD/hhEM3K3r0PH8N73JFv2NbOv8bRM4m2E=; b=fGjlwqaPn26KxRb9o+F4zrhfo5SkElhAWo4zrZYkQX9pYzl+Gat5G9cEzwzzgLT0yN 01vXJtveJQV2qNvuL3dsYa3uHnA44CbQiyZWnm0OfAnXngfbQBE6/GoC7xkKTjBJoQ1W I3TlO2mOikI6Kr/w+ct+2TTOTmiNs0XrL0v8Qsjwm5i6295ZB9suC9+VQPpZngTAqbXp lbTN8AhrIsPleMkGbxdHNZqq0UgR8TbuoHXfoDLAHfBp5Dt4CXqh/ghNRZE/atlkwC4C f/z8a9w78sIenvmPm6uGln+51flj9Z7ABSXfofYGZvMWcJmJ0vLmRcx9Etw4H3lXK2ux qiHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dHnooVFY2SD/hhEM3K3r0PH8N73JFv2NbOv8bRM4m2E=; b=efe10kjcqoklrLVM9S501s+y3gl9ShAZJAmVWCuvWJ+35HdyHOam0Yd1SmoBCMJl/3 7jdHTV72ixSvcRRlix6Y+iJVCCvAsShurcarcyAgNJ2lcldMCgMGyYDKL6BrPUmEhlmf henK4Ms3LwzYU4uGehmzTWKBGQYeC4aQYao0Tr7zP78FfRhlxmdQM2jaDwRj9uczzJC6 2bN4nEqHimt7keJieuPtt//kz6n+Y8vsLiLxKTqjWR3YIr6uy4k3sRp8Zo/Dzo1qWSpB azrdTt6PEyrTiPf2jRk5w/GSXhqIn4998A8kxsibyV+8yvUkGayGTeBvsiwgcqhHngyh 5U1Q== X-Gm-Message-State: APjAAAXTUFQN9VHsPWbAAwOGldBSsuRlulO3bxoVXsRUK1kSJ2ZPObpt Mpg5mPju08VYPUAZfky0gA2fRdtT8Ex2h4KQEwOnXw== X-Google-Smtp-Source: APXvYqy+QiLkN9pfvjcYpnB+QYepyp79m5l6k8r6HsNNtj0nqOOoe5lpxNRIDuav5cK0cYo+BuFsIE1uUC/SJFG20xg= X-Received: by 2002:a1f:b202:: with SMTP id b2mr6191356vkf.59.1571425241664; Fri, 18 Oct 2019 12:00:41 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-6-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Fri, 18 Oct 2019 12:00:30 -0700 Message-ID: Subject: Re: [PATCH 05/18] arm64: kbuild: reserve reg x18 from general allocation by the compiler To: Nick Desaulniers Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , clang-built-linux , Kernel Hardening , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" On Fri, Oct 18, 2019 at 10:32 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > and remove the mention from > > the LL/SC compiler flag override. > > was that cut/dropped from this patch? > > > > > Link: https://patchwork.kernel.org/patch/9836881/ > > ^ Looks like it. Maybe it doesn't matter, but if sending a V2, maybe > the commit message to be updated? True. The original patch is from 2017 and the relevant part of arm64/lib/Makefile no longer exists. I'll update this accordingly. > I like how this does not conditionally reserve it based on the CONFIG > for SCS. Hopefully later patches don't wrap it, but I haven't looked > through all of them yet. In a later patch x18 is only reserved with SCS. I'm fine with dropping that patch and reserving it always, but wouldn't mind hearing thoughts from the maintainers about this first. Sami