From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2D33CA9EC9 for ; Mon, 4 Nov 2019 21:44:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0CF920848 for ; Mon, 4 Nov 2019 21:44:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pHQfGMcF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729689AbfKDVon (ORCPT ); Mon, 4 Nov 2019 16:44:43 -0500 Received: from mail-ua1-f65.google.com ([209.85.222.65]:38627 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728634AbfKDVon (ORCPT ); Mon, 4 Nov 2019 16:44:43 -0500 Received: by mail-ua1-f65.google.com with SMTP id u99so5470700uau.5 for ; Mon, 04 Nov 2019 13:44:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kaXvf9wE3k9UaecG65PnRrmHU9a0z9eeJYq+CJlozEg=; b=pHQfGMcFvDs8Sz/sj2D9FDXz3MnOQRQu+N4CdnI6FNzotw2uFLAsGlw2AfCslqt5i1 NhuT8B5Ezfwhp9svCCthVzKrqQzSaREP2/BOyA4VdDO3mOGFMeEnNqjZV9EKKb5BwgAH bM/dxgbkeGBwpw6v8NjWHN7WfR5TQqN/xXvS5kz11espcMoT6/ho31I/XOxv81JBcV1z GeqbggJuYjxj2QeyalY3/MCFCfCDWJn8/AxC+ZFPpCHvzX/Cpnxf1nw4yPeZBVh+ScLp O8nGwga8BiVRzIj9L+z7DaZgwmXUgoNZyiEQqIULFC5kXaLbkCP27rPqGbTAVSPqhK1Q tN3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kaXvf9wE3k9UaecG65PnRrmHU9a0z9eeJYq+CJlozEg=; b=pw85w+UJJW7EwfDR36rUuhDvNoBqU5654RZC08wpQ9HN/WIG4jq87LZVM2gG6gWZ7E 4+7hTnY2T4k2MNWyNDrjiBddoRvs+kA9hVAHm3vonYZ52ejb0RGIPHbgGStGclq6dkUJ TLoezRK0uSfjw+henWgWAoUqknWUtsagGye0RqDNDwMKQ4ZXw6et2UB/oO3DPVXaK2qy h5iuhSYRakpfFAHwxp/jELtp5m2E7vyVCaGyjqRsyEppNjN+xRTM5bvnIphsFPcCEmMr HkeDbpnIF9BM/xtD2rqKJ4lGqXfRM1aSdUoFHREz99hJYYkZWTirj/nOUWzE9OGt8qSD f1ZA== X-Gm-Message-State: APjAAAXFELOFzea8TmKoRoaAgy1ttYmEvI5HSgafW8zPT7kuR31biVWU /dKrt+/GEC0pm67Lr1bHTlc6AWzppYTXfrKyi3mprQ== X-Google-Smtp-Source: APXvYqyozZ81Thh7mlXHgf1QUiqKh64ERV1FrTZSir+nNNiHAQ72oavyDPOWqxJDAI6llfn+2fNkSSVjyIyFG0syB7k= X-Received: by 2002:ab0:5981:: with SMTP id g1mr1829842uad.98.1572903881724; Mon, 04 Nov 2019 13:44:41 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191101221150.116536-1-samitolvanen@google.com> <20191101221150.116536-4-samitolvanen@google.com> <20191104115138.GB45140@lakrids.cambridge.arm.com> In-Reply-To: <20191104115138.GB45140@lakrids.cambridge.arm.com> From: Sami Tolvanen Date: Mon, 4 Nov 2019 13:44:30 -0800 Message-ID: Subject: Re: [PATCH v4 03/17] arm64: kvm: stop treating register x18 as caller save To: Mark Rutland Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 4, 2019 at 3:51 AM Mark Rutland wrote: > > --- a/arch/arm64/kvm/hyp/entry.S > > +++ b/arch/arm64/kvm/hyp/entry.S > > @@ -23,6 +23,7 @@ > > .pushsection .hyp.text, "ax" > > > > Could we please add a note here, e.g. > > /* > * We treat x18 as callee-saved as the host may use it as a platform > * register (e.g. for shadow call stack). > */ > > ... as that will avoid anyone trying to optimize this away in future > after reading the AAPCS. Sure, that's a good idea. > > .macro restore_callee_saved_regs ctxt > > + // We assume \ctxt is not x18-x28 > > Probably worth s/assume/require/ here. Agreed, I'll change this in v5. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E95CA9EC9 for ; Mon, 4 Nov 2019 21:44:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09ED920869 for ; Mon, 4 Nov 2019 21:44:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZjdnSDDm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="pHQfGMcF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09ED920869 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QkVesvDIN5SCy7w7iFIhk3hNrwF47E6dPtNy6l58izo=; b=ZjdnSDDm5ELkEQ Bz8oY2Of9KhAUUSHrAoYIinGeaMp0e+6qR8eHHOk6YdtZakpYyGcAjBiUci3uUemT5nYyE8cLYw7G 11Xne0WwT5RGFFxPQkQFpJkiOyPVYOrUDh5i1d5mJhG3vLIhob2qq4GiNyH9+Nt8DTQ+qC2DwQ8Yo jzk9byIvwrW+o3hqaWtXULCdtZO5IbOEWppUXVeFJi4OGeB6iwtRMBUUcG16XC9CHvIL6ds1KhRhJ 99W8wTs2USV6Tsr8Rmq12q3a6RTUI9fn6zEs55ZixLp4FbDsBBtvEuLZCflyPoIRSqVDmvVFjyuvJ n2MdMnZcN9h+ynkXlRZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRk9Y-0001B2-O1; Mon, 04 Nov 2019 21:44:48 +0000 Received: from mail-ua1-x943.google.com ([2607:f8b0:4864:20::943]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRk9T-0001AD-JM for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2019 21:44:46 +0000 Received: by mail-ua1-x943.google.com with SMTP id y17so2619690uaq.6 for ; Mon, 04 Nov 2019 13:44:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kaXvf9wE3k9UaecG65PnRrmHU9a0z9eeJYq+CJlozEg=; b=pHQfGMcFvDs8Sz/sj2D9FDXz3MnOQRQu+N4CdnI6FNzotw2uFLAsGlw2AfCslqt5i1 NhuT8B5Ezfwhp9svCCthVzKrqQzSaREP2/BOyA4VdDO3mOGFMeEnNqjZV9EKKb5BwgAH bM/dxgbkeGBwpw6v8NjWHN7WfR5TQqN/xXvS5kz11espcMoT6/ho31I/XOxv81JBcV1z GeqbggJuYjxj2QeyalY3/MCFCfCDWJn8/AxC+ZFPpCHvzX/Cpnxf1nw4yPeZBVh+ScLp O8nGwga8BiVRzIj9L+z7DaZgwmXUgoNZyiEQqIULFC5kXaLbkCP27rPqGbTAVSPqhK1Q tN3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kaXvf9wE3k9UaecG65PnRrmHU9a0z9eeJYq+CJlozEg=; b=gp3zNyIXJSZMUZMAiEaumVB/U5LaLCXQdPwvF+lvKgZTLiBpluxNG9B+x74itJbgHP 1aj6lgPF+hK4ghKJAJ+26BO01tWzy1tHBsvBKql+eGSs/hH+9b7Gbi1d5RZbM5pfwRB6 i2i5zHbLbJZ6PB7EFxi7JssQs9PaZH5Xh/Hmrl3jliLUQyh1KWDBlmQ9aGa2kSfTFsUB kE0FDQLaH7fuBDxI2LQcuc93qZAGTCt+leRWEEmke90pjh86ZaKaYmfoYOPTbXq6R0lt 4Jf5RFiOEZb7BmG3ES/MoVloPh4bcPNck5AxnWzfaXNsdEq5JOOXrUTA7t5SzpAs904w yE1g== X-Gm-Message-State: APjAAAUeNHDL4z6dTRutf8r/+vry8koA+GZCs/Ri1+ENuB1fBMV53wD5 X0zoxCgc7ZqvnE6ztEmZpU4W17F2ix/OzH9GMgXHvw== X-Google-Smtp-Source: APXvYqyozZ81Thh7mlXHgf1QUiqKh64ERV1FrTZSir+nNNiHAQ72oavyDPOWqxJDAI6llfn+2fNkSSVjyIyFG0syB7k= X-Received: by 2002:ab0:5981:: with SMTP id g1mr1829842uad.98.1572903881724; Mon, 04 Nov 2019 13:44:41 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191101221150.116536-1-samitolvanen@google.com> <20191101221150.116536-4-samitolvanen@google.com> <20191104115138.GB45140@lakrids.cambridge.arm.com> In-Reply-To: <20191104115138.GB45140@lakrids.cambridge.arm.com> From: Sami Tolvanen Date: Mon, 4 Nov 2019 13:44:30 -0800 Message-ID: Subject: Re: [PATCH v4 03/17] arm64: kvm: stop treating register x18 as caller save To: Mark Rutland X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_134443_662750_97B5A4F4 X-CRM114-Status: GOOD ( 11.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , clang-built-linux , Masami Hiramatsu , Marc Zyngier , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 4, 2019 at 3:51 AM Mark Rutland wrote: > > --- a/arch/arm64/kvm/hyp/entry.S > > +++ b/arch/arm64/kvm/hyp/entry.S > > @@ -23,6 +23,7 @@ > > .pushsection .hyp.text, "ax" > > > > Could we please add a note here, e.g. > > /* > * We treat x18 as callee-saved as the host may use it as a platform > * register (e.g. for shadow call stack). > */ > > ... as that will avoid anyone trying to optimize this away in future > after reading the AAPCS. Sure, that's a good idea. > > .macro restore_callee_saved_regs ctxt > > + // We assume \ctxt is not x18-x28 > > Probably worth s/assume/require/ here. Agreed, I'll change this in v5. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A57CA9EC9 for ; Mon, 4 Nov 2019 21:45:01 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 9315B20869 for ; Mon, 4 Nov 2019 21:45:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pHQfGMcF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9315B20869 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17277-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 28080 invoked by uid 550); 4 Nov 2019 21:44:54 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 28057 invoked from network); 4 Nov 2019 21:44:53 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kaXvf9wE3k9UaecG65PnRrmHU9a0z9eeJYq+CJlozEg=; b=pHQfGMcFvDs8Sz/sj2D9FDXz3MnOQRQu+N4CdnI6FNzotw2uFLAsGlw2AfCslqt5i1 NhuT8B5Ezfwhp9svCCthVzKrqQzSaREP2/BOyA4VdDO3mOGFMeEnNqjZV9EKKb5BwgAH bM/dxgbkeGBwpw6v8NjWHN7WfR5TQqN/xXvS5kz11espcMoT6/ho31I/XOxv81JBcV1z GeqbggJuYjxj2QeyalY3/MCFCfCDWJn8/AxC+ZFPpCHvzX/Cpnxf1nw4yPeZBVh+ScLp O8nGwga8BiVRzIj9L+z7DaZgwmXUgoNZyiEQqIULFC5kXaLbkCP27rPqGbTAVSPqhK1Q tN3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kaXvf9wE3k9UaecG65PnRrmHU9a0z9eeJYq+CJlozEg=; b=sk5Teb7GA0HkhrAAo6dmVGtjrctvCzgjFAgzGyO+MV8En1UElw39Rf0cpKfxLWNYTp RZeA8w4rBw4LHOOnRPtVYtBKYcmZn9bZShE9uGvpEWq686aOhNf2dM66/uyF3UoZ1Kau 31TLortc8n22EYRG4BEnR7r62sGSYBacq88aYOq2Do3xIBGYl9gH6KU1N3ZNoEbuXCCg u8qkxZVPZErAnV+llZmkIkbwQ91Uq3ZfQk1SpSUbP4OaZzmUvJ+AbXcYLp9122T1ALgb h6MNDbeDs0BawnHfpeVk2+v7eMVURJ2ld2VN5dxCuCLaKLcWcom+d1StvUuO3Wgn/hEY fz8A== X-Gm-Message-State: APjAAAWqy1y3gPwWOkzvMyd01alMjEoxqhTXv+2O1Hv/e4Af8C7HCSgF 8IXiIlm3pbbpdg3rLyX2OnaV0upKkFmF0cuq2SqviA== X-Google-Smtp-Source: APXvYqyozZ81Thh7mlXHgf1QUiqKh64ERV1FrTZSir+nNNiHAQ72oavyDPOWqxJDAI6llfn+2fNkSSVjyIyFG0syB7k= X-Received: by 2002:ab0:5981:: with SMTP id g1mr1829842uad.98.1572903881724; Mon, 04 Nov 2019 13:44:41 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191101221150.116536-1-samitolvanen@google.com> <20191101221150.116536-4-samitolvanen@google.com> <20191104115138.GB45140@lakrids.cambridge.arm.com> In-Reply-To: <20191104115138.GB45140@lakrids.cambridge.arm.com> From: Sami Tolvanen Date: Mon, 4 Nov 2019 13:44:30 -0800 Message-ID: Subject: Re: [PATCH v4 03/17] arm64: kvm: stop treating register x18 as caller save To: Mark Rutland Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" On Mon, Nov 4, 2019 at 3:51 AM Mark Rutland wrote: > > --- a/arch/arm64/kvm/hyp/entry.S > > +++ b/arch/arm64/kvm/hyp/entry.S > > @@ -23,6 +23,7 @@ > > .pushsection .hyp.text, "ax" > > > > Could we please add a note here, e.g. > > /* > * We treat x18 as callee-saved as the host may use it as a platform > * register (e.g. for shadow call stack). > */ > > ... as that will avoid anyone trying to optimize this away in future > after reading the AAPCS. Sure, that's a good idea. > > .macro restore_callee_saved_regs ctxt > > + // We assume \ctxt is not x18-x28 > > Probably worth s/assume/require/ here. Agreed, I'll change this in v5. Sami