From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7355FC433E0 for ; Wed, 24 Feb 2021 22:54:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3163364F03 for ; Wed, 24 Feb 2021 22:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233479AbhBXWyg (ORCPT ); Wed, 24 Feb 2021 17:54:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232601AbhBXWyg (ORCPT ); Wed, 24 Feb 2021 17:54:36 -0500 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [IPv6:2607:f8b0:4864:20::e2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED0EAC061574 for ; Wed, 24 Feb 2021 14:53:55 -0800 (PST) Received: by mail-vs1-xe2d.google.com with SMTP id i13so1930335vsr.13 for ; Wed, 24 Feb 2021 14:53:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CtmcRer6hQJigU7MJiHWoawVGnAqfvAooXVPraxhhQ0=; b=gAqE4xzTxQYvXiIGJe5ngRwBo6wJZVfNwOdZjbKJx0i6Y7qkf4Ota2cfK8xMcAOXwt sUBOo40zSCLd2r6s+zBJRZlymgugeg7tMYbsS7SU2+2WnLk0KTg4sa2+/mR6eQRIn6kZ 0EWNadiqsMWqXKDZom5rXgyrRk6GXpcGdpksbp4ktNiompA645Qw+9kuWnYnVcdfH9Nd X0kmBLPyIpmfCKDVA7g4bPslcHWYq1B+gStdhbLpElapeLaIMwruuLuyATVZYquvEOeu ILe7uNDqE/Jo3VcEvO/GXveOzpxPiiaczBQy92Y2RVpxMmJvCsnbyrxrwt2OiKq7La4C JPrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CtmcRer6hQJigU7MJiHWoawVGnAqfvAooXVPraxhhQ0=; b=TpSVdGh2oHaQsvGuAfym6zyrmT3h1Btv0qt4jfD/LIs74yemNyKnwzSTYz835WheMY pAfkIPB6SFOkCr8hIQ1YsM2OWQKKos61Xp6w2EEnQCG40RLcAtQXAcKM18EqXRRd9iZL h2cjUPxSR89QnV7LcWT6eFKC3N3sFZM3EMePuGvy7Xlj2c3hcnD99YY19G6q8cfKigxO GJKrICfUUImwdk4h59g8IVIjTRorMekSq+CZSGN3kkgUQjqaUk3ExZFkG5rwD7hTbAgr l8dvPmS9Qx2E/AqQJC0A99Bgjxn8fmxYz0DjW3swU2+FspdF1QqHVKPkWvqp97F8MfFJ Sjuw== X-Gm-Message-State: AOAM533hn2GrV4TnN2OCt+VvqF9C2F0ZoT2udHtzvBXSB6ysHLBY1olR B914CQZS1MoHMXJWzFTpQgOREgMmLLPuUoRxqVhMiA== X-Google-Smtp-Source: ABdhPJz9amPAf+Mcj7QcjJv+23lplTdEhk0bnuRNpc4wa+h3p96afBwfpClgfE2R2bLtMWCvDR1eh9xiXZAPseNNXTo= X-Received: by 2002:a67:c82:: with SMTP id 124mr87583vsm.54.1614207234779; Wed, 24 Feb 2021 14:53:54 -0800 (PST) MIME-Version: 1.0 References: <20210224205938.4104543-1-samitolvanen@google.com> <202102241301.226812E88@keescook> <20210224224634.GC74404@roeck-us.net> In-Reply-To: <20210224224634.GC74404@roeck-us.net> From: Sami Tolvanen Date: Wed, 24 Feb 2021 14:53:43 -0800 Message-ID: Subject: Re: [PATCH] parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY To: Guenter Roeck Cc: Kees Cook , "James E.J. Bottomley" , Helge Deller , "Steven Rostedt (VMware)" , linux-parisc@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Wed, Feb 24, 2021 at 2:46 PM Guenter Roeck wrote: > > On Wed, Feb 24, 2021 at 01:02:27PM -0800, Kees Cook wrote: > > On Wed, Feb 24, 2021 at 12:59:38PM -0800, Sami Tolvanen wrote: > > > parisc uses -fpatchable-function-entry with dynamic ftrace, which means we > > > don't need recordmcount. Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY > > > to tell that to the build system. > > > > > > Reported-by: Guenter Roeck > > > Fixes: 3b15cdc15956 ("tracing: move function tracer options to Kconfig") > > > Signed-off-by: Sami Tolvanen > > > > I've got parisc building now, and can confirm: > > > > Tested-by: Kees Cook > > > > Guenter, does this fix it for you too? > > > > I get this: > > WARNING: unmet direct dependencies detected for FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY > Depends on [n]: TRACING_SUPPORT [=y] && FTRACE [=y] && FTRACE_MCOUNT_RECORD [=n] > Selected by [y]: > - PARISC [=y] && HAVE_DYNAMIC_FTRACE [=y] > > when trying to build parisc:defconfig. > > I think it should be > > select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRACE > > (no HAVE_) Ah, it depends on FTRACE_MCOUNT_RECORD. Thanks for testing. I'll send v2. Sami