From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2F21CA9EC9 for ; Mon, 4 Nov 2019 23:44:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8499B214D9 for ; Mon, 4 Nov 2019 23:44:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XWr7kryZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729929AbfKDXow (ORCPT ); Mon, 4 Nov 2019 18:44:52 -0500 Received: from mail-ua1-f68.google.com ([209.85.222.68]:42169 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728602AbfKDXow (ORCPT ); Mon, 4 Nov 2019 18:44:52 -0500 Received: by mail-ua1-f68.google.com with SMTP id 31so1849932uas.9 for ; Mon, 04 Nov 2019 15:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SpNwJfSJO9MidRCrn2p9uupIwuhjvEPSgYuh9TBYZuw=; b=XWr7kryZXstmsXgYE4dBJ4NrnDur3s/AC0seExuiGF6z4UGQCwWfIPFNeY7JeVwPM3 wnP1G5A/K76IWU2DyV/IUlCtYDCgPO0n/bDVtTP4pu+zHCoH+fei6dyO2OcLB2gsC6W7 yHM2c0/FUmsEcEYZY0y9ta70pnWbez+C+rMSFS+aiM6DHbB5OA98h3MrtmOeV6q9EDtK bw1zfaHUujqN+zHGVRnnbiam+tcW3d2rc3/Pvust522b4CCrQ9v9kAdVmg3Axk3wD37y xqCPcphfjtbZ+wkJQy35r/dA4lS8knkpiqdmkjVq1MbYxp8Jbw1P5SRRjv/N4BJhioPs zRZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SpNwJfSJO9MidRCrn2p9uupIwuhjvEPSgYuh9TBYZuw=; b=YypXnw6+E9XZuK1UPxRSW0cNpDMyqfntQCYbpMWx7VDvNT6DtwEI6cN/3pi4lRKBpM CCXcdUtyLmjk2U3/t6+ogPZDZkIcuS80c4EqEqqVA36kbb2Dh1b37ToVWWEtRLUaEr9j Z9SjilK0J4v7MWaR9e/XEnlHT0XJ3kGG9ZbIXb+FtVf8135ozwtn461Kzw/2/CRK+xEI LR+Jyhz5qxsqtUcG/jrJWwNqAMa4nMKhhvia7Uer4vRzfVmtjgoty0etsN7Mb2gP0Y9N k56uua56Cm+KxG6pxyRbkQzRMoi0hbCDtLeoAJ7OiR+hx509uJIqxm8nVyqOhRrU688J QR4Q== X-Gm-Message-State: APjAAAUNe2pvCjdSsWbDGtkKFaefLAK8OXpzr/RoLzWXKzpGv1mZwSYu JmMAPR+xFNs3OiMOETAqRoke/Y49fcnqqo6qYHniOg== X-Google-Smtp-Source: APXvYqwMrHXnmCbhr/Nl5pMJrYHuxKP6Lu2UQKV7ItSK55vLCW1x6A4Use4SMcLe4G85I9Dvt99c2soxGNjz4r8rNRQ= X-Received: by 2002:ab0:4587:: with SMTP id u7mr3850575uau.67.1572911090684; Mon, 04 Nov 2019 15:44:50 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191101221150.116536-1-samitolvanen@google.com> <20191101221150.116536-12-samitolvanen@google.com> <20191104171132.GB2024@lakrids.cambridge.arm.com> In-Reply-To: <20191104171132.GB2024@lakrids.cambridge.arm.com> From: Sami Tolvanen Date: Mon, 4 Nov 2019 15:44:39 -0800 Message-ID: Subject: Re: [PATCH v4 11/17] arm64: disable function graph tracing with SCS To: Mark Rutland Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 4, 2019 at 9:11 AM Mark Rutland wrote: > Can you please elaborate on _how_ this is incompatible in the commit > message? > > For example, it's not clear to me if you mean that's functionally > incompatible, or if you're trying to remove return-altering gadgets. > > If there's a functional incompatibility, please spell that out a bit > more clearly. Likewise if this is about minimizing the set of places > that can mess with control-flow outside of usual function conventions. Sure, I'll add a better description in v5. In this case, the return address is modified in the kernel stack, which means the changes are ignored with SCS. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A22CA9EC9 for ; Mon, 4 Nov 2019 23:44:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C46F5214D9 for ; Mon, 4 Nov 2019 23:44:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="URobjOCy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="XWr7kryZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C46F5214D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UUUTbSZzCRNg7sklzX2dQK0m2sUydlCA4JnAS5Og1V4=; b=URobjOCyg7ZNjS j5ikPTDCDGOOEP59QKg/Nz794j2sMtO9R7ThNXf2Lq8FdAs0tgrH0pTRp10qnyHAFbD/Nynp9sMcz Zx8MddUDompPe6VUg8Y259vt+eZXSQiCpQYkFk2IhSc6kGcmckCDwRK5YIHuCainQPVT/e7SfGGvF /GGUQu7YeSR6JGRu3fOdKJAsQmuc7gI7xwX0s55FTufKmKBhQMhpe3Fq870xQfHUXH8UVyE9wrFil PbFCOEwhAqwJnEstiaYEGBIHXQGlGPTA/Tjclo4duBNzFDx18TejKU89yCjeWDTggnJpmHeVE+LNK pj78yVQEUalKoinCeokQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRm1n-0000Od-Gu; Mon, 04 Nov 2019 23:44:55 +0000 Received: from mail-ua1-x943.google.com ([2607:f8b0:4864:20::943]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRm1k-0000Nn-EE for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2019 23:44:53 +0000 Received: by mail-ua1-x943.google.com with SMTP id z9so1805277uan.3 for ; Mon, 04 Nov 2019 15:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SpNwJfSJO9MidRCrn2p9uupIwuhjvEPSgYuh9TBYZuw=; b=XWr7kryZXstmsXgYE4dBJ4NrnDur3s/AC0seExuiGF6z4UGQCwWfIPFNeY7JeVwPM3 wnP1G5A/K76IWU2DyV/IUlCtYDCgPO0n/bDVtTP4pu+zHCoH+fei6dyO2OcLB2gsC6W7 yHM2c0/FUmsEcEYZY0y9ta70pnWbez+C+rMSFS+aiM6DHbB5OA98h3MrtmOeV6q9EDtK bw1zfaHUujqN+zHGVRnnbiam+tcW3d2rc3/Pvust522b4CCrQ9v9kAdVmg3Axk3wD37y xqCPcphfjtbZ+wkJQy35r/dA4lS8knkpiqdmkjVq1MbYxp8Jbw1P5SRRjv/N4BJhioPs zRZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SpNwJfSJO9MidRCrn2p9uupIwuhjvEPSgYuh9TBYZuw=; b=nemoOrjuqmts+chzdp0hfyOqmYOMLnWKxLVcExiImslnyxxyIcmEMpKdw9s3vDm3Uv SzgvY7kn/l9CeED3Qvr+mQ/qnwwqFYSyV9DZW+1iPADMEEbOSFkEvj+fEtWzwMqsPT2L 5AEOziSlq01ay9gjzqdFICUZSG4V8lu4ooxrfYdqtRPO3+mSkvvxGUmjbt1yQMbVbZRA eYmokh8+xltWNuqog6iUbV1oDawA2DePcqN0txASR4rSfmwrFNjBOPwgzvU5+lzYPIqb oGux/BeHzL0xVqDym9OE8Ba9ZbAYit7DkCkZj20YBzPPWZF589dwqnW1jw9ZoS7QWBX2 h0sg== X-Gm-Message-State: APjAAAX2EOcHq6uT0pcxnpiikUXnCIF0Y/RjbuUMJJBl+x7GmJJr9OqM NwK9OMd8VDflzE3aiwwUP+YskPBEV5++W94YFt24og== X-Google-Smtp-Source: APXvYqwMrHXnmCbhr/Nl5pMJrYHuxKP6Lu2UQKV7ItSK55vLCW1x6A4Use4SMcLe4G85I9Dvt99c2soxGNjz4r8rNRQ= X-Received: by 2002:ab0:4587:: with SMTP id u7mr3850575uau.67.1572911090684; Mon, 04 Nov 2019 15:44:50 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191101221150.116536-1-samitolvanen@google.com> <20191101221150.116536-12-samitolvanen@google.com> <20191104171132.GB2024@lakrids.cambridge.arm.com> In-Reply-To: <20191104171132.GB2024@lakrids.cambridge.arm.com> From: Sami Tolvanen Date: Mon, 4 Nov 2019 15:44:39 -0800 Message-ID: Subject: Re: [PATCH v4 11/17] arm64: disable function graph tracing with SCS To: Mark Rutland X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_154452_504258_587B0092 X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , clang-built-linux , Masami Hiramatsu , Marc Zyngier , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 4, 2019 at 9:11 AM Mark Rutland wrote: > Can you please elaborate on _how_ this is incompatible in the commit > message? > > For example, it's not clear to me if you mean that's functionally > incompatible, or if you're trying to remove return-altering gadgets. > > If there's a functional incompatibility, please spell that out a bit > more clearly. Likewise if this is about minimizing the set of places > that can mess with control-flow outside of usual function conventions. Sure, I'll add a better description in v5. In this case, the return address is modified in the kernel stack, which means the changes are ignored with SCS. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75279CA9EC9 for ; Mon, 4 Nov 2019 23:45:09 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id BE6A4214E0 for ; Mon, 4 Nov 2019 23:45:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XWr7kryZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE6A4214E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17280-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 3933 invoked by uid 550); 4 Nov 2019 23:45:03 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 3907 invoked from network); 4 Nov 2019 23:45:02 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SpNwJfSJO9MidRCrn2p9uupIwuhjvEPSgYuh9TBYZuw=; b=XWr7kryZXstmsXgYE4dBJ4NrnDur3s/AC0seExuiGF6z4UGQCwWfIPFNeY7JeVwPM3 wnP1G5A/K76IWU2DyV/IUlCtYDCgPO0n/bDVtTP4pu+zHCoH+fei6dyO2OcLB2gsC6W7 yHM2c0/FUmsEcEYZY0y9ta70pnWbez+C+rMSFS+aiM6DHbB5OA98h3MrtmOeV6q9EDtK bw1zfaHUujqN+zHGVRnnbiam+tcW3d2rc3/Pvust522b4CCrQ9v9kAdVmg3Axk3wD37y xqCPcphfjtbZ+wkJQy35r/dA4lS8knkpiqdmkjVq1MbYxp8Jbw1P5SRRjv/N4BJhioPs zRZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SpNwJfSJO9MidRCrn2p9uupIwuhjvEPSgYuh9TBYZuw=; b=dYoO31ZJURDZtbIxvCvcF9dGwFV4P2HVvycggNV0f3Ylwf07QfG/NIdrmPg8Ia+yc7 iSUcn96CzLq9/Bj+tqToUWNSoWxbf7+/vnNL1ZsM/+fwjwcCL85M2GYcL9U7mlcd2eZz /dwhhvne/oYMv6uJSprEcUiwuo7CRs5TcM4vGwK65/tpxILn0zC/ntnM7zpqVlIeCO8D f3Yh/qGLGsaEyqNU+Jw7eoJrP5uJL/pKtCrQiScpijVhjNmYXMNs6Km6maRgXf6mZRpi MxtzlcAkwzGq9PASjWQAqKVz6c05bQ7Ee/yq7REb7t/jMy+Ufv7jp/CQqtwUoD3r2tZA +YLg== X-Gm-Message-State: APjAAAXGFCWRdbdNBNmsiI7AjqvwQgrNPNr8Y1sPRXp+4iinuFKicBze kwx8Klhxb1oT2X3B7+dFnofZeLLrbCtuFqqqOmdS/g== X-Google-Smtp-Source: APXvYqwMrHXnmCbhr/Nl5pMJrYHuxKP6Lu2UQKV7ItSK55vLCW1x6A4Use4SMcLe4G85I9Dvt99c2soxGNjz4r8rNRQ= X-Received: by 2002:ab0:4587:: with SMTP id u7mr3850575uau.67.1572911090684; Mon, 04 Nov 2019 15:44:50 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191101221150.116536-1-samitolvanen@google.com> <20191101221150.116536-12-samitolvanen@google.com> <20191104171132.GB2024@lakrids.cambridge.arm.com> In-Reply-To: <20191104171132.GB2024@lakrids.cambridge.arm.com> From: Sami Tolvanen Date: Mon, 4 Nov 2019 15:44:39 -0800 Message-ID: Subject: Re: [PATCH v4 11/17] arm64: disable function graph tracing with SCS To: Mark Rutland Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" On Mon, Nov 4, 2019 at 9:11 AM Mark Rutland wrote: > Can you please elaborate on _how_ this is incompatible in the commit > message? > > For example, it's not clear to me if you mean that's functionally > incompatible, or if you're trying to remove return-altering gadgets. > > If there's a functional incompatibility, please spell that out a bit > more clearly. Likewise if this is about minimizing the set of places > that can mess with control-flow outside of usual function conventions. Sure, I'll add a better description in v5. In this case, the return address is modified in the kernel stack, which means the changes are ignored with SCS. Sami