From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17574C2BA83 for ; Wed, 12 Feb 2020 17:36:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E07C821569 for ; Wed, 12 Feb 2020 17:36:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WTUFnbqw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728728AbgBLRgg (ORCPT ); Wed, 12 Feb 2020 12:36:36 -0500 Received: from mail-ua1-f65.google.com ([209.85.222.65]:42559 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727054AbgBLRgf (ORCPT ); Wed, 12 Feb 2020 12:36:35 -0500 Received: by mail-ua1-f65.google.com with SMTP id p2so1172323uao.9 for ; Wed, 12 Feb 2020 09:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oXC2J3nEK5SwOdFoK4ULqW0570rBTdySIYo3+gIlo9M=; b=WTUFnbqwYf+rL57s/FGxM1+vxE9Jz5IK7E+OqB1D8Yag+QT+LdUeuoco6oTC4zgy7L TKipBuXtB2O8hn6XUjmdUpdrUfke0F8SCdmbLI53UNP2BplyGiw6vXFuWmFYFzZtLQeN 5wpar/5ILukP9S05BShLrDSCKEPCKcsSH/oAGyElM1PsKMhn2zidyE008XJx5PD7dUMg n4j6E1083epW+BkViMtDeuVftqlXVyhEyjY2m1kZGGBAfrXmhWXYSRy7y6cbm8taKOCJ y3l8mKYES7s2h2SOYn+hKiFfdkCBn2+SUUTjhfBmJGbvU+drkZVcb4Ou3zqNKzp4BpKd nG4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oXC2J3nEK5SwOdFoK4ULqW0570rBTdySIYo3+gIlo9M=; b=Y4oVU/AhlH9eO/UCFQvp/cJnN2CK5oC+QwyLjIOd3y2w78QxBwNnnEpeH6OBNrVp+S g9udZ0OwZFV+VZpZHamNFprKEv4ow5AQbcxTPmkhgiecaeYRpX7oJfColCAlYhDlKNoH mcZxUX6yCc2UulhgSShtsmNtT/bc1AcTWnlMDEHfAYbK0Tu1G06zf5LXIVVnugJ388J8 uPL+AFNDUitpt4hqsIzr9NM/82aGdjvFAFUxSSlJIFeigz/ovRiMeftauY5+OsuVRB8O xGdZ+jJ8LvqqOKgqtZuakFQcTbKhTjleVJy86sGSQSJNZlOTQiGy9XJrY24Cs+Q9hxp1 gctA== X-Gm-Message-State: APjAAAXN9pm7NzArLEDnzH5EkHzS8GvXYe4GGnnvfQ1+fVQQrDEH5Op8 MdKZkejAOquzNJlOiMfXXJEVnoeCkisAoxrKi8dqGA== X-Google-Smtp-Source: APXvYqySnCPpjBgnelV684/U07lYpWTQs3A+aOrC5t4BnyXhAn03wUz7JH8o/EDUYvzcfRllMDnDJ3B306fqXtaeZDQ= X-Received: by 2002:ab0:422:: with SMTP id 31mr5283734uav.98.1581528994562; Wed, 12 Feb 2020 09:36:34 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20200128184934.77625-1-samitolvanen@google.com> <63517cff-4bd6-bb6c-9a54-23de4f5fbb4a@arm.com> In-Reply-To: <63517cff-4bd6-bb6c-9a54-23de4f5fbb4a@arm.com> From: Sami Tolvanen Date: Wed, 12 Feb 2020 09:36:23 -0800 Message-ID: Subject: Re: [PATCH v7 00/11] add support for Clang's Shadow Call Stack To: James Morse Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Mark Rutland , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2020 at 5:57 AM James Morse wrote: > I found I had to add: > | KBUILD_CFLAGS := $(filter-out -ffixed-x18 $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) > > to drivers/firmware/efi/libstub/Makefile, to get this going. Ah, good catch! > I don't think there is much point supporting SCS for the EFIstub, its already isolated > from the rest of the kernel's C code by the __efistub symbol prefix machinery, and trying > to use it would expose us to buggy firmware at a point we can't handle it! Yes, fully agreed. > I can send a patch if its easier for you, It's not a problem, I will include a patch for this in v8. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADFC7C2BA83 for ; Wed, 12 Feb 2020 17:36:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85EE42073C for ; Wed, 12 Feb 2020 17:36:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lo1AFWp1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="WTUFnbqw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85EE42073C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MboXMBvvsTqTBHBMFNMG8xFoA3bArsPrSsGISEjWRg0=; b=lo1AFWp1OrQi7a gwnwtrEBz/BYhWYn123Cwzjm7cTBl68wD7lrTe8SyZmgSOWoRO3tTC89oGIoiEwOvstCCuvq+XfDK iYpvXlYmhyAojJP0ce8Wxa3VbrmNb8XJlvKiK/bSDF53nkqQcCj9aprXr88rwWEUitzGh1GMbMzz0 FTbr7zo6XA7uCC73TKoN7kemEg/NvPftPoi5pc6zkCpwNlc3c2frgvSDcixPw9fxmKiS+3Tbh1dOr QF/H5ZQwvw4a60hS7xLlhD/fXfDqSiPNoFhzMbtJAlDH5PXgsZMuwyIQ50AAgl9CcNvDnj2jbhI+5 v2fZEooWvE35d9lKyTjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1vwF-0005QD-70; Wed, 12 Feb 2020 17:36:39 +0000 Received: from mail-ua1-x941.google.com ([2607:f8b0:4864:20::941]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1vwC-0005Pd-4h for linux-arm-kernel@lists.infradead.org; Wed, 12 Feb 2020 17:36:37 +0000 Received: by mail-ua1-x941.google.com with SMTP id c7so1183836uaf.5 for ; Wed, 12 Feb 2020 09:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oXC2J3nEK5SwOdFoK4ULqW0570rBTdySIYo3+gIlo9M=; b=WTUFnbqwYf+rL57s/FGxM1+vxE9Jz5IK7E+OqB1D8Yag+QT+LdUeuoco6oTC4zgy7L TKipBuXtB2O8hn6XUjmdUpdrUfke0F8SCdmbLI53UNP2BplyGiw6vXFuWmFYFzZtLQeN 5wpar/5ILukP9S05BShLrDSCKEPCKcsSH/oAGyElM1PsKMhn2zidyE008XJx5PD7dUMg n4j6E1083epW+BkViMtDeuVftqlXVyhEyjY2m1kZGGBAfrXmhWXYSRy7y6cbm8taKOCJ y3l8mKYES7s2h2SOYn+hKiFfdkCBn2+SUUTjhfBmJGbvU+drkZVcb4Ou3zqNKzp4BpKd nG4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oXC2J3nEK5SwOdFoK4ULqW0570rBTdySIYo3+gIlo9M=; b=P1zCMoXasMce51Xq/iLG01/j+hF1E0ICbftfvNisGYspRWr+aPEhhH37uyKhHAMgMh AZKAUr5b4AM7cJaA5fzra/vgGyeVYSCiGSxS4mtdSoMls81TOv4p/qgJG+lAVrR1E2h4 zp1vq4QOFfw1YLSloQIEENxG+eIcBcLZD5KIIp0YbUPuQQ7JiwksKPo9FF5B+E9VwPb7 tmEnQmoUR+VL4rqMP8mSXmsaH72X1PBsH+abOowQI98j0/RHN38ekqRaoTF5ruyqUr4f O9ITTn6FOJ0Ztx8Ylww915augDGKj1LmsqSq3XrVMwQ8Fooxi5tKLSKsH0v0QrB96w7i Y2bQ== X-Gm-Message-State: APjAAAVTzlHIxJ7S05ZD09mPbNryqGiwu4cN6qoZfYtt8IhFL3zmRUqG oe3R13JzEC3QyQARZY5owSSlKytBrEBTO3sqO+3qDg== X-Google-Smtp-Source: APXvYqySnCPpjBgnelV684/U07lYpWTQs3A+aOrC5t4BnyXhAn03wUz7JH8o/EDUYvzcfRllMDnDJ3B306fqXtaeZDQ= X-Received: by 2002:ab0:422:: with SMTP id 31mr5283734uav.98.1581528994562; Wed, 12 Feb 2020 09:36:34 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20200128184934.77625-1-samitolvanen@google.com> <63517cff-4bd6-bb6c-9a54-23de4f5fbb4a@arm.com> In-Reply-To: <63517cff-4bd6-bb6c-9a54-23de4f5fbb4a@arm.com> From: Sami Tolvanen Date: Wed, 12 Feb 2020 09:36:23 -0800 Message-ID: Subject: Re: [PATCH v7 00/11] add support for Clang's Shadow Call Stack To: James Morse X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200212_093636_207327_94EEFBA1 X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , clang-built-linux , Masami Hiramatsu , Marc Zyngier , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 11, 2020 at 5:57 AM James Morse wrote: > I found I had to add: > | KBUILD_CFLAGS := $(filter-out -ffixed-x18 $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) > > to drivers/firmware/efi/libstub/Makefile, to get this going. Ah, good catch! > I don't think there is much point supporting SCS for the EFIstub, its already isolated > from the rest of the kernel's C code by the __efistub symbol prefix machinery, and trying > to use it would expose us to buggy firmware at a point we can't handle it! Yes, fully agreed. > I can send a patch if its easier for you, It's not a problem, I will include a patch for this in v8. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B3EC2BA83 for ; Wed, 12 Feb 2020 17:36:53 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id B36DA2073C for ; Wed, 12 Feb 2020 17:36:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WTUFnbqw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B36DA2073C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17797-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 1231 invoked by uid 550); 12 Feb 2020 17:36:47 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 1209 invoked from network); 12 Feb 2020 17:36:46 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oXC2J3nEK5SwOdFoK4ULqW0570rBTdySIYo3+gIlo9M=; b=WTUFnbqwYf+rL57s/FGxM1+vxE9Jz5IK7E+OqB1D8Yag+QT+LdUeuoco6oTC4zgy7L TKipBuXtB2O8hn6XUjmdUpdrUfke0F8SCdmbLI53UNP2BplyGiw6vXFuWmFYFzZtLQeN 5wpar/5ILukP9S05BShLrDSCKEPCKcsSH/oAGyElM1PsKMhn2zidyE008XJx5PD7dUMg n4j6E1083epW+BkViMtDeuVftqlXVyhEyjY2m1kZGGBAfrXmhWXYSRy7y6cbm8taKOCJ y3l8mKYES7s2h2SOYn+hKiFfdkCBn2+SUUTjhfBmJGbvU+drkZVcb4Ou3zqNKzp4BpKd nG4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oXC2J3nEK5SwOdFoK4ULqW0570rBTdySIYo3+gIlo9M=; b=lIzdDJzSqZTqmAQ7Z5bbEJXbEfYgsS+C8y9NMFFvqHahvprYQkL7FqaccjZ2/GwAKS h1yKV6JVsfQncGCEoQnpU5J0UuSKhVrSQyXpCqUX8hfSRgfESDCC1fRpmSAW1V4zvbe4 Nj0MChOhtxu38MHUBEmK7Wq8F8NFCm6DQOqQczFrRn9MEJ9YenIHLMgqxuMv2i9eyptU C2FM2bTethp9YEWoziLHSKID4CFQfPbhc3iGpd++Y27d5aGcYW8gUHTOam1UR1I4NGpr XKRIrF1Qabhfb+jjEjLUAw/K+udO5D+KPjEdF4AUsT7jn1PNNlOLANxH63MIL5+muGmy ZISw== X-Gm-Message-State: APjAAAV0L2hF8NHqhTAEjfNE5pZ5vflglg+sB8QqqprbZHz2C10A3ztB VmhrS2OKMnAn5r/3a2qQ1mW13Jr51/fUeeWnrTdsjw== X-Google-Smtp-Source: APXvYqySnCPpjBgnelV684/U07lYpWTQs3A+aOrC5t4BnyXhAn03wUz7JH8o/EDUYvzcfRllMDnDJ3B306fqXtaeZDQ= X-Received: by 2002:ab0:422:: with SMTP id 31mr5283734uav.98.1581528994562; Wed, 12 Feb 2020 09:36:34 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20200128184934.77625-1-samitolvanen@google.com> <63517cff-4bd6-bb6c-9a54-23de4f5fbb4a@arm.com> In-Reply-To: <63517cff-4bd6-bb6c-9a54-23de4f5fbb4a@arm.com> From: Sami Tolvanen Date: Wed, 12 Feb 2020 09:36:23 -0800 Message-ID: Subject: Re: [PATCH v7 00/11] add support for Clang's Shadow Call Stack To: James Morse Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Mark Rutland , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" On Tue, Feb 11, 2020 at 5:57 AM James Morse wrote: > I found I had to add: > | KBUILD_CFLAGS := $(filter-out -ffixed-x18 $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) > > to drivers/firmware/efi/libstub/Makefile, to get this going. Ah, good catch! > I don't think there is much point supporting SCS for the EFIstub, its already isolated > from the rest of the kernel's C code by the __efistub symbol prefix machinery, and trying > to use it would expose us to buggy firmware at a point we can't handle it! Yes, fully agreed. > I can send a patch if its easier for you, It's not a problem, I will include a patch for this in v8. Sami