From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4C70CA9ECF for ; Fri, 1 Nov 2019 20:33:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B82D820679 for ; Fri, 1 Nov 2019 20:33:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="llfdsR0m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727774AbfKAUdB (ORCPT ); Fri, 1 Nov 2019 16:33:01 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:46889 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726709AbfKAUdB (ORCPT ); Fri, 1 Nov 2019 16:33:01 -0400 Received: by mail-vs1-f67.google.com with SMTP id m6so627271vsn.13 for ; Fri, 01 Nov 2019 13:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4dKpzKxgNAxP7uchZEE718nvYJMIp2XAO+c9cDo3MTw=; b=llfdsR0mFeyjibNMIjs4xEF9RnIEM/F4fsan8LefCEHgwtIYNAOKIWcaMLXCPUXpJ6 A9Z8a1hAgX5vph4HYseMN3OqV8I4aKmmq61yuf71G+j+fbM6F/3QgbQISzZRx++xQ6uQ rpxg24u1nhhkPdYZ+GFUsMLFT0BeCg+0eevZt88sPMVsXoz6DTHteeXsogaoUL2SzY9v ghKr14XCTinh2/ic+0QjTvbuoVjhyxGzJVQN5RBRvaOEv1Ld5FTshxsndE4TaEObzpiZ /X2kDb3o7l53lLDAuOgjn1yk+JP4f9YS1pPMkt9P5uzVOg4IpQmpskO8NUzz8gBdCY7Z QN9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4dKpzKxgNAxP7uchZEE718nvYJMIp2XAO+c9cDo3MTw=; b=r6ONq7BS4w/VBqpZeBDGg9P6gfR1Yp6+dQogNRtwF1amCYKH6WifHKkYmnXQHvDzQd avF2QneN8RFfrFN6QaMiXW5r7bK8VH7Mp9qYRzASCi/nNrS17FvagIN/lccYIcbSKDDm CR6MNS2GbjcRv4L5er2apLchmw0KwJpSPSFO8zYm/ycyQpLW/Tiut0/0UNDf3OjohVVs aYONmGgIywtKGO7phVJgB4tF4n1zWFuNN18X37XTVTtEiT1rqAICw+QynIZXXCr+X64g /OEDwIE1qUBA2+BYITuU2tJceUG5vRU6jvJ2/PK6DWHEo1N8dCOCRX49Lb2HmGWYsiwq Kltw== X-Gm-Message-State: APjAAAUylQy2Sn+mkUpdX/mxI4MuMZ3zTuUboZQO2HfRgZH0+FPT/qWz CIdxfxVYc3HGRl45lfgMape41SJy1al1NAWxkRR7nA== X-Google-Smtp-Source: APXvYqyDyHEaxIBZlzITcLvjh/p5XeQ4QgzocUuUCOwXN0WOuNqq+ARu4A8BUTsto1yGSfnwMlhvbSnvYIziXBMnd3E= X-Received: by 2002:a67:e88f:: with SMTP id x15mr1725327vsn.5.1572640378099; Fri, 01 Nov 2019 13:32:58 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-12-samitolvanen@google.com> <201910312056.E3315F0F@keescook> In-Reply-To: <201910312056.E3315F0F@keescook> From: Sami Tolvanen Date: Fri, 1 Nov 2019 13:32:46 -0700 Message-ID: Subject: Re: [PATCH v3 11/17] arm64: disable function graph tracing with SCS To: Kees Cook Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Laura Abbott , Mark Rutland , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 31, 2019 at 8:58 PM Kees Cook wrote: > IIRC, the argument was to disable these on a per-arch basis instead of > doing it as a "depends on !SHADOW_CALL_STACK" in the top-level function > graph tracer Kconfig? Yes, that's correct. > (I'm just thinking ahead to doing this again for > other architectures, though, I guess, there is much more work than just > that for, say, x86.) We can always change this later if needed, and possibly figure out how to make function graph tracing and kretprobes work with SCS. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C187FCA9ECF for ; Fri, 1 Nov 2019 20:33:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93BBF21897 for ; Fri, 1 Nov 2019 20:33:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PDZyvKj+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="llfdsR0m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93BBF21897 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iHH9P+0HNZ5AvPV8kiWos2F2xAv5DH6GhKZIRqS58Fw=; b=PDZyvKj+1zkr/V PRPwc+EqrcylKvoGv1kINHebOX0mreoZRS+aiBd5TcP9I3L46TKiDlXwA5CpiaZdcLRvafzmPU/nP 1V7/QIlgrehA6Xghj6F6+Chi7mFXZapgnMANzoYmdUxhMmIM/C+IriuVfAa2exthyWX5fEgTqkS+k 8rr2LzTtQwYNUhdk+H/P6zFsESWiNKZMSqqVe5I0OcPvCUwJVOCYMblpLsD7XGp6yqRQSw+nW71P3 BuATAHeu6ctGZ5puQYRX0MlrOHIum9VbuQU8pbw9XPbfSM5rPxx9t8w/y7tEjDPc8ZztVij7TfgGW DlRnrpSNaIvcsOg+Tc/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQdbV-0005jF-Jh; Fri, 01 Nov 2019 20:33:05 +0000 Received: from mail-vs1-xe42.google.com ([2607:f8b0:4864:20::e42]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQdbS-0005iN-N8 for linux-arm-kernel@lists.infradead.org; Fri, 01 Nov 2019 20:33:04 +0000 Received: by mail-vs1-xe42.google.com with SMTP id k15so7181051vsp.2 for ; Fri, 01 Nov 2019 13:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4dKpzKxgNAxP7uchZEE718nvYJMIp2XAO+c9cDo3MTw=; b=llfdsR0mFeyjibNMIjs4xEF9RnIEM/F4fsan8LefCEHgwtIYNAOKIWcaMLXCPUXpJ6 A9Z8a1hAgX5vph4HYseMN3OqV8I4aKmmq61yuf71G+j+fbM6F/3QgbQISzZRx++xQ6uQ rpxg24u1nhhkPdYZ+GFUsMLFT0BeCg+0eevZt88sPMVsXoz6DTHteeXsogaoUL2SzY9v ghKr14XCTinh2/ic+0QjTvbuoVjhyxGzJVQN5RBRvaOEv1Ld5FTshxsndE4TaEObzpiZ /X2kDb3o7l53lLDAuOgjn1yk+JP4f9YS1pPMkt9P5uzVOg4IpQmpskO8NUzz8gBdCY7Z QN9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4dKpzKxgNAxP7uchZEE718nvYJMIp2XAO+c9cDo3MTw=; b=bVNfM2LYvVzVoPdHt3oGmf1BwtXglwz/LmVyn7EdMvG6P9zOSpTNrfm1VdyJe2T7aQ jAq4Y2Si0zvkCrNH6s1/9m8uA/EKrR3oi7k83jwrMvZB83gUXrVUQ61KJpm1M17S9aAp fbK/3w+JOOOYfWt2Vlj0PqqLJy3/VwGaoPcgP40qUpxt1rjPm48CGumCEBz3JTxeOlma 8GuV5IbJ3P8mzAPG/t5QiFJ1lMtdLyu2Eeo7wKxS5DwPOCnkB8yyqJRmc9Tj/xOh2hSo xyHfL8nG1j0K5Urt36CiUslai4pRO5Judi8nqkbSODHBiZBd0Y/R3/THatbiVBC24u9q afaQ== X-Gm-Message-State: APjAAAXDKuGMku2oO5ckoOcVPOUoV8Z+wRBRgs/lyacbDJdBHX5ho0bT pUWaMpdyJHZ/IVioMs7N4gBN1sAnlo7Y3Ua50Hb+Bg== X-Google-Smtp-Source: APXvYqyDyHEaxIBZlzITcLvjh/p5XeQ4QgzocUuUCOwXN0WOuNqq+ARu4A8BUTsto1yGSfnwMlhvbSnvYIziXBMnd3E= X-Received: by 2002:a67:e88f:: with SMTP id x15mr1725327vsn.5.1572640378099; Fri, 01 Nov 2019 13:32:58 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-12-samitolvanen@google.com> <201910312056.E3315F0F@keescook> In-Reply-To: <201910312056.E3315F0F@keescook> From: Sami Tolvanen Date: Fri, 1 Nov 2019 13:32:46 -0700 Message-ID: Subject: Re: [PATCH v3 11/17] arm64: disable function graph tracing with SCS To: Kees Cook X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191101_133302_780247_0677788C X-CRM114-Status: GOOD ( 10.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , clang-built-linux , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , LKML , Steven Rostedt , Miguel Ojeda , Masami Hiramatsu , Kernel Hardening , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 31, 2019 at 8:58 PM Kees Cook wrote: > IIRC, the argument was to disable these on a per-arch basis instead of > doing it as a "depends on !SHADOW_CALL_STACK" in the top-level function > graph tracer Kconfig? Yes, that's correct. > (I'm just thinking ahead to doing this again for > other architectures, though, I guess, there is much more work than just > that for, say, x86.) We can always change this later if needed, and possibly figure out how to make function graph tracing and kretprobes work with SCS. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91976CA9ECF for ; Fri, 1 Nov 2019 20:33:18 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id CFB162086D for ; Fri, 1 Nov 2019 20:33:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="llfdsR0m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFB162086D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17230-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 32045 invoked by uid 550); 1 Nov 2019 20:33:11 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 32025 invoked from network); 1 Nov 2019 20:33:10 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4dKpzKxgNAxP7uchZEE718nvYJMIp2XAO+c9cDo3MTw=; b=llfdsR0mFeyjibNMIjs4xEF9RnIEM/F4fsan8LefCEHgwtIYNAOKIWcaMLXCPUXpJ6 A9Z8a1hAgX5vph4HYseMN3OqV8I4aKmmq61yuf71G+j+fbM6F/3QgbQISzZRx++xQ6uQ rpxg24u1nhhkPdYZ+GFUsMLFT0BeCg+0eevZt88sPMVsXoz6DTHteeXsogaoUL2SzY9v ghKr14XCTinh2/ic+0QjTvbuoVjhyxGzJVQN5RBRvaOEv1Ld5FTshxsndE4TaEObzpiZ /X2kDb3o7l53lLDAuOgjn1yk+JP4f9YS1pPMkt9P5uzVOg4IpQmpskO8NUzz8gBdCY7Z QN9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4dKpzKxgNAxP7uchZEE718nvYJMIp2XAO+c9cDo3MTw=; b=ENcX8lva7uyHYky3nspbcW13N42MbHzn4cF5fhnHd4NAHb+d2GQVlc+OH30HHUtW1j 1TTZMGGFGoKbNLVsHPFbKf2kyXMSHNjSkqTJiXM91Z1vo+K6OjjOGzrQ801fEZA5ybXT uPJWnkEJ6qb3BNjKcYpjHbic41AfC8qsFTc1pw3L+XivheOOUVjVc7HLLjndGh3p9/2j nCuUlUQlMpUkBEZ5FnW3CXFLZqDWGc+ILBLZCD1hf85iJegn4yOkGDVL7VXiXx09fKs/ cyTMhfW/CxXAAh75lJhuc/u4heIY/pWY2s0EDgCCSiVMNCb9VD3ej1khr9uw2UHgc+CA MBJA== X-Gm-Message-State: APjAAAVBDZxwnQfO3l19tD9AsdsLLTOpQa8uj5b15E2EsKLPvixtcg97 67U3LAFiKZuSYsATvXu5oliEKcGKdlakCucZtIcHbA== X-Google-Smtp-Source: APXvYqyDyHEaxIBZlzITcLvjh/p5XeQ4QgzocUuUCOwXN0WOuNqq+ARu4A8BUTsto1yGSfnwMlhvbSnvYIziXBMnd3E= X-Received: by 2002:a67:e88f:: with SMTP id x15mr1725327vsn.5.1572640378099; Fri, 01 Nov 2019 13:32:58 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191031164637.48901-1-samitolvanen@google.com> <20191031164637.48901-12-samitolvanen@google.com> <201910312056.E3315F0F@keescook> In-Reply-To: <201910312056.E3315F0F@keescook> From: Sami Tolvanen Date: Fri, 1 Nov 2019 13:32:46 -0700 Message-ID: Subject: Re: [PATCH v3 11/17] arm64: disable function graph tracing with SCS To: Kees Cook Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Ard Biesheuvel , Dave Martin , Laura Abbott , Mark Rutland , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , LKML Content-Type: text/plain; charset="UTF-8" On Thu, Oct 31, 2019 at 8:58 PM Kees Cook wrote: > IIRC, the argument was to disable these on a per-arch basis instead of > doing it as a "depends on !SHADOW_CALL_STACK" in the top-level function > graph tracer Kconfig? Yes, that's correct. > (I'm just thinking ahead to doing this again for > other architectures, though, I guess, there is much more work than just > that for, say, x86.) We can always change this later if needed, and possibly figure out how to make function graph tracing and kretprobes work with SCS. Sami