Re: [PATCH v7 1/2] mtd: mtdcore: add debugfs nodes for querying the flash name and id

From: Zhuohao Lee <zhuohao@chromium.org>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: "Nicolas Boichat" <drinkcat@chromium.org>,
	bbrezillon@kernel.org, richard@nod.at,
	"Brian Norris" <briannorris@chromium.org>,
	"Marek Vašut" <marek.vasut@gmail.com>,
	linux-mtd@lists.infradead.org,
	"Brian Norris" <computersforpeace@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>
Subject: Re: [PATCH v7 1/2] mtd: mtdcore: add debugfs nodes for querying the flash name and id
Date: Mon, 1 Jul 2019 00:09:47 +0800	[thread overview]
Message-ID: <CABD5yb=D1NgWueLtofGs9UftauwXwr8yheRQaCWNA+SYCj8g=A@mail.gmail.com> (raw)
In-Reply-To: <20190630094559.5a1a9a86@collabora.com>

Submitted v8 patch for the change. Thanks for the review.

On Sun, Jun 30, 2019 at 3:46 PM Boris Brezillon
<boris.brezillon@collabora.com> wrote:
>
> On Mon,  3 Jun 2019 20:38:35 +0800
> Zhuohao Lee <zhuohao@chromium.org> wrote:
>
> > +     if (IS_ERR_OR_NULL(root)) {
> > +             pr_debug("mtd device %s won't show data in debugfs\n",
> > +                      dev_name(dev));
>
> You should be able to use dev_dbg() here since you have a valid dev
> name.
done
>
> > +             return;
> > +     }
> > +
> > +     if (mtd->dbg.partid) {
> > +             dent = debugfs_create_file("partid", S_IRUSR, root, mtd,
> > +                                        &mtd_partid_debug_fops);
> > +             if (IS_ERR_OR_NULL(dent))
> > +                     pr_err("cannot create debugfs entry for partid\n");
>
> Same here, dev_err().
done
>
> > +     }
> > +     if (mtd->dbg.partname) {
> > +             dent = debugfs_create_file("partname", S_IRUSR, root, mtd,
> > +                                        &mtd_partname_debug_fops);
> > +             if (IS_ERR_OR_NULL(dent))
> > +                     pr_err("cannot create debugfs entry for partname\n");
>
> And here too.
done
>
> > +     }
> > +}
> > +
>
> Looks good otherwise. Once addressed you can add>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
added in the v8 patch

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/