All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Vikash Garodia <vgarodia@qti.qualcomm.com>,
	"Gross, Andy" <agross@kernel.org>,
	Dikshita Agarwal <dikshita@qti.qualcomm.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	devicetree@vger.kernel.org,
	Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	Jonathan Marek <jonathan@marek.ca>
Subject: Re: [PATCH 1/1] dt-bindings: media: venus: Add sm8250 dt schema
Date: Tue, 9 Feb 2021 01:59:02 +0000	[thread overview]
Message-ID: <CABDeQ7EhkS=E-QmdJsv40to=qvvMEOeYbQMNmZA8FcsxkWN3Vw@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqLE91CqOOjqmvDs-xbtbjp_T1ux7Gd375gHF8pJapUyCQ@mail.gmail.com>

On Tue, 9 Feb 2021 at 01:39, Rob Herring <robh+dt@kernel.org> wrote:
>
> On Thu, Feb 4, 2021 at 5:39 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Wed, 03 Feb 2021 11:39:14 +0000, Bryan O'Donoghue wrote:
> > > Add a schema description for the venus video encoder/decoder on the sm8250.
> > >
> > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> > > ---
> > >  .../bindings/media/qcom,sm8250-venus.yaml     | 153 ++++++++++++++++++
> > >  1 file changed, 153 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
> > >
> >
> > Applied, thanks!
>
> And now dropped. The example has lots of errors and I got tired of
> fixing them and didn't know if the undocumented properties should be
> removed or documented. Here's what I fixed so far:
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
> b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
> index 1d4b1ab63297..fe66de5d91ea 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml
> @@ -116,10 +116,13 @@ examples:
>    - |
>          #include <dt-bindings/interrupt-controller/arm-gic.h>
>          #include <dt-bindings/clock/qcom,videocc-sm8250.h>
> +        #include <dt-bindings/clock/qcom,gcc-sm8250.h>
> +        #include <dt-bindings/power/qcom-rpmpd.h>
> +        #include <dt-bindings/interconnect/qcom,sm8250.h>
>
>          venus: video-codec@aa00000 {
>              compatible = "qcom,sm8250-venus";
> -            reg = <0 0x0aa00000 0 0xff000>;
> +            reg = <0x0aa00000 0xff000>;
>              interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>              power-domains = <&videocc MVS0C_GDSC>,
>                              <&videocc MVS0_GDSC>,
> @@ -129,12 +132,12 @@ examples:
>
>              clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
>                       <&videocc VIDEO_CC_MVS0C_CLK>,
> -                     <&videocc VIDEO_CC_MVS0_CLK>;
> +                     <&videocc VIDEO_CC_MVS0_CLK_SRC>;
>              clock-names = "iface", "core", "vcodec0_core";
>
>              interconnects = <&gem_noc MASTER_AMPSS_M0 &config_noc
> SLAVE_VENUS_CFG>,
>                              <&mmss_noc MASTER_VIDEO_P0 &mc_virt SLAVE_EBI_CH0>;
> -            interconnect-names = "cpu-cfg", "video-mem";
> +            interconnect-names = "video-mem", "cpu-cfg";
>
>              iommus = <&apps_smmu 0x2100 0x0400>;
>              memory-region = <&video_mem>;
> diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dtsi
> b/arch/arm64/boot/dts/arm/foundation-v8.dtsi
> index 05ae893d1b2e..312c076379e1 100644
> --- a/arch/arm64/boot/dts/arm/foundation-v8.dtsi
> +++ b/arch/arm64/boot/dts/arm/foundation-v8.dtsi
> @@ -36,6 +36,7 @@ cpu0: cpu@0 {
>                         compatible = "arm,armv8";
>                         reg = <0x0 0x0>;
>                         next-level-cache = <&L2_0>;
> +                       next-level-cache {};
>                 };
>                 cpu1: cpu@1 {
>                         device_type = "cpu";

Sorry about that Rob, I thought my build script ran the dt checker

      reply	other threads:[~2021-02-09  2:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 11:39 [RESEND PATCH 0/1] Add dt bindings for sm8250 venus Bryan O'Donoghue
2021-02-03 11:39 ` [PATCH 1/1] dt-bindings: media: venus: Add sm8250 dt schema Bryan O'Donoghue
2021-02-04 23:39   ` Rob Herring
2021-02-09  1:39     ` Rob Herring
2021-02-09  1:59       ` Bryan O'Donoghue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABDeQ7EhkS=E-QmdJsv40to=qvvMEOeYbQMNmZA8FcsxkWN3Vw@mail.gmail.com' \
    --to=bryan.odonoghue@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dikshita@qti.qualcomm.com \
    --cc=jonathan@marek.ca \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=stanimir.varbanov@linaro.org \
    --cc=vgarodia@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.