From: chen huacai <zltjiangshi@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Huacai Chen <chenhuacai@gmail.com>,
qemu-level <qemu-devel@nongnu.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Huacai Chen <chenhc@lemote.com>,
Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 1/2] hw/mips/mips_int: De-duplicate KVM interrupt delivery
Date: Wed, 29 Apr 2020 16:48:08 +0800 [thread overview]
Message-ID: <CABDp7VoyvX2vD6awEC-GwnEu8SW=pMPPR7mrfKCSzamrnomPKg@mail.gmail.com> (raw)
In-Reply-To: <20200429082916.10669-2-f4bug@amsat.org>
Hi, Philippe,
On Wed, Apr 29, 2020 at 4:30 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Refactor duplicated code in a single place.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/mips/mips_int.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c
> index 796730b11d..4a1bf846da 100644
> --- a/hw/mips/mips_int.c
> +++ b/hw/mips/mips_int.c
> @@ -47,17 +47,12 @@ static void cpu_mips_irq_request(void *opaque, int irq, int level)
>
> if (level) {
> env->CP0_Cause |= 1 << (irq + CP0Ca_IP);
> -
> - if (kvm_enabled() && irq == 2) {
> - kvm_mips_set_interrupt(cpu, irq, level);
> - }
> -
> } else {
> env->CP0_Cause &= ~(1 << (irq + CP0Ca_IP));
> + }
Since the if-else has become one line, so can we remove { and } here?
>
> - if (kvm_enabled() && irq == 2) {
> - kvm_mips_set_interrupt(cpu, irq, level);
> - }
> + if (kvm_enabled() && irq == 2) {
> + kvm_mips_set_interrupt(cpu, irq, level);
> }
>
> if (env->CP0_Cause & CP0Ca_IP_mask) {
> --
> 2.21.1
>
>
--
Huacai Chen
next prev parent reply other threads:[~2020-04-29 8:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 8:29 [PATCH 0/2] mips: Minor simplifications for KVM use Philippe Mathieu-Daudé
2020-04-29 8:29 ` [PATCH 1/2] hw/mips/mips_int: De-duplicate KVM interrupt delivery Philippe Mathieu-Daudé
2020-04-29 8:48 ` chen huacai [this message]
2020-05-12 7:08 ` Philippe Mathieu-Daudé
2020-05-26 7:57 ` Thomas Huth
2020-05-26 8:17 ` Philippe Mathieu-Daudé
2020-04-29 8:29 ` [PATCH 2/2] target/mips/kvm: Assert unreachable code is not used Philippe Mathieu-Daudé
2020-05-12 7:09 ` Philippe Mathieu-Daudé
2020-11-24 10:41 ` Philippe Mathieu-Daudé
2020-11-24 11:02 ` Paolo Bonzini
2020-12-07 22:23 ` Philippe Mathieu-Daudé
2020-11-25 1:16 ` Huacai Chen
2020-05-26 7:52 ` [PATCH 0/2] mips: Minor simplifications for KVM use Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABDp7VoyvX2vD6awEC-GwnEu8SW=pMPPR7mrfKCSzamrnomPKg@mail.gmail.com' \
--to=zltjiangshi@gmail.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=aurelien@aurel32.net \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=f4bug@amsat.org \
--cc=jiaxun.yang@flygoat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.