All of lore.kernel.org
 help / color / mirror / Atom feed
From: chen huacai <zltjiangshi@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Huacai Chen" <chenhuacai@gmail.com>,
	qemu-level <qemu-devel@nongnu.org>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Huacai Chen" <chenhc@lemote.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH 02/12] hw/mips/fuloong2e: Rename PMON BIOS name
Date: Mon, 11 May 2020 09:14:16 +0800	[thread overview]
Message-ID: <CABDp7Vr=z0o7-G6fMOUfs7kRMvVW9SYitR==KQfG+iVXnuPPjQ@mail.gmail.com> (raw)
In-Reply-To: <20200510210128.18343-3-f4bug@amsat.org>

Hi,  Philippe,

On Mon, May 11, 2020 at 5:05 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> I'm not sure where 'pmon_fulong2e.bin' comes from. As I always
> found this bios named 'pmon_2e.bin', rename the definition.
>
The Fuloong BIOS doesn't integrated in QEMU, so its name can be
anything. So, let's keep the old name (I think the old name more
distsinguishable)?

Huacai
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/mips/mips_fulong2e.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> index ef02d54b33..f067fa9720 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -69,7 +69,7 @@
>   * 2, use "Bonito2edev" to replace "dir_corresponding_to_your_target_hardware"
>   * in the "Compile Guide".
>   */
> -#define FULONG_BIOSNAME "pmon_fulong2e.bin"
> +#define FULONG_BIOSNAME "pmon_2e.bin"
>
>  /* PCI SLOT in fulong 2e */
>  #define FULONG2E_VIA_SLOT        5
> --
> 2.21.3
>
>


-- 
Huacai Chen


  reply	other threads:[~2020-05-11  1:07 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10 21:01 [PATCH 00/12] hw/mips/fuloong2e: PoC to fix hang after reboot Philippe Mathieu-Daudé
2020-05-10 21:01 ` [PATCH 01/12] MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer Philippe Mathieu-Daudé
2020-05-11  5:46   ` Aleksandar Markovic
2020-05-10 21:01 ` [PATCH 02/12] hw/mips/fuloong2e: Rename PMON BIOS name Philippe Mathieu-Daudé
2020-05-11  1:14   ` chen huacai [this message]
2020-05-10 21:01 ` [PATCH 03/12] hw/mips/fuloong2e: Move code and update a comment Philippe Mathieu-Daudé
2020-05-11  1:15   ` chen huacai
2020-05-10 21:01 ` [PATCH 04/12] hw/mips/fuloong2e: Fix typo in Fuloong machine name Philippe Mathieu-Daudé
2020-05-11  1:19   ` chen huacai
2020-05-11  6:21     ` Aleksandar Markovic
2020-05-11  6:38       ` Philippe Mathieu-Daudé
2020-05-11  7:00         ` chen huacai
2020-05-11  8:12           ` Aleksandar Markovic
2020-05-11  8:27             ` Aleksandar Markovic
2020-05-12  8:09               ` Philippe Mathieu-Daudé
2020-05-10 21:01 ` [PATCH 05/12] hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge Philippe Mathieu-Daudé
2020-05-11  1:19   ` chen huacai
2020-05-10 21:01 ` [PATCH 06/12] hw/pci-host/bonito: Fix DPRINTF() format strings Philippe Mathieu-Daudé
2020-05-11  1:20   ` chen huacai
2020-05-10 21:01 ` [PATCH 07/12] hw/pci-host/bonito: Map peripheral using physical address Philippe Mathieu-Daudé
2020-05-11  5:50   ` Aleksandar Markovic
2020-05-10 21:01 ` [PATCH 08/12] hw/pci-host/bonito: Map all the Bonito64 I/O range Philippe Mathieu-Daudé
2020-05-11  5:51   ` Aleksandar Markovic
2020-05-10 21:01 ` [PATCH 09/12] hw/pci-host/bonito: Map the different PCI ranges more detailled Philippe Mathieu-Daudé
2020-05-11  6:12   ` Aleksandar Markovic
2020-05-11  6:33     ` Philippe Mathieu-Daudé
2020-05-10 21:01 ` [PATCH 10/12] hw/pci-host/bonito: Better describe the I/O CS regions Philippe Mathieu-Daudé
2020-05-11  5:53   ` Aleksandar Markovic
2020-05-10 21:01 ` [PATCH 11/12] hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32 Philippe Mathieu-Daudé
2020-05-11  6:17   ` Aleksandar Markovic
2020-05-11  6:30     ` Philippe Mathieu-Daudé
2020-05-11  7:16       ` Aleksandar Markovic
2020-05-10 21:01 ` [NOTFORMERGE PATCH 12/12] POC hw/pci-host/bonito: Fix BONGENCFG value after a warm-reset Philippe Mathieu-Daudé
2020-05-11  9:43 ` [PATCH 00/12] hw/mips/fuloong2e: PoC to fix hang after reboot Aleksandar Markovic
2020-05-26  7:47 ` Philippe Mathieu-Daudé
2020-05-26 10:41   ` Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABDp7Vr=z0o7-G6fMOUfs7kRMvVW9SYitR==KQfG+iVXnuPPjQ@mail.gmail.com' \
    --to=zltjiangshi@gmail.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@rt-rk.com \
    --cc=aurelien@aurel32.net \
    --cc=chenhc@lemote.com \
    --cc=chenhuacai@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.