All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Tero Roponen <tero.roponen@gmail.com>
Cc: linux-ide@vger.kernel.org, Jeff Garzik <jgarzik@redhat.com>
Subject: Re: libata: init ata_print_id to 0
Date: Sun, 22 Apr 2012 07:57:28 -0700	[thread overview]
Message-ID: <CABE8wws+5xo5b2dzQQqgwT6DqfUb_WOxr+D7TFHTUMkm4o+y7w@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1204221136450.1947@terrop>

On Sun, Apr 22, 2012 at 1:38 AM, Tero Roponen <tero.roponen@gmail.com> wrote:
>
> When comparing the dmesg between 3.4-rc3 and 3.4-rc4 I found the
> following differences:
>
>  -ata1: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff100 irq 47
>  -ata2: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff180 irq 47
>  -ata3: DUMMY
>  +ata2: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff100 irq 47
>  +ata3: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff180 irq 47
>  ata4: DUMMY
>  ata5: DUMMY
>  -ata6: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff380 irq 47
>  +ata6: DUMMY
>  +ata7: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff380 irq 47
>
> The change of numbering comes from commit 85d6725b7c0d7e3f ("libata:
> make ata_print_id atomic") that changed lines like
>
>        ap->print_id = ata_print_id++;
>                to
>        ap->print_id = atomic_inc_return(&ata_print_id);
>
> As the latter behaves like ++ata_print_id, we must initialize
> it to zero to start the numbering from one.
>
> Signed-off-by: Tero Roponen <tero.roponen@gmail.com>

Acked-by: Dan Williams <dan.j.williams@intel.com>

  reply	other threads:[~2012-04-22 14:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-22  8:38 libata: init ata_print_id to 0 Tero Roponen
2012-04-22 14:57 ` Dan Williams [this message]
2012-04-23 15:32 ` Mark Lord
2012-04-23 16:34   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABE8wws+5xo5b2dzQQqgwT6DqfUb_WOxr+D7TFHTUMkm4o+y7w@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=jgarzik@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tero.roponen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.