From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Williams Subject: Re: [PATCH 03/12] libata, libsas: introduce sched_eh and end_eh port ops Date: Mon, 23 Apr 2012 12:13:17 -0700 Message-ID: References: <20120413233343.8025.18101.stgit@dwillia2-linux.jf.intel.com> <20120413233706.8025.56546.stgit@dwillia2-linux.jf.intel.com> <1335115828.13208.31.camel@dabdike.lan> <4F94BF90.4090001@garzik.org> <1335168621.3051.8.camel@dabdike.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga09.intel.com ([134.134.136.24]:37039 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753532Ab2DWTNU convert rfc822-to-8bit (ORCPT ); Mon, 23 Apr 2012 15:13:20 -0400 Received: by bkcji2 with SMTP id ji2so1178902bkc.25 for ; Mon, 23 Apr 2012 12:13:17 -0700 (PDT) In-Reply-To: <1335168621.3051.8.camel@dabdike.lan> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: James Bottomley Cc: Jeff Garzik , Tejun Heo , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, Jacek Danecki On Mon, Apr 23, 2012 at 1:10 AM, James Bottomley wrote: > On Sun, 2012-04-22 at 22:33 -0400, Jeff Garzik wrote: >> On 04/22/2012 01:30 PM, James Bottomley wrote: >> > On Fri, 2012-04-13 at 16:37 -0700, Dan Williams wrote: >> >> When managing shost->host_eh_scheduled libata assumes that there = is a >> >> 1:1 shost-to-ata_port relationship. =A0libsas creates a 1:N relat= ionship >> >> so it needs to manage host_eh_scheduled cumulatively at the host = level. >> >> The sched_eh and end_eh port port ops allow libsas to track when = domain >> >> devices enter/leave the "eh-pending" state under ha->lock (previo= usly >> >> named ha->state_lock, but it is no longer just a lock for ha->sta= te >> >> changes). >> >> >> >> Since host_eh_scheduled indicates eh without backing commands pin= ning >> >> the device it can be deallocated at any time. =A0Move the taking = of the >> >> domain_device reference under the port_lock to guarantee that the >> >> ata_port stays around for the duration of eh. >> > >> >> Cc: Tejun Heo >> >> Acked-by: Jacek Danecki >> > >> > Could we standardise on Acked-by, please. =A0In my book it means t= he >> > maintainer of a piece of code agrees with the change and lets me t= ake it >> > through my tree. =A0I'm aware that not everyone uses this definiti= on, so >> > we can use a different standard from my current one, but what does= it >> > mean in this case? >> >> The above, IMO, should be s/Acked-by/Signed-off-by/ > > Yes, I suspect this too. No, it means: "If a person was not directly involved in the preparation or handling o= f a patch but wishes to signify and record their approval of it then they c= an arrange to have an Acked-by: line added to the patch's changelog." "Acked-by: is not as formal as Signed-off-by:. It is a record that the= acker has at least reviewed the patch and has indicated acceptance. Hence pa= tch mergers will sometimes manually convert an acker's "yep, looks good to = me" into an Acked-by:" What's wrong with Acked-by? Signed-off-by involves co-authorship or handled the patch, Reviewed-by is probably better, but maybe not everyone is comfortable asserting the "Reviewer's statement of oversight". I'll certainly continue to take Jack's "looks ok to me " as Acked-by the pm8001 maintainer for libsas changes that don't touch drivers/scsi/pm8001. =46or internal acks we should probably aim for promoting to Reviewed-by or Tested-by... if Acked-by is unwelcome in scsi. -- Dan