From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 002B3C05027 for ; Sun, 29 Jan 2023 16:47:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 62A948573B; Sun, 29 Jan 2023 17:47:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="aJUJ4+HU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A91A88574D; Sun, 29 Jan 2023 17:47:32 +0100 (CET) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DF4AB855A1 for ; Sun, 29 Jan 2023 17:47:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=dario.binacchi@amarulasolutions.com Received: by mail-ej1-x62d.google.com with SMTP id mf7so7027441ejc.6 for ; Sun, 29 Jan 2023 08:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Jk8MTx1A8nJcoESVZwdFxXLQpC9QyGulhqMEhbo8+hg=; b=aJUJ4+HUiEhf4gI85Q52t+vMvTmOqrVIQQeHL2qOFgFxGZzL7u+9zJEkvOYMasvW9d M6F7Rpq59bO5mTc6g3ffS4uptpkBaD5PZpS6olnsv36t1zkoCgef4Yb7IrvHi5jtkJm2 C8uAJroApfvPJ9HgD7M934h3KnIQYnAs03Tn0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jk8MTx1A8nJcoESVZwdFxXLQpC9QyGulhqMEhbo8+hg=; b=KLn5HA6skMoo/Q3e0R/sO0L6EvPU22fsPGanzO4dYsWGAbX/13XLka8kMaWwJYFGuQ 9mJ+KdV4jh1lZvGgqxz/gxg0fMp9AVahBXS1LvLQCK/DGUXrLtlt4PTTiUT88D+3OpgF T78tSXklHOZuUqx7+5YJhG2g+gdoToXGgf7K5rMGDC6R0djL/5jGskmRdK27h6r9dB59 /ljkvZq29UShlWWCWAw5PSVzyXaCB7zRtuYIKlTr9Syt+TpIOc1xGP/oi3DiBtwVHUHA 13r67wlNBlID5ZD+wYNrnneJUzlrFTWy5txOB2WZzL8qECaFgbJ3lvxRQ9/l5E0XZV+z t4Rg== X-Gm-Message-State: AFqh2kraSbPY1XwKy0j/wW9Rkrco8+Jn4iei3e0p5q69L+Zr1u0J6A0w ZFDG0D0kdXfNWSQ4TTWGKBYbWbB1Wtn5LWO3ajQ0/g== X-Google-Smtp-Source: AMrXdXvv21fzSk235R1qkW1KR/rVJ/NEuQJe36VBe74RVHUW8rb0FndRYYTQkWmBrvVPl6Oinv0//RgFSWm/2W4kC1o= X-Received: by 2002:a17:906:c206:b0:78d:b819:e0e7 with SMTP id d6-20020a170906c20600b0078db819e0e7mr6690802ejz.83.1675010849503; Sun, 29 Jan 2023 08:47:29 -0800 (PST) MIME-Version: 1.0 References: <20230128160858.63171-1-dario.binacchi@amarulasolutions.com> In-Reply-To: From: Dario Binacchi Date: Sun, 29 Jan 2023 17:47:18 +0100 Message-ID: Subject: Re: [RESEND PATCH] configs: imx8mn_bsh_smm_s2: remove console from bootargs To: Fabio Estevam Cc: u-boot@lists.denx.de, Tom Rini , Stefano Babic , "Ariel D'Alessandro" , Michael Trimarchi , linux-amarula@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Fabio, On Sat, Jan 28, 2023 at 6:50 PM Fabio Estevam wrote: > > Hi Dario, > > On Sat, Jan 28, 2023 at 1:09 PM Dario Binacchi > wrote: > > > > The Linux kernel device tree already specifies the device to be used for > > boot console output with a stdout-path property under /chosen. > > > > Fixes: 36b661dc919da ("Merge branch 'next'") > > The patch looks good, but I don't understand why this needs a Fixes tag. The patch re-added 'console=${console}': diff --cc include/configs/imx8mn_bsh_smm_s2.h index d09c2ab01610,84c19824bdca..c6b296281424 --- a/include/configs/imx8mn_bsh_smm_s2.h +++ b/include/configs/imx8mn_bsh_smm_s2.h @@@ -14,11 -14,8 +14,9 @@@ #include #define NANDARGS \ - "mtdids=" CONFIG_MTDIDS_DEFAULT "\0" \ - "mtdparts=" CONFIG_MTDPARTS_DEFAULT "\0" \ - "nandargs=setenv bootargs " \ + "nandargs=setenv bootargs console=${console} " \ "${optargs} " \ + "mtdparts=${mtdparts} " \ "root=${nandroot} " \ "rootfstype=${nandrootfstype}\0" \ "nandroot=ubi0:root rw ubi.mtd=nandrootfs\0" \ that I already removed in the commit: bede82f75075 ("configs: imx8mn_bsh_smm_s2: remove console from bootargs"). This is why I decided to add the fix tag. Thanks and regards, Dario > > Reviewed-by: Fabio Estevam -- Dario Binacchi Senior Embedded Linux Developer dario.binacchi@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com