From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C58FFC77B61 for ; Tue, 28 Mar 2023 09:31:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232656AbjC1JbC (ORCPT ); Tue, 28 Mar 2023 05:31:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232771AbjC1JaU (ORCPT ); Tue, 28 Mar 2023 05:30:20 -0400 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDA617699 for ; Tue, 28 Mar 2023 02:29:16 -0700 (PDT) Received: by mail-yb1-xb34.google.com with SMTP id z83so14204196ybb.2 for ; Tue, 28 Mar 2023 02:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1679995751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yFB98fl8c+VxJhat2aITQJylt85+D41Na+tueFpnBAE=; b=h6Vz5hHsFbSVlybmIlvV3llRGY6zxdMBPqd7vuRnJb91gssIrU+JkHC8x3k8jk99aZ TUV+/AV65p6lGjzaxQBmfrutizEWwOo+EZeXN/NHKK4LwatIFW/QwCXbyNZ7bW8Vvnd5 K2dz4isaG3Fg9/yhee6xJqIWq4kl98h+rwO8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679995751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yFB98fl8c+VxJhat2aITQJylt85+D41Na+tueFpnBAE=; b=0C9KiI8/teW9r8mId5yih6Uc/TzBOOvoE+iNJBJJL3Cr4rKTF6mrQmxRyDUxeY2xET GO/3tc+JcAv28EYkKRw7HFhhTE/lI5QJ4Et0MAL6W1X2DMshCi+UlpChQM8tYaLXzGMT ONIgflCHyhh9gJTksNOnZ1DDaz7G1059of8CzPfEvfi+Mp3QHVZ+dxnu9Po7oJxX4Tsy iM8YTgKW/LBNbjwHTz7Q8L3p+eLDNp80EbaOOGQnq1RgWFWM3M1nVjOj2fA6ijQxFqW4 RXXox/vfr4Zlo7M0eMXAM1i6sqxZnYfTOqVhgm7E58wwXP1MfQqrhcFRCqm5+UptdL0f G4Ng== X-Gm-Message-State: AAQBX9fV9vRuaQUY6JQduKKFx7nZr96ZSeqPe+eZ0odsNvBhZuJXe3y7 yNvxjBv9AOWXin+449H/ry/lxAL/bkmfof6Vao9N3w== X-Google-Smtp-Source: AKy350afBwmCZQBALVcAA/Tbw4Xqq5Zxd871dGI57F78yPyqoxYIijJLMdgmt6M0w+Y8hISHOAZdDyJishaV0ICRHKo= X-Received: by 2002:a05:6902:188f:b0:b78:bced:2e3d with SMTP id cj15-20020a056902188f00b00b78bced2e3dmr7396712ybb.3.1679995751012; Tue, 28 Mar 2023 02:29:11 -0700 (PDT) MIME-Version: 1.0 References: <20230328073328.3949796-1-dario.binacchi@amarulasolutions.com> <20230328084710.jnrwvydewx3atxti@pengutronix.de> In-Reply-To: <20230328084710.jnrwvydewx3atxti@pengutronix.de> From: Dario Binacchi Date: Tue, 28 Mar 2023 11:28:59 +0200 Message-ID: Subject: Re: [PATCH v10 0/5] can: bxcan: add support for ST bxCAN controller To: Marc Kleine-Budde Cc: linux-kernel@vger.kernel.org, Vincent Mailhol , Rob Herring , Amarula patchwork , michael@amarulasolutions.com, Alexandre Torgue , Krzysztof Kozlowski , Christophe Roullier , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Mark Brown , Maxime Coquelin , Paolo Abeni , Rob Herring , Viresh Kumar , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hi Marc, On Tue, Mar 28, 2023 at 10:47=E2=80=AFAM Marc Kleine-Budde wrote: > > On 28.03.2023 09:33:23, Dario Binacchi wrote: > > The series adds support for the basic extended CAN controller (bxCAN) > > found in many low- to middle-end STM32 SoCs. > > > > The driver has been tested on the stm32f469i-discovery board with a > > kernel version 5.19.0-rc2 in loopback + silent mode: > > > > ip link set can0 type can bitrate 125000 loopback on listen-only on > > ip link set up can0 > > candump can0 -L & > > cansend can0 300#AC.AB.AD.AE.75.49.AD.D1 > > > > For uboot and kernel compilation, as well as for rootfs creation I used > > buildroot: > > > > make stm32f469_disco_sd_defconfig > > make > > > > but I had to patch can-utils and busybox as can-utils and iproute are > > not compiled for MMU-less microcotrollers. In the case of can-utils, > > replacing the calls to fork() with vfork(), I was able to compile the > > package with working candump and cansend applications, while in the > > case of iproute, I ran into more than one problem and finally I decided > > to extend busybox's ip link command for CAN-type devices. I'm still > > wondering if it was really necessary, but this way I was able to test > > the driver. > > Applied to linux-can-next. Just one last question: To test this series, as described in the cover letter, I could not use the iproute2 package since the microcontroller is without MMU. I then extended busybox f= or the ip link command. I actually also added the rtnl-link-can.c application to the libmnl library. So now I find myself with two applications that have been useful to me for this type of use case. Did I do useless work because I could use other tools? If instead the tools= for this use case are missing, what do you think is better to do? Submit to their respective repos or add this functionality to another project that I haven't considered ? Thanks and regards, Dario > > Thanks, > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | https://www.pengutronix.de | > Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --=20 Dario Binacchi Senior Embedded Linux Developer dario.binacchi@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E5F4C76196 for ; Tue, 28 Mar 2023 09:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MZLWTmKSzVQFtAyICDcqyiIGhic3E9M4i3bRi+Pr4js=; b=RSQWEfDJxSzTv9 4+N4yrMCbdiNe9FJb5D3MXEEAPQk7ydLUysxQq6ZXooYcic6GKj3wyxjb331HCrJT6ifnO+p9vymo QL6HQaYfhLv1DX31hEHwFZH3CiQAAfrGXdHtCcrQOtkZNdZaUivgxmP+w3VtDvhR/HDLJrXIVU4s1 1MBniCYUb+KXGhOmNZ5QBrvIYUwF98IaRB1Knc35nNCg/FICiKDm+dMotUA8VMRieVqjngsidHomD giW4lnMkYuF5VsftBe1WJWBY3c48kE/c9++vG64aY08gNAcJ91kCgSV7Roi8SYpa6KFWkwy1LduXX W/A7moP/3f74PPSCuFlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ph5dj-00DkWc-0C; Tue, 28 Mar 2023 09:29:15 +0000 Received: from mail-yb1-xb2b.google.com ([2607:f8b0:4864:20::b2b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ph5dg-00DkVc-0C for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 09:29:13 +0000 Received: by mail-yb1-xb2b.google.com with SMTP id y5so14211638ybu.3 for ; Tue, 28 Mar 2023 02:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1679995751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yFB98fl8c+VxJhat2aITQJylt85+D41Na+tueFpnBAE=; b=h6Vz5hHsFbSVlybmIlvV3llRGY6zxdMBPqd7vuRnJb91gssIrU+JkHC8x3k8jk99aZ TUV+/AV65p6lGjzaxQBmfrutizEWwOo+EZeXN/NHKK4LwatIFW/QwCXbyNZ7bW8Vvnd5 K2dz4isaG3Fg9/yhee6xJqIWq4kl98h+rwO8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679995751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yFB98fl8c+VxJhat2aITQJylt85+D41Na+tueFpnBAE=; b=p/W1k+aQXGi1KeQby0n/bd2uWn6jgnj00lwAqF7/6PKEBawWLaykNnen9NX3a/++Qb C0DBZBCPr/Kc8/Hh9Oqes3kxaA74JX7GIq5fndnYyiMqpgbX94iMRkTVJDHFwB4oiq/w /OcA/PFegVgu09E7cMZvTAi1W2zIzAmw8eselxcBAYKd4BnYMaL8GMDe/9LxhRIbYO6r Qe4qZqbkwZYRlzbN6SsHteyJGmUTO7cxHhQviLpagcZfGgDWySctwgJ7yn99kO50LeIY RgcnVpWR2VCr/pCt6lXKSFyU/O6iZ5Cqxqb/FSI0HekXiaZS/b8BgnkwYBS5i3rUEsyg JDqw== X-Gm-Message-State: AAQBX9cW4X2t9lOhbyTcKJV3d6rnWjGFkRxXd27U124WC8jz4ZDRGlOn aOfhu4PfWjc4FtH8KJuhvlCRiog+p4hY3c2bS0kcyw== X-Google-Smtp-Source: AKy350afBwmCZQBALVcAA/Tbw4Xqq5Zxd871dGI57F78yPyqoxYIijJLMdgmt6M0w+Y8hISHOAZdDyJishaV0ICRHKo= X-Received: by 2002:a05:6902:188f:b0:b78:bced:2e3d with SMTP id cj15-20020a056902188f00b00b78bced2e3dmr7396712ybb.3.1679995751012; Tue, 28 Mar 2023 02:29:11 -0700 (PDT) MIME-Version: 1.0 References: <20230328073328.3949796-1-dario.binacchi@amarulasolutions.com> <20230328084710.jnrwvydewx3atxti@pengutronix.de> In-Reply-To: <20230328084710.jnrwvydewx3atxti@pengutronix.de> From: Dario Binacchi Date: Tue, 28 Mar 2023 11:28:59 +0200 Message-ID: Subject: Re: [PATCH v10 0/5] can: bxcan: add support for ST bxCAN controller To: Marc Kleine-Budde Cc: linux-kernel@vger.kernel.org, Vincent Mailhol , Rob Herring , Amarula patchwork , michael@amarulasolutions.com, Alexandre Torgue , Krzysztof Kozlowski , Christophe Roullier , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Mark Brown , Maxime Coquelin , Paolo Abeni , Rob Herring , Viresh Kumar , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_022912_109332_67EE805B X-CRM114-Status: GOOD ( 30.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFyYywKCk9uIFR1ZSwgTWFyIDI4LCAyMDIzIGF0IDEwOjQ34oCvQU0gTWFyYyBLbGVpbmUt QnVkZGUgPG1rbEBwZW5ndXRyb25peC5kZT4gd3JvdGU6Cj4KPiBPbiAyOC4wMy4yMDIzIDA5OjMz OjIzLCBEYXJpbyBCaW5hY2NoaSB3cm90ZToKPiA+IFRoZSBzZXJpZXMgYWRkcyBzdXBwb3J0IGZv ciB0aGUgYmFzaWMgZXh0ZW5kZWQgQ0FOIGNvbnRyb2xsZXIgKGJ4Q0FOKQo+ID4gZm91bmQgaW4g bWFueSBsb3ctIHRvIG1pZGRsZS1lbmQgU1RNMzIgU29Dcy4KPiA+Cj4gPiBUaGUgZHJpdmVyIGhh cyBiZWVuIHRlc3RlZCBvbiB0aGUgc3RtMzJmNDY5aS1kaXNjb3ZlcnkgYm9hcmQgd2l0aCBhCj4g PiBrZXJuZWwgdmVyc2lvbiA1LjE5LjAtcmMyIGluIGxvb3BiYWNrICsgc2lsZW50IG1vZGU6Cj4g Pgo+ID4gaXAgbGluayBzZXQgY2FuMCB0eXBlIGNhbiBiaXRyYXRlIDEyNTAwMCBsb29wYmFjayBv biBsaXN0ZW4tb25seSBvbgo+ID4gaXAgbGluayBzZXQgdXAgY2FuMAo+ID4gY2FuZHVtcCBjYW4w IC1MICYKPiA+IGNhbnNlbmQgY2FuMCAzMDAjQUMuQUIuQUQuQUUuNzUuNDkuQUQuRDEKPiA+Cj4g PiBGb3IgdWJvb3QgYW5kIGtlcm5lbCBjb21waWxhdGlvbiwgYXMgd2VsbCBhcyBmb3Igcm9vdGZz IGNyZWF0aW9uIEkgdXNlZAo+ID4gYnVpbGRyb290Ogo+ID4KPiA+IG1ha2Ugc3RtMzJmNDY5X2Rp c2NvX3NkX2RlZmNvbmZpZwo+ID4gbWFrZQo+ID4KPiA+IGJ1dCBJIGhhZCB0byBwYXRjaCBjYW4t dXRpbHMgYW5kIGJ1c3lib3ggYXMgY2FuLXV0aWxzIGFuZCBpcHJvdXRlIGFyZQo+ID4gbm90IGNv bXBpbGVkIGZvciBNTVUtbGVzcyBtaWNyb2NvdHJvbGxlcnMuIEluIHRoZSBjYXNlIG9mIGNhbi11 dGlscywKPiA+IHJlcGxhY2luZyB0aGUgY2FsbHMgdG8gZm9yaygpIHdpdGggdmZvcmsoKSwgSSB3 YXMgYWJsZSB0byBjb21waWxlIHRoZQo+ID4gcGFja2FnZSB3aXRoIHdvcmtpbmcgY2FuZHVtcCBh bmQgY2Fuc2VuZCBhcHBsaWNhdGlvbnMsIHdoaWxlIGluIHRoZQo+ID4gY2FzZSBvZiBpcHJvdXRl LCBJIHJhbiBpbnRvIG1vcmUgdGhhbiBvbmUgcHJvYmxlbSBhbmQgZmluYWxseSBJIGRlY2lkZWQK PiA+IHRvIGV4dGVuZCBidXN5Ym94J3MgaXAgbGluayBjb21tYW5kIGZvciBDQU4tdHlwZSBkZXZp Y2VzLiBJJ20gc3RpbGwKPiA+IHdvbmRlcmluZyBpZiBpdCB3YXMgcmVhbGx5IG5lY2Vzc2FyeSwg YnV0IHRoaXMgd2F5IEkgd2FzIGFibGUgdG8gdGVzdAo+ID4gdGhlIGRyaXZlci4KPgo+IEFwcGxp ZWQgdG8gbGludXgtY2FuLW5leHQuCgpKdXN0IG9uZSBsYXN0IHF1ZXN0aW9uOgpUbyB0ZXN0IHRo aXMgc2VyaWVzLCBhcyBkZXNjcmliZWQgaW4gdGhlIGNvdmVyIGxldHRlciwgSSBjb3VsZCBub3Qg dXNlCnRoZSBpcHJvdXRlMgpwYWNrYWdlIHNpbmNlIHRoZSBtaWNyb2NvbnRyb2xsZXIgaXMgd2l0 aG91dCBNTVUuIEkgdGhlbiBleHRlbmRlZCBidXN5Ym94IGZvcgp0aGUgaXAgbGluayBjb21tYW5k LiBJIGFjdHVhbGx5IGFsc28gYWRkZWQgdGhlIHJ0bmwtbGluay1jYW4uYwphcHBsaWNhdGlvbiB0 byB0aGUKbGlibW5sIGxpYnJhcnkuIFNvIG5vdyBJIGZpbmQgbXlzZWxmIHdpdGggdHdvIGFwcGxp Y2F0aW9ucyB0aGF0IGhhdmUKYmVlbiB1c2VmdWwKdG8gbWUgZm9yIHRoaXMgdHlwZSBvZiB1c2Ug Y2FzZS4KRGlkIEkgZG8gdXNlbGVzcyB3b3JrIGJlY2F1c2UgSSBjb3VsZCB1c2Ugb3RoZXIgdG9v bHM/IElmIGluc3RlYWQgdGhlIHRvb2xzIGZvcgp0aGlzIHVzZSBjYXNlIGFyZSBtaXNzaW5nLCB3 aGF0IGRvIHlvdSB0aGluayBpcyBiZXR0ZXIgdG8gZG8/ClN1Ym1pdCB0byB0aGVpciByZXNwZWN0 aXZlIHJlcG9zIG9yIGFkZCB0aGlzIGZ1bmN0aW9uYWxpdHkgdG8gYW5vdGhlcgpwcm9qZWN0IHRo YXQKSSBoYXZlbid0IGNvbnNpZGVyZWQgPwoKVGhhbmtzIGFuZCByZWdhcmRzLApEYXJpbwoKPgo+ IFRoYW5rcywKPiBNYXJjCj4KPiAtLQo+IFBlbmd1dHJvbml4IGUuSy4gICAgICAgICAgICAgICAg IHwgTWFyYyBLbGVpbmUtQnVkZGUgICAgICAgICAgIHwKPiBFbWJlZGRlZCBMaW51eCAgICAgICAg ICAgICAgICAgICB8IGh0dHBzOi8vd3d3LnBlbmd1dHJvbml4LmRlICB8Cj4gVmVydHJldHVuZyBO w7xybmJlcmcgICAgICAgICAgICAgIHwgUGhvbmU6ICs0OS01MTIxLTIwNjkxNy0xMjkgIHwKPiBB bXRzZ2VyaWNodCBIaWxkZXNoZWltLCBIUkEgMjY4NiB8IEZheDogICArNDktNTEyMS0yMDY5MTct NTU1NSB8CgoKCi0tIAoKRGFyaW8gQmluYWNjaGkKClNlbmlvciBFbWJlZGRlZCBMaW51eCBEZXZl bG9wZXIKCmRhcmlvLmJpbmFjY2hpQGFtYXJ1bGFzb2x1dGlvbnMuY29tCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCgoKQW1hcnVsYSBTb2x1dGlvbnMgU1JMCgpWaWEgTGUgQ2Fu ZXZhcmUgMzAsIDMxMTAwIFRyZXZpc28sIFZlbmV0bywgSVQKClQuICszOSAwNDIgMjQzIDUzMTAK aW5mb0BhbWFydWxhc29sdXRpb25zLmNvbQoKd3d3LmFtYXJ1bGFzb2x1dGlvbnMuY29tCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==