All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Tomer <amittomer25@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 3/3] riscv: sifive: fu540: add SPL configuration
Date: Tue, 31 Dec 2019 22:48:41 +0530	[thread overview]
Message-ID: <CABHD4K88uWDvReNYpRU7DFuqBRQOEWixa_aaghguugFRAkgvnw@mail.gmail.com> (raw)
In-Reply-To: <20191231063055.19412-4-pragnesh.patel@sifive.com>

Hi Pragnesh,

Minor comments regarding coding style, see below.

> +       // Probably don't need to do this, since
> +       // all the other stuff has been happening.
> +       // But it is on the wave form.

U-boot is mostly implemented in C, we should *not* use C++ style comments(//).
is this something picked from BSP code ?

> +#include "include/ccache.h"
> +#include "include/fu540-memory-map.h"

This looks bit strange, I mean the double include above

> +// Inlining header functions in C
> +// https://stackoverflow.com/a/23699777/7433423

This could be conveyed in comments rather then pointing some external
link.

Thanks
-Amit.

  reply	other threads:[~2019-12-31 17:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-31  6:30 [PATCH 0/3] RISC-V SiFive FU540 support SPL Pragnesh Patel
2019-12-31  6:30 ` [PATCH 1/3] riscv: Add place-holder for FU540 clk and gpio Pragnesh Patel
2020-01-03 14:47   ` Bin Meng
2020-01-06  9:07     ` Pragnesh Patel
2019-12-31  6:30 ` [PATCH 2/3] riscv: Add FU540 specific includes Pragnesh Patel
2020-01-03 14:51   ` Bin Meng
2020-01-06  9:41     ` Pragnesh Patel
2019-12-31  6:30 ` [PATCH 3/3] riscv: sifive: fu540: add SPL configuration Pragnesh Patel
2019-12-31 17:18   ` Amit Tomer [this message]
2020-01-13 13:36     ` Pragnesh Patel
2020-01-02  4:58   ` Jagan Teki
2020-01-06 10:08     ` Pragnesh Patel
2020-01-13 14:32       ` Pragnesh Patel
2020-01-13 22:31         ` Lukas Auer
2020-01-15  5:12           ` Troy Benjegerdes
2020-01-15 17:41             ` Lukas Auer
2020-01-03 15:34   ` Bin Meng
2020-01-13 14:54     ` Pragnesh Patel
2020-01-14  5:10 ` [PATCH 0/3] RISC-V SiFive FU540 support SPL Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABHD4K88uWDvReNYpRU7DFuqBRQOEWixa_aaghguugFRAkgvnw@mail.gmail.com \
    --to=amittomer25@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.