All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Tomer <amittomer25@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: xen-devel@lists.xenproject.org,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v2] xen:arm: Populate arm64 image header
Date: Wed, 5 Sep 2018 18:22:08 +0530	[thread overview]
Message-ID: <CABHD4K8uWYXH1xodmrgS+689x=X=R4BvEDR+xKmxCaNw-H-UWA@mail.gmail.com> (raw)
In-Reply-To: <8af6b645-b5b4-d0fb-e25a-69b2ad988445@arm.com>

Hello,

Thanks for having a look.

On Wed, Sep 5, 2018 at 6:07 PM Andre Przywara <andre.przywara@arm.com> wrote:
>
> Hi,
>
> I don't think it's helpful to hide that KERNEL_SIZE definition in
> another file. Please just put "_end - start" here.

Yeah,  I thought about it and felt that it would be cleaner and more
readable if we use macros here.

Also, wanted to have minimal changes in head.S and that is the reason
for using assemble.h.

> Either you call this __HEAD_FLAG_PAGE_SIZE_4K, or, even better, copy the
> Linux definition, which would make it obvious where this comes from and
> would alert any developer of the PAGE_SIZE dependency.
>
> Plus move those into head.S, as mentioned above.

Ok.
> > +
> > +#define __KERNEL_SIZE           (_end - start)
> > +
> >  #endif /* __ASM_ASSEMBLER_H__ */
> >

Thanks
-Amit

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-09-05 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 17:25 [PATCH v2] xen:arm: Populate arm64 image header Amit Singh Tomar
2018-09-05 12:37 ` Andre Przywara
2018-09-05 12:52   ` Amit Tomer [this message]
2018-09-05 13:04     ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABHD4K8uWYXH1xodmrgS+689x=X=R4BvEDR+xKmxCaNw-H-UWA@mail.gmail.com' \
    --to=amittomer25@gmail.com \
    --cc=andre.przywara@arm.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.