From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nobuhiro Iwamatsu Date: Sun, 14 May 2017 06:45:55 +0900 Subject: [U-Boot] [PATCH 2/5] mmc: sh_sdhi: Set SD_INFOx interrupt mask before command starting In-Reply-To: <20170513135118.8134-2-marek.vasut+renesas@gmail.com> References: <20170513135118.8134-1-marek.vasut+renesas@gmail.com> <20170513135118.8134-2-marek.vasut+renesas@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, 2017-05-13 22:51 GMT+09:00 Marek Vasut : > From: Kouei Abe > > When setting interrupt mask after command starting, an unintended > interrupt status sometimes occurs. > > Signed-off-by: Kouei Abe > Signed-off-by: Hiroyuki Yokoyama > Cc: Hiroyuki Yokoyama > Cc: Nobuhiro Iwamatsu > Cc: Jaehoon Chung Reviewed-by: Nobuhiro Iwamatsu > --- > drivers/mmc/sh_sdhi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/sh_sdhi.c b/drivers/mmc/sh_sdhi.c > index 25224e2e1d..7f0b4c2603 100644 > --- a/drivers/mmc/sh_sdhi.c > +++ b/drivers/mmc/sh_sdhi.c > @@ -546,8 +546,6 @@ static int sh_sdhi_start_cmd(struct sh_sdhi_host *host, > break; > } > > - sh_sdhi_writew(host, SDHI_CMD, (unsigned short)(opc & CMD_MASK)); > - > host->wait_int = 0; > sh_sdhi_writew(host, SDHI_INFO1_MASK, > ~INFO1M_RESP_END & sh_sdhi_readw(host, SDHI_INFO1_MASK)); > @@ -557,6 +555,8 @@ static int sh_sdhi_start_cmd(struct sh_sdhi_host *host, > INFO2M_RESP_TIMEOUT | INFO2M_ILA) & > sh_sdhi_readw(host, SDHI_INFO2_MASK)); > > + sh_sdhi_writew(host, SDHI_CMD, (unsigned short)(opc & CMD_MASK)); > + > time = sh_sdhi_wait_interrupt_flag(host); > if (!time) > return sh_sdhi_error_manage(host); > -- > 2.11.0 > -- Nobuhiro Iwamatsu iwamatsu at {nigauri.org / debian.org} GPG ID: 40AD1FA6