All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile
@ 2014-01-22 22:52 Nobuhiro Iwamatsu
  2014-01-22 22:52 ` [U-Boot] [PATCH 2/3] net: sh-eth: Fix coding style Nobuhiro Iwamatsu
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-01-22 22:52 UTC (permalink / raw)
  To: u-boot

The R7S72100 of ARM SoC that Renesas manufactured has one Ether port.
This has the same IP SH-Ether. This patch adds support of the R7S72100
in SH-Ether.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
 drivers/net/sh_eth.c | 10 ++++---
 drivers/net/sh_eth.h | 81 +++++++++++++++++++++++++++++++++++++++++++++-------
 2 files changed, 77 insertions(+), 14 deletions(-)

diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
index 5e132f2..0cb963f 100644
--- a/drivers/net/sh_eth.c
+++ b/drivers/net/sh_eth.c
@@ -148,7 +148,7 @@ int sh_eth_recv(struct eth_device *dev)
 
 static int sh_eth_reset(struct sh_eth_dev *eth)
 {
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 	int ret = 0, i;
 
 	/* Start e-dmac transmitter and receiver */
@@ -218,7 +218,7 @@ static int sh_eth_tx_desc_init(struct sh_eth_dev *eth)
 	/* Point the controller to the tx descriptor list. Must use physical
 	   addresses */
 	sh_eth_write(eth, ADDR_TO_PHY(port_info->tx_desc_base), TDLAR);
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 	sh_eth_write(eth, ADDR_TO_PHY(port_info->tx_desc_base), TDFAR);
 	sh_eth_write(eth, ADDR_TO_PHY(cur_tx_desc), TDFXR);
 	sh_eth_write(eth, 0x01, TDFFR);/* Last discriptor bit */
@@ -288,7 +288,7 @@ static int sh_eth_rx_desc_init(struct sh_eth_dev *eth)
 
 	/* Point the controller to the rx descriptor list */
 	sh_eth_write(eth, ADDR_TO_PHY(port_info->rx_desc_base), RDLAR);
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 	sh_eth_write(eth, ADDR_TO_PHY(port_info->rx_desc_base), RDFAR);
 	sh_eth_write(eth, ADDR_TO_PHY(cur_rx_desc), RDFXR);
 	sh_eth_write(eth, RDFFR_RDLF, RDFFR);
@@ -384,7 +384,7 @@ static int sh_eth_config(struct sh_eth_dev *eth, bd_t *bd)
 	sh_eth_write(eth, 0, TFTR);
 	sh_eth_write(eth, (FIFO_SIZE_T | FIFO_SIZE_R), FDR);
 	sh_eth_write(eth, RMCR_RST, RMCR);
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 	sh_eth_write(eth, 0, RPADIR);
 #endif
 	sh_eth_write(eth, (FIFO_F_D_RFF | FIFO_F_D_RFD), FCFTR);
@@ -403,6 +403,8 @@ static int sh_eth_config(struct sh_eth_dev *eth, bd_t *bd)
 	sh_eth_write(eth, RFLR_RFL_MIN, RFLR);
 #if defined(SH_ETH_TYPE_GETHER)
 	sh_eth_write(eth, 0, PIPR);
+#endif
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 	sh_eth_write(eth, APR_AP, APR);
 	sh_eth_write(eth, MPR_MP, MPR);
 	sh_eth_write(eth, TPAUSER_TPAUSE, TPAUSER);
diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h
index 331c07c..0925759 100644
--- a/drivers/net/sh_eth.h
+++ b/drivers/net/sh_eth.h
@@ -230,6 +230,61 @@ static const u16 sh_eth_offset_gigabit[SH_ETH_MAX_REGISTER_OFFSET] = {
 	[RMII_MII] =  0x0790,
 };
 
+#if defined(SH_ETH_TYPE_RZ)
+static const u16 sh_eth_offset_rz[SH_ETH_MAX_REGISTER_OFFSET] = {
+	[EDSR]	= 0x0000,
+	[EDMR]	= 0x0400,
+	[EDTRR]	= 0x0408,
+	[EDRRR]	= 0x0410,
+	[EESR]	= 0x0428,
+	[EESIPR]	= 0x0430,
+	[TDLAR]	= 0x0010,
+	[TDFAR]	= 0x0014,
+	[TDFXR]	= 0x0018,
+	[TDFFR]	= 0x001c,
+	[RDLAR]	= 0x0030,
+	[RDFAR]	= 0x0034,
+	[RDFXR]	= 0x0038,
+	[RDFFR]	= 0x003c,
+	[TRSCER]	= 0x0438,
+	[RMFCR]	= 0x0440,
+	[TFTR]	= 0x0448,
+	[FDR]	= 0x0450,
+	[RMCR]	= 0x0458,
+	[RPADIR]	= 0x0460,
+	[FCFTR]	= 0x0468,
+	[CSMR] = 0x04E4,
+
+	[ECMR]	= 0x0500,
+	[ECSR]	= 0x0510,
+	[ECSIPR]	= 0x0518,
+	[PSR]	= 0x0528,
+	[PIPR]	= 0x052c,
+	[RFLR]	= 0x0508,
+	[APR]	= 0x0554,
+	[MPR]	= 0x0558,
+	[PFTCR]	= 0x055c,
+	[PFRCR]	= 0x0560,
+	[TPAUSER]	= 0x0564,
+	[GECMR]	= 0x05b0,
+	[BCULR]	= 0x05b4,
+	[MAHR]	= 0x05c0,
+	[MALR]	= 0x05c8,
+	[TROCR]	= 0x0700,
+	[CDCR]	= 0x0708,
+	[LCCR]	= 0x0710,
+	[CEFCR]	= 0x0740,
+	[FRECR]	= 0x0748,
+	[TSFRCR]	= 0x0750,
+	[TLFRCR]	= 0x0758,
+	[RFCR]	= 0x0760,
+	[CERCR]	= 0x0768,
+	[CEECR]	= 0x0770,
+	[MAFCR]	= 0x0778,
+	[RMII_MII] =  0x0790,
+};
+#endif
+
 static const u16 sh_eth_offset_fast_sh4[SH_ETH_MAX_REGISTER_OFFSET] = {
 	[ECMR]	= 0x0100,
 	[RFLR]	= 0x0108,
@@ -306,13 +361,16 @@ static const u16 sh_eth_offset_fast_sh4[SH_ETH_MAX_REGISTER_OFFSET] = {
 #elif defined(CONFIG_R8A7790) || defined(CONFIG_R8A7791)
 #define SH_ETH_TYPE_ETHER
 #define BASE_IO_ADDR	0xEE700200
+#elif defined(CONFIG_R7S72100)
+#define SH_ETH_TYPE_RZ
+#define BASE_IO_ADDR	0xE8203000
 #endif
 
 /*
  * Register's bits
  * Copy from Linux driver source code
  */
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 /* EDSR */
 enum EDSR_BIT {
 	EDSR_ENT = 0x01, EDSR_ENR = 0x02,
@@ -323,7 +381,7 @@ enum EDSR_BIT {
 /* EDMR */
 enum DMAC_M_BIT {
 	EDMR_DL1 = 0x20, EDMR_DL0 = 0x10,
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 	EDMR_SRST	= 0x03, /* Receive/Send reset */
 	EMDR_DESC_R	= 0x30, /* Descriptor reserve size */
 	EDMR_EL		= 0x40, /* Litte endian */
@@ -349,7 +407,7 @@ enum DMAC_M_BIT {
 
 /* EDTRR */
 enum DMAC_T_BIT {
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 	EDTRR_TRNS = 0x03,
 #else
 	EDTRR_TRNS = 0x01,
@@ -424,7 +482,7 @@ enum EESR_BIT {
 };
 
 
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 # define TX_CHECK (EESR_TC1 | EESR_FTC)
 # define EESR_ERR_CHECK	(EESR_TWB | EESR_TABT | EESR_RABT | EESR_RDE \
 		| EESR_RFRMER | EESR_TFE | EESR_TDE | EESR_ECI)
@@ -484,7 +542,8 @@ enum FCFTR_BIT {
 
 /* Transfer descriptor bit */
 enum TD_STS_BIT {
-#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_ETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_ETHER) || \
+	defined(SH_ETH_TYPE_RZ)
 	TD_TACT = 0x80000000,
 #else
 	TD_TACT = 0x7fffffff,
@@ -500,7 +559,7 @@ enum TD_STS_BIT {
 enum RECV_RST_BIT { RMCR_RST = 0x01, };
 /* ECMR */
 enum FELIC_MODE_BIT {
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 	ECMR_TRCCM=0x04000000, ECMR_RCSC= 0x00800000, ECMR_DPAD= 0x00200000,
 	ECMR_RZPF = 0x00100000,
 #endif
@@ -517,7 +576,7 @@ enum FELIC_MODE_BIT {
 
 };
 
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 #define ECMR_CHG_DM	(ECMR_TRCCM | ECMR_RZPF | ECMR_ZPF | ECMR_PFR | ECMR_RXF | \
 						ECMR_TXF | ECMR_MCT)
 #elif defined(SH_ETH_TYPE_ETHER)
@@ -535,7 +594,7 @@ enum ECSR_STATUS_BIT {
 	ECSR_MPD = 0x02, ECSR_ICD = 0x01,
 };
 
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 # define ECSR_INIT (ECSR_ICD | ECSIPR_MPDIP)
 #else
 # define ECSR_INIT (ECSR_BRCRX | ECSR_PSRTO | \
@@ -556,7 +615,7 @@ enum ECSIPR_STATUS_MASK_BIT {
 	ECSIPR_ICDIP = 0x01,
 };
 
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 # define ECSIPR_INIT (ECSIPR_LCHNGIP | ECSIPR_ICDIP | ECSIPR_MPDIP)
 #else
 # define ECSIPR_INIT (ECSIPR_BRCRXIP | ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | \
@@ -587,7 +646,7 @@ enum RPADIR_BIT {
 	RPADIR_PADR = 0x0003f,
 };
 
-#if defined(SH_ETH_TYPE_GETHER)
+#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
 # define RPADIR_INIT (0x00)
 #else
 # define RPADIR_INIT (RPADIR_PADS1)
@@ -605,6 +664,8 @@ static inline unsigned long sh_eth_reg_addr(struct sh_eth_dev *eth,
 	const u16 *reg_offset = sh_eth_offset_gigabit;
 #elif defined(SH_ETH_TYPE_ETHER)
 	const u16 *reg_offset = sh_eth_offset_fast_sh4;
+#elif defined(SH_ETH_TYPE_RZ)
+	const u16 *reg_offset = sh_eth_offset_rz;
 #else
 #error
 #endif
-- 
1.8.5

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [U-Boot] [PATCH 2/3] net: sh-eth: Fix coding style
  2014-01-22 22:52 [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile Nobuhiro Iwamatsu
@ 2014-01-22 22:52 ` Nobuhiro Iwamatsu
  2014-06-06  2:44   ` Nobuhiro Iwamatsu
  2014-01-22 22:52 ` [U-Boot] [PATCH 3/3] net: sh-eth: Fix typo from rESR_RTLF to EESR_RTLF Nobuhiro Iwamatsu
  2014-06-06  2:44 ` [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile Nobuhiro Iwamatsu
  2 siblings, 1 reply; 11+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-01-22 22:52 UTC (permalink / raw)
  To: u-boot

This fixes checkpatch's warning.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
 drivers/net/sh_eth.c | 35 ++++++++++++++++++-----------------
 drivers/net/sh_eth.h |  9 ++++-----
 2 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
index 0cb963f..81e8ddb 100644
--- a/drivers/net/sh_eth.c
+++ b/drivers/net/sh_eth.c
@@ -67,7 +67,8 @@ int sh_eth_send(struct eth_device *dev, void *packet, int len)
 
 	/* packet must be a 4 byte boundary */
 	if ((int)packet & 3) {
-		printf(SHETHER_NAME ": %s: packet not 4 byte alligned\n", __func__);
+		printf(SHETHER_NAME ": %s: packet not 4 byte alligned\n"
+				, __func__);
 		ret = -EFAULT;
 		goto err;
 	}
@@ -156,7 +157,7 @@ static int sh_eth_reset(struct sh_eth_dev *eth)
 
 	/* Perform a software reset and wait for it to complete */
 	sh_eth_write(eth, EDMR_SRST, EDMR);
-	for (i = 0; i < TIMEOUT_CNT ; i++) {
+	for (i = 0; i < TIMEOUT_CNT; i++) {
 		if (!(sh_eth_read(eth, EDMR) & EDMR_SRST))
 			break;
 		udelay(1000);
@@ -523,41 +524,41 @@ void sh_eth_halt(struct eth_device *dev)
 
 int sh_eth_initialize(bd_t *bd)
 {
-    int ret = 0;
+	int ret = 0;
 	struct sh_eth_dev *eth = NULL;
-    struct eth_device *dev = NULL;
+	struct eth_device *dev = NULL;
 
-    eth = (struct sh_eth_dev *)malloc(sizeof(struct sh_eth_dev));
+	eth = (struct sh_eth_dev *)malloc(sizeof(struct sh_eth_dev));
 	if (!eth) {
 		printf(SHETHER_NAME ": %s: malloc failed\n", __func__);
 		ret = -ENOMEM;
 		goto err;
 	}
 
-    dev = (struct eth_device *)malloc(sizeof(struct eth_device));
+	dev = (struct eth_device *)malloc(sizeof(struct eth_device));
 	if (!dev) {
 		printf(SHETHER_NAME ": %s: malloc failed\n", __func__);
 		ret = -ENOMEM;
 		goto err;
 	}
-    memset(dev, 0, sizeof(struct eth_device));
-    memset(eth, 0, sizeof(struct sh_eth_dev));
+	memset(dev, 0, sizeof(struct eth_device));
+	memset(eth, 0, sizeof(struct sh_eth_dev));
 
 	eth->port = CONFIG_SH_ETHER_USE_PORT;
 	eth->port_info[eth->port].phy_addr = CONFIG_SH_ETHER_PHY_ADDR;
 
-    dev->priv = (void *)eth;
-    dev->iobase = 0;
-    dev->init = sh_eth_init;
-    dev->halt = sh_eth_halt;
-    dev->send = sh_eth_send;
-    dev->recv = sh_eth_recv;
-    eth->port_info[eth->port].dev = dev;
+	dev->priv = (void *)eth;
+	dev->iobase = 0;
+	dev->init = sh_eth_init;
+	dev->halt = sh_eth_halt;
+	dev->send = sh_eth_send;
+	dev->recv = sh_eth_recv;
+	eth->port_info[eth->port].dev = dev;
 
 	sprintf(dev->name, SHETHER_NAME);
 
-    /* Register Device to EtherNet subsystem  */
-    eth_register(dev);
+	/* Register Device to EtherNet subsystem  */
+	eth_register(dev);
 
 	bb_miiphy_buses[0].priv = eth;
 	miiphy_register(dev->name, bb_miiphy_read, bb_miiphy_write);
diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h
index 0925759..2909659 100644
--- a/drivers/net/sh_eth.h
+++ b/drivers/net/sh_eth.h
@@ -452,7 +452,6 @@ enum PHY_STATUS_BIT { PHY_ST_LINK = 0x01, };
 
 /* EESR */
 enum EESR_BIT {
-
 #if defined(SH_ETH_TYPE_ETHER)
 	EESR_TWB  = 0x40000000,
 #else
@@ -560,8 +559,8 @@ enum RECV_RST_BIT { RMCR_RST = 0x01, };
 /* ECMR */
 enum FELIC_MODE_BIT {
 #if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
-	ECMR_TRCCM=0x04000000, ECMR_RCSC= 0x00800000, ECMR_DPAD= 0x00200000,
-	ECMR_RZPF = 0x00100000,
+	ECMR_TRCCM = 0x04000000, ECMR_RCSC = 0x00800000,
+	ECMR_DPAD = 0x00200000, ECMR_RZPF = 0x00100000,
 #endif
 	ECMR_ZPF = 0x00080000, ECMR_PFR = 0x00040000, ECMR_RXF = 0x00020000,
 	ECMR_TXF = 0x00010000, ECMR_MCT = 0x00002000, ECMR_PRCEF = 0x00001000,
@@ -577,8 +576,8 @@ enum FELIC_MODE_BIT {
 };
 
 #if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
-#define ECMR_CHG_DM	(ECMR_TRCCM | ECMR_RZPF | ECMR_ZPF | ECMR_PFR | ECMR_RXF | \
-						ECMR_TXF | ECMR_MCT)
+#define ECMR_CHG_DM (ECMR_TRCCM | ECMR_RZPF | ECMR_ZPF | ECMR_PFR | \
+			ECMR_RXF | ECMR_TXF | ECMR_MCT)
 #elif defined(SH_ETH_TYPE_ETHER)
 #define ECMR_CHG_DM (ECMR_ZPF | ECMR_PFR | ECMR_RXF | ECMR_TXF)
 #else
-- 
1.8.5

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [U-Boot] [PATCH 3/3] net: sh-eth: Fix typo from rESR_RTLF to EESR_RTLF
  2014-01-22 22:52 [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile Nobuhiro Iwamatsu
  2014-01-22 22:52 ` [U-Boot] [PATCH 2/3] net: sh-eth: Fix coding style Nobuhiro Iwamatsu
@ 2014-01-22 22:52 ` Nobuhiro Iwamatsu
  2014-06-06  2:43   ` Nobuhiro Iwamatsu
  2014-06-06  2:44 ` [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile Nobuhiro Iwamatsu
  2 siblings, 1 reply; 11+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-01-22 22:52 UTC (permalink / raw)
  To: u-boot

'r' of rESR_RTLF is a mistake of E.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
 drivers/net/sh_eth.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h
index 2909659..d0d9aaa 100644
--- a/drivers/net/sh_eth.h
+++ b/drivers/net/sh_eth.h
@@ -476,7 +476,7 @@ enum EESR_BIT {
 	EESR_CD   = 0x00000200, EESR_RTO  = 0x00000100,
 	EESR_RMAF = 0x00000080, EESR_CEEF = 0x00000040,
 	EESR_CELF = 0x00000020, EESR_RRF  = 0x00000010,
-	rESR_RTLF = 0x00000008, EESR_RTSF = 0x00000004,
+	EESR_RTLF = 0x00000008, EESR_RTSF = 0x00000004,
 	EESR_PRE  = 0x00000002, EESR_CERF = 0x00000001,
 };
 
-- 
1.8.5

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [U-Boot] [PATCH 3/3] net: sh-eth: Fix typo from rESR_RTLF to EESR_RTLF
  2014-01-22 22:52 ` [U-Boot] [PATCH 3/3] net: sh-eth: Fix typo from rESR_RTLF to EESR_RTLF Nobuhiro Iwamatsu
@ 2014-06-06  2:43   ` Nobuhiro Iwamatsu
  0 siblings, 0 replies; 11+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-06-06  2:43 UTC (permalink / raw)
  To: u-boot

ping.

2014-01-23 7:52 GMT+09:00 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>:
> 'r' of rESR_RTLF is a mistake of E.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>  drivers/net/sh_eth.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h
> index 2909659..d0d9aaa 100644
> --- a/drivers/net/sh_eth.h
> +++ b/drivers/net/sh_eth.h
> @@ -476,7 +476,7 @@ enum EESR_BIT {
>         EESR_CD   = 0x00000200, EESR_RTO  = 0x00000100,
>         EESR_RMAF = 0x00000080, EESR_CEEF = 0x00000040,
>         EESR_CELF = 0x00000020, EESR_RRF  = 0x00000010,
> -       rESR_RTLF = 0x00000008, EESR_RTSF = 0x00000004,
> +       EESR_RTLF = 0x00000008, EESR_RTSF = 0x00000004,
>         EESR_PRE  = 0x00000002, EESR_CERF = 0x00000001,
>  };
>
> --
> 1.8.5
>



-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] [PATCH 2/3] net: sh-eth: Fix coding style
  2014-01-22 22:52 ` [U-Boot] [PATCH 2/3] net: sh-eth: Fix coding style Nobuhiro Iwamatsu
@ 2014-06-06  2:44   ` Nobuhiro Iwamatsu
  0 siblings, 0 replies; 11+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-06-06  2:44 UTC (permalink / raw)
  To: u-boot

ping.

2014-01-23 7:52 GMT+09:00 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>:
> This fixes checkpatch's warning.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>  drivers/net/sh_eth.c | 35 ++++++++++++++++++-----------------
>  drivers/net/sh_eth.h |  9 ++++-----
>  2 files changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
> index 0cb963f..81e8ddb 100644
> --- a/drivers/net/sh_eth.c
> +++ b/drivers/net/sh_eth.c
> @@ -67,7 +67,8 @@ int sh_eth_send(struct eth_device *dev, void *packet, int len)
>
>         /* packet must be a 4 byte boundary */
>         if ((int)packet & 3) {
> -               printf(SHETHER_NAME ": %s: packet not 4 byte alligned\n", __func__);
> +               printf(SHETHER_NAME ": %s: packet not 4 byte alligned\n"
> +                               , __func__);
>                 ret = -EFAULT;
>                 goto err;
>         }
> @@ -156,7 +157,7 @@ static int sh_eth_reset(struct sh_eth_dev *eth)
>
>         /* Perform a software reset and wait for it to complete */
>         sh_eth_write(eth, EDMR_SRST, EDMR);
> -       for (i = 0; i < TIMEOUT_CNT ; i++) {
> +       for (i = 0; i < TIMEOUT_CNT; i++) {
>                 if (!(sh_eth_read(eth, EDMR) & EDMR_SRST))
>                         break;
>                 udelay(1000);
> @@ -523,41 +524,41 @@ void sh_eth_halt(struct eth_device *dev)
>
>  int sh_eth_initialize(bd_t *bd)
>  {
> -    int ret = 0;
> +       int ret = 0;
>         struct sh_eth_dev *eth = NULL;
> -    struct eth_device *dev = NULL;
> +       struct eth_device *dev = NULL;
>
> -    eth = (struct sh_eth_dev *)malloc(sizeof(struct sh_eth_dev));
> +       eth = (struct sh_eth_dev *)malloc(sizeof(struct sh_eth_dev));
>         if (!eth) {
>                 printf(SHETHER_NAME ": %s: malloc failed\n", __func__);
>                 ret = -ENOMEM;
>                 goto err;
>         }
>
> -    dev = (struct eth_device *)malloc(sizeof(struct eth_device));
> +       dev = (struct eth_device *)malloc(sizeof(struct eth_device));
>         if (!dev) {
>                 printf(SHETHER_NAME ": %s: malloc failed\n", __func__);
>                 ret = -ENOMEM;
>                 goto err;
>         }
> -    memset(dev, 0, sizeof(struct eth_device));
> -    memset(eth, 0, sizeof(struct sh_eth_dev));
> +       memset(dev, 0, sizeof(struct eth_device));
> +       memset(eth, 0, sizeof(struct sh_eth_dev));
>
>         eth->port = CONFIG_SH_ETHER_USE_PORT;
>         eth->port_info[eth->port].phy_addr = CONFIG_SH_ETHER_PHY_ADDR;
>
> -    dev->priv = (void *)eth;
> -    dev->iobase = 0;
> -    dev->init = sh_eth_init;
> -    dev->halt = sh_eth_halt;
> -    dev->send = sh_eth_send;
> -    dev->recv = sh_eth_recv;
> -    eth->port_info[eth->port].dev = dev;
> +       dev->priv = (void *)eth;
> +       dev->iobase = 0;
> +       dev->init = sh_eth_init;
> +       dev->halt = sh_eth_halt;
> +       dev->send = sh_eth_send;
> +       dev->recv = sh_eth_recv;
> +       eth->port_info[eth->port].dev = dev;
>
>         sprintf(dev->name, SHETHER_NAME);
>
> -    /* Register Device to EtherNet subsystem  */
> -    eth_register(dev);
> +       /* Register Device to EtherNet subsystem  */
> +       eth_register(dev);
>
>         bb_miiphy_buses[0].priv = eth;
>         miiphy_register(dev->name, bb_miiphy_read, bb_miiphy_write);
> diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h
> index 0925759..2909659 100644
> --- a/drivers/net/sh_eth.h
> +++ b/drivers/net/sh_eth.h
> @@ -452,7 +452,6 @@ enum PHY_STATUS_BIT { PHY_ST_LINK = 0x01, };
>
>  /* EESR */
>  enum EESR_BIT {
> -
>  #if defined(SH_ETH_TYPE_ETHER)
>         EESR_TWB  = 0x40000000,
>  #else
> @@ -560,8 +559,8 @@ enum RECV_RST_BIT { RMCR_RST = 0x01, };
>  /* ECMR */
>  enum FELIC_MODE_BIT {
>  #if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
> -       ECMR_TRCCM=0x04000000, ECMR_RCSC= 0x00800000, ECMR_DPAD= 0x00200000,
> -       ECMR_RZPF = 0x00100000,
> +       ECMR_TRCCM = 0x04000000, ECMR_RCSC = 0x00800000,
> +       ECMR_DPAD = 0x00200000, ECMR_RZPF = 0x00100000,
>  #endif
>         ECMR_ZPF = 0x00080000, ECMR_PFR = 0x00040000, ECMR_RXF = 0x00020000,
>         ECMR_TXF = 0x00010000, ECMR_MCT = 0x00002000, ECMR_PRCEF = 0x00001000,
> @@ -577,8 +576,8 @@ enum FELIC_MODE_BIT {
>  };
>
>  #if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
> -#define ECMR_CHG_DM    (ECMR_TRCCM | ECMR_RZPF | ECMR_ZPF | ECMR_PFR | ECMR_RXF | \
> -                                               ECMR_TXF | ECMR_MCT)
> +#define ECMR_CHG_DM (ECMR_TRCCM | ECMR_RZPF | ECMR_ZPF | ECMR_PFR | \
> +                       ECMR_RXF | ECMR_TXF | ECMR_MCT)
>  #elif defined(SH_ETH_TYPE_ETHER)
>  #define ECMR_CHG_DM (ECMR_ZPF | ECMR_PFR | ECMR_RXF | ECMR_TXF)
>  #else
> --
> 1.8.5
>



-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile
  2014-01-22 22:52 [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile Nobuhiro Iwamatsu
  2014-01-22 22:52 ` [U-Boot] [PATCH 2/3] net: sh-eth: Fix coding style Nobuhiro Iwamatsu
  2014-01-22 22:52 ` [U-Boot] [PATCH 3/3] net: sh-eth: Fix typo from rESR_RTLF to EESR_RTLF Nobuhiro Iwamatsu
@ 2014-06-06  2:44 ` Nobuhiro Iwamatsu
  2014-06-06 13:37   ` Tom Rini
  2 siblings, 1 reply; 11+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-06-06  2:44 UTC (permalink / raw)
  To: u-boot

ping.

2014-01-23 7:52 GMT+09:00 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>:
> The R7S72100 of ARM SoC that Renesas manufactured has one Ether port.
> This has the same IP SH-Ether. This patch adds support of the R7S72100
> in SH-Ether.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>  drivers/net/sh_eth.c | 10 ++++---
>  drivers/net/sh_eth.h | 81 +++++++++++++++++++++++++++++++++++++++++++++-------
>  2 files changed, 77 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
> index 5e132f2..0cb963f 100644
> --- a/drivers/net/sh_eth.c
> +++ b/drivers/net/sh_eth.c
> @@ -148,7 +148,7 @@ int sh_eth_recv(struct eth_device *dev)
>
>  static int sh_eth_reset(struct sh_eth_dev *eth)
>  {
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>         int ret = 0, i;
>
>         /* Start e-dmac transmitter and receiver */
> @@ -218,7 +218,7 @@ static int sh_eth_tx_desc_init(struct sh_eth_dev *eth)
>         /* Point the controller to the tx descriptor list. Must use physical
>            addresses */
>         sh_eth_write(eth, ADDR_TO_PHY(port_info->tx_desc_base), TDLAR);
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>         sh_eth_write(eth, ADDR_TO_PHY(port_info->tx_desc_base), TDFAR);
>         sh_eth_write(eth, ADDR_TO_PHY(cur_tx_desc), TDFXR);
>         sh_eth_write(eth, 0x01, TDFFR);/* Last discriptor bit */
> @@ -288,7 +288,7 @@ static int sh_eth_rx_desc_init(struct sh_eth_dev *eth)
>
>         /* Point the controller to the rx descriptor list */
>         sh_eth_write(eth, ADDR_TO_PHY(port_info->rx_desc_base), RDLAR);
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>         sh_eth_write(eth, ADDR_TO_PHY(port_info->rx_desc_base), RDFAR);
>         sh_eth_write(eth, ADDR_TO_PHY(cur_rx_desc), RDFXR);
>         sh_eth_write(eth, RDFFR_RDLF, RDFFR);
> @@ -384,7 +384,7 @@ static int sh_eth_config(struct sh_eth_dev *eth, bd_t *bd)
>         sh_eth_write(eth, 0, TFTR);
>         sh_eth_write(eth, (FIFO_SIZE_T | FIFO_SIZE_R), FDR);
>         sh_eth_write(eth, RMCR_RST, RMCR);
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>         sh_eth_write(eth, 0, RPADIR);
>  #endif
>         sh_eth_write(eth, (FIFO_F_D_RFF | FIFO_F_D_RFD), FCFTR);
> @@ -403,6 +403,8 @@ static int sh_eth_config(struct sh_eth_dev *eth, bd_t *bd)
>         sh_eth_write(eth, RFLR_RFL_MIN, RFLR);
>  #if defined(SH_ETH_TYPE_GETHER)
>         sh_eth_write(eth, 0, PIPR);
> +#endif
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>         sh_eth_write(eth, APR_AP, APR);
>         sh_eth_write(eth, MPR_MP, MPR);
>         sh_eth_write(eth, TPAUSER_TPAUSE, TPAUSER);
> diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h
> index 331c07c..0925759 100644
> --- a/drivers/net/sh_eth.h
> +++ b/drivers/net/sh_eth.h
> @@ -230,6 +230,61 @@ static const u16 sh_eth_offset_gigabit[SH_ETH_MAX_REGISTER_OFFSET] = {
>         [RMII_MII] =  0x0790,
>  };
>
> +#if defined(SH_ETH_TYPE_RZ)
> +static const u16 sh_eth_offset_rz[SH_ETH_MAX_REGISTER_OFFSET] = {
> +       [EDSR]  = 0x0000,
> +       [EDMR]  = 0x0400,
> +       [EDTRR] = 0x0408,
> +       [EDRRR] = 0x0410,
> +       [EESR]  = 0x0428,
> +       [EESIPR]        = 0x0430,
> +       [TDLAR] = 0x0010,
> +       [TDFAR] = 0x0014,
> +       [TDFXR] = 0x0018,
> +       [TDFFR] = 0x001c,
> +       [RDLAR] = 0x0030,
> +       [RDFAR] = 0x0034,
> +       [RDFXR] = 0x0038,
> +       [RDFFR] = 0x003c,
> +       [TRSCER]        = 0x0438,
> +       [RMFCR] = 0x0440,
> +       [TFTR]  = 0x0448,
> +       [FDR]   = 0x0450,
> +       [RMCR]  = 0x0458,
> +       [RPADIR]        = 0x0460,
> +       [FCFTR] = 0x0468,
> +       [CSMR] = 0x04E4,
> +
> +       [ECMR]  = 0x0500,
> +       [ECSR]  = 0x0510,
> +       [ECSIPR]        = 0x0518,
> +       [PSR]   = 0x0528,
> +       [PIPR]  = 0x052c,
> +       [RFLR]  = 0x0508,
> +       [APR]   = 0x0554,
> +       [MPR]   = 0x0558,
> +       [PFTCR] = 0x055c,
> +       [PFRCR] = 0x0560,
> +       [TPAUSER]       = 0x0564,
> +       [GECMR] = 0x05b0,
> +       [BCULR] = 0x05b4,
> +       [MAHR]  = 0x05c0,
> +       [MALR]  = 0x05c8,
> +       [TROCR] = 0x0700,
> +       [CDCR]  = 0x0708,
> +       [LCCR]  = 0x0710,
> +       [CEFCR] = 0x0740,
> +       [FRECR] = 0x0748,
> +       [TSFRCR]        = 0x0750,
> +       [TLFRCR]        = 0x0758,
> +       [RFCR]  = 0x0760,
> +       [CERCR] = 0x0768,
> +       [CEECR] = 0x0770,
> +       [MAFCR] = 0x0778,
> +       [RMII_MII] =  0x0790,
> +};
> +#endif
> +
>  static const u16 sh_eth_offset_fast_sh4[SH_ETH_MAX_REGISTER_OFFSET] = {
>         [ECMR]  = 0x0100,
>         [RFLR]  = 0x0108,
> @@ -306,13 +361,16 @@ static const u16 sh_eth_offset_fast_sh4[SH_ETH_MAX_REGISTER_OFFSET] = {
>  #elif defined(CONFIG_R8A7790) || defined(CONFIG_R8A7791)
>  #define SH_ETH_TYPE_ETHER
>  #define BASE_IO_ADDR   0xEE700200
> +#elif defined(CONFIG_R7S72100)
> +#define SH_ETH_TYPE_RZ
> +#define BASE_IO_ADDR   0xE8203000
>  #endif
>
>  /*
>   * Register's bits
>   * Copy from Linux driver source code
>   */
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>  /* EDSR */
>  enum EDSR_BIT {
>         EDSR_ENT = 0x01, EDSR_ENR = 0x02,
> @@ -323,7 +381,7 @@ enum EDSR_BIT {
>  /* EDMR */
>  enum DMAC_M_BIT {
>         EDMR_DL1 = 0x20, EDMR_DL0 = 0x10,
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>         EDMR_SRST       = 0x03, /* Receive/Send reset */
>         EMDR_DESC_R     = 0x30, /* Descriptor reserve size */
>         EDMR_EL         = 0x40, /* Litte endian */
> @@ -349,7 +407,7 @@ enum DMAC_M_BIT {
>
>  /* EDTRR */
>  enum DMAC_T_BIT {
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>         EDTRR_TRNS = 0x03,
>  #else
>         EDTRR_TRNS = 0x01,
> @@ -424,7 +482,7 @@ enum EESR_BIT {
>  };
>
>
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>  # define TX_CHECK (EESR_TC1 | EESR_FTC)
>  # define EESR_ERR_CHECK        (EESR_TWB | EESR_TABT | EESR_RABT | EESR_RDE \
>                 | EESR_RFRMER | EESR_TFE | EESR_TDE | EESR_ECI)
> @@ -484,7 +542,8 @@ enum FCFTR_BIT {
>
>  /* Transfer descriptor bit */
>  enum TD_STS_BIT {
> -#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_ETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_ETHER) || \
> +       defined(SH_ETH_TYPE_RZ)
>         TD_TACT = 0x80000000,
>  #else
>         TD_TACT = 0x7fffffff,
> @@ -500,7 +559,7 @@ enum TD_STS_BIT {
>  enum RECV_RST_BIT { RMCR_RST = 0x01, };
>  /* ECMR */
>  enum FELIC_MODE_BIT {
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>         ECMR_TRCCM=0x04000000, ECMR_RCSC= 0x00800000, ECMR_DPAD= 0x00200000,
>         ECMR_RZPF = 0x00100000,
>  #endif
> @@ -517,7 +576,7 @@ enum FELIC_MODE_BIT {
>
>  };
>
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>  #define ECMR_CHG_DM    (ECMR_TRCCM | ECMR_RZPF | ECMR_ZPF | ECMR_PFR | ECMR_RXF | \
>                                                 ECMR_TXF | ECMR_MCT)
>  #elif defined(SH_ETH_TYPE_ETHER)
> @@ -535,7 +594,7 @@ enum ECSR_STATUS_BIT {
>         ECSR_MPD = 0x02, ECSR_ICD = 0x01,
>  };
>
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>  # define ECSR_INIT (ECSR_ICD | ECSIPR_MPDIP)
>  #else
>  # define ECSR_INIT (ECSR_BRCRX | ECSR_PSRTO | \
> @@ -556,7 +615,7 @@ enum ECSIPR_STATUS_MASK_BIT {
>         ECSIPR_ICDIP = 0x01,
>  };
>
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>  # define ECSIPR_INIT (ECSIPR_LCHNGIP | ECSIPR_ICDIP | ECSIPR_MPDIP)
>  #else
>  # define ECSIPR_INIT (ECSIPR_BRCRXIP | ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | \
> @@ -587,7 +646,7 @@ enum RPADIR_BIT {
>         RPADIR_PADR = 0x0003f,
>  };
>
> -#if defined(SH_ETH_TYPE_GETHER)
> +#if defined(SH_ETH_TYPE_GETHER) || defined(SH_ETH_TYPE_RZ)
>  # define RPADIR_INIT (0x00)
>  #else
>  # define RPADIR_INIT (RPADIR_PADS1)
> @@ -605,6 +664,8 @@ static inline unsigned long sh_eth_reg_addr(struct sh_eth_dev *eth,
>         const u16 *reg_offset = sh_eth_offset_gigabit;
>  #elif defined(SH_ETH_TYPE_ETHER)
>         const u16 *reg_offset = sh_eth_offset_fast_sh4;
> +#elif defined(SH_ETH_TYPE_RZ)
> +       const u16 *reg_offset = sh_eth_offset_rz;
>  #else
>  #error
>  #endif
> --
> 1.8.5
>



-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile
  2014-06-06  2:44 ` [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile Nobuhiro Iwamatsu
@ 2014-06-06 13:37   ` Tom Rini
  2014-06-08 21:58     ` Nobuhiro Iwamatsu
  0 siblings, 1 reply; 11+ messages in thread
From: Tom Rini @ 2014-06-06 13:37 UTC (permalink / raw)
  To: u-boot

On Fri, Jun 06, 2014 at 11:44:20AM +0900, Nobuhiro Iwamatsu wrote:

> ping.
> 
> 2014-01-23 7:52 GMT+09:00 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>:
> > The R7S72100 of ARM SoC that Renesas manufactured has one Ether port.
> > This has the same IP SH-Ether. This patch adds support of the R7S72100
> > in SH-Ether.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>

I'm fine with this series coming via the sh tree.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140606/e2b6a037/attachment.pgp>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile
  2014-06-06 13:37   ` Tom Rini
@ 2014-06-08 21:58     ` Nobuhiro Iwamatsu
  2014-06-11 15:42       ` Tom Rini
  0 siblings, 1 reply; 11+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-06-08 21:58 UTC (permalink / raw)
  To: u-boot

Hi, Tom.

2014-06-06 22:37 GMT+09:00 Tom Rini <trini@ti.com>:
> On Fri, Jun 06, 2014 at 11:44:20AM +0900, Nobuhiro Iwamatsu wrote:
>
>> ping.
>>
>> 2014-01-23 7:52 GMT+09:00 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>:
>> > The R7S72100 of ARM SoC that Renesas manufactured has one Ether port.
>> > This has the same IP SH-Ether. This patch adds support of the R7S72100
>> > in SH-Ether.
>> >
>> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>
> I'm fine with this series coming via the sh tree.
>
Thank you. I will work.
BTW, Joe(net custodian) does not have time of maintain net tree?
How do we patch for net from now ?

Best regards,
  Nobuhiro



-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile
  2014-06-08 21:58     ` Nobuhiro Iwamatsu
@ 2014-06-11 15:42       ` Tom Rini
  2014-06-12  0:30         ` Joe Hershberger
  0 siblings, 1 reply; 11+ messages in thread
From: Tom Rini @ 2014-06-11 15:42 UTC (permalink / raw)
  To: u-boot

On Mon, Jun 09, 2014 at 06:58:46AM +0900, Nobuhiro Iwamatsu wrote:
> Hi, Tom.
> 
> 2014-06-06 22:37 GMT+09:00 Tom Rini <trini@ti.com>:
> > On Fri, Jun 06, 2014 at 11:44:20AM +0900, Nobuhiro Iwamatsu wrote:
> >
> >> ping.
> >>
> >> 2014-01-23 7:52 GMT+09:00 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>:
> >> > The R7S72100 of ARM SoC that Renesas manufactured has one Ether port.
> >> > This has the same IP SH-Ether. This patch adds support of the R7S72100
> >> > in SH-Ether.
> >> >
> >> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> >
> > I'm fine with this series coming via the sh tree.
> >
> Thank you. I will work.
> BTW, Joe(net custodian) does not have time of maintain net tree?
> How do we patch for net from now ?

I don't want to put words in his mouth, but, at least for driver rather
than core changes (and this applies to more than just net), there's a
good deal of relevant experience outside of the custodians likely
background anyhow.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140611/4ba22818/attachment.pgp>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile
  2014-06-11 15:42       ` Tom Rini
@ 2014-06-12  0:30         ` Joe Hershberger
  2014-06-12  0:45           ` Nobuhiro Iwamatsu
  0 siblings, 1 reply; 11+ messages in thread
From: Joe Hershberger @ 2014-06-12  0:30 UTC (permalink / raw)
  To: u-boot

On Wed, Jun 11, 2014 at 10:42 AM, Tom Rini <trini@ti.com> wrote:
>
> On Mon, Jun 09, 2014 at 06:58:46AM +0900, Nobuhiro Iwamatsu wrote:
> > Hi, Tom.
> >
> > 2014-06-06 22:37 GMT+09:00 Tom Rini <trini@ti.com>:
> > > On Fri, Jun 06, 2014 at 11:44:20AM +0900, Nobuhiro Iwamatsu wrote:
> > >
> > >> ping.
> > >>
> > >> 2014-01-23 7:52 GMT+09:00 Nobuhiro Iwamatsu <
nobuhiro.iwamatsu.yj@renesas.com>:
> > >> > The R7S72100 of ARM SoC that Renesas manufactured has one Ether
port.
> > >> > This has the same IP SH-Ether. This patch adds support of the
R7S72100
> > >> > in SH-Ether.
> > >> >
> > >> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > >
> > > I'm fine with this series coming via the sh tree.
> > >
> > Thank you. I will work.
> > BTW, Joe(net custodian) does not have time of maintain net tree?
> > How do we patch for net from now ?
>
> I don't want to put words in his mouth, but, at least for driver rather
> than core changes (and this applies to more than just net), there's a
> good deal of relevant experience outside of the custodians likely
> background anyhow.

Agreed... for drivers running on boards that I don't have, I won't be able
to comment beyond how the driver interacts with the net stack.  I think it
can be appropriate to go through the board tree.

I'll be back to it fairly soon.

Cheers,
-Joe

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile
  2014-06-12  0:30         ` Joe Hershberger
@ 2014-06-12  0:45           ` Nobuhiro Iwamatsu
  0 siblings, 0 replies; 11+ messages in thread
From: Nobuhiro Iwamatsu @ 2014-06-12  0:45 UTC (permalink / raw)
  To: u-boot

Hi,

2014-06-12 9:30 GMT+09:00 Joe Hershberger <joe.hershberger@gmail.com>:
>
> On Wed, Jun 11, 2014 at 10:42 AM, Tom Rini <trini@ti.com> wrote:
>>
>> On Mon, Jun 09, 2014 at 06:58:46AM +0900, Nobuhiro Iwamatsu wrote:
>> > Hi, Tom.
>> >
>> > 2014-06-06 22:37 GMT+09:00 Tom Rini <trini@ti.com>:
>> > > On Fri, Jun 06, 2014 at 11:44:20AM +0900, Nobuhiro Iwamatsu wrote:
>> > >
>> > >> ping.
>> > >>
>> > >> 2014-01-23 7:52 GMT+09:00 Nobuhiro Iwamatsu
>> > >> <nobuhiro.iwamatsu.yj@renesas.com>:
>> > >> > The R7S72100 of ARM SoC that Renesas manufactured has one Ether
>> > >> > port.
>> > >> > This has the same IP SH-Ether. This patch adds support of the
>> > >> > R7S72100
>> > >> > in SH-Ether.
>> > >> >
>> > >> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> > >
>> > > I'm fine with this series coming via the sh tree.
>> > >
>> > Thank you. I will work.
>> > BTW, Joe(net custodian) does not have time of maintain net tree?
>> > How do we patch for net from now ?
>>
>> I don't want to put words in his mouth, but, at least for driver rather
>> than core changes (and this applies to more than just net), there's a
>> good deal of relevant experience outside of the custodians likely
>> background anyhow.
>
> Agreed... for drivers running on boards that I don't have, I won't be able
> to comment beyond how the driver interacts with the net stack.  I think it
> can be appropriate to go through the board tree.

I see. I was mistaken about the handling of the net tree.
Sorry about this.

>
> I'll be back to it fairly soon.

:)

>
> Cheers,
> -Joe

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2014-06-12  0:45 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-22 22:52 [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile Nobuhiro Iwamatsu
2014-01-22 22:52 ` [U-Boot] [PATCH 2/3] net: sh-eth: Fix coding style Nobuhiro Iwamatsu
2014-06-06  2:44   ` Nobuhiro Iwamatsu
2014-01-22 22:52 ` [U-Boot] [PATCH 3/3] net: sh-eth: Fix typo from rESR_RTLF to EESR_RTLF Nobuhiro Iwamatsu
2014-06-06  2:43   ` Nobuhiro Iwamatsu
2014-06-06  2:44 ` [U-Boot] [PATCH 1/3] net: sh-eth: Add support R7S72100 of rmobile Nobuhiro Iwamatsu
2014-06-06 13:37   ` Tom Rini
2014-06-08 21:58     ` Nobuhiro Iwamatsu
2014-06-11 15:42       ` Tom Rini
2014-06-12  0:30         ` Joe Hershberger
2014-06-12  0:45           ` Nobuhiro Iwamatsu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.