From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nobuhiro Iwamatsu Date: Tue, 8 Apr 2014 10:54:31 +0900 Subject: [U-Boot] [PATCH] lib: Add CONFIG_FDT_IGNORE_FIXUP_MEMORY_NODE In-Reply-To: <20140407174152.GI23803@bill-the-cat> References: <1396846600-15386-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> <20140407065339.499CC3804B4@gemini.denx.de> <20140407174152.GI23803@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, 2014-04-08 2:41 GMT+09:00 Tom Rini : > On Mon, Apr 07, 2014 at 08:53:39AM +0200, Wolfgang Denk wrote: >> Dear Nobuhiro Iwamatsu, >> >> In message <1396846600-15386-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> you wrote: >> > Usually, when CONFIG_OF_LIBFDT is enabled, U-Boot is set to >> > the FDT memory information that is set in the U-Boot. This patch >> > disables this behavior. >> > >> > Signed-off-by: Nobuhiro Iwamatsu >> > --- >> > README | 8 ++++++++ >> > arch/arm/lib/bootm-fdt.c | 2 ++ >> > 2 files changed, 10 insertions(+) >> >> Please explain why you would want to do this. To me it makes no >> sense. Either U-Boot knows the correct memory size, then it should >> pass it to Linux. Or it does not, then U-Boot should be fixed. >> >> Also, I object that your implementation is ARM specific. If such a >> feature gets added, it should be architecture independent. > > This has shown up before in the context of platforms with >4GB memory > and we "correct" the node by reducing the system memory, which is > incorrect. I agree this needs to be done for more than just ARM > however. It is one of the reasons of this patch that you wrote. Thanks, Nobuhiro > > -- > Tom > > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > -- Nobuhiro Iwamatsu