From: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
To: "Kim, Milo" <milo.kim@ti.com>
Cc: sre@kernel.org, linux-pm@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] power: supply: lp8788: prevent out of bounds array access
Date: Sat, 8 Apr 2017 13:55:24 +0300 [thread overview]
Message-ID: <CABNMmsBFUoY99JOB-qPR7Dbxn6tOU5ZRcnQc8LqctEW3P=HwUw@mail.gmail.com> (raw)
In-Reply-To: <84e9b377-30c6-d0f2-b869-6382d6c9f770@ti.com>
Ping.
On Tue, Mar 28, 2017 at 2:23 AM, Kim, Milo <milo.kim@ti.com> wrote:
> On 3/26/2017 1:00 AM, Giedrius Statkevičius wrote:
>>
>> val might become 7 in which case stime[7] (array of length 7) would be
>> accessed during the scnprintf call later and that will cause issues.
>> Obviously, string concatenation is not intended here so just a comma needs
>> to be added to fix the issue.
>>
>> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
>
>
> Acked-by: Milo Kim <milo.kim@ti.com>
>
>
>> ---
>> drivers/power/supply/lp8788-charger.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/supply/lp8788-charger.c
>> b/drivers/power/supply/lp8788-charger.c
>> index 509e2b341bd6..677f7c40b25a 100644
>> --- a/drivers/power/supply/lp8788-charger.c
>> +++ b/drivers/power/supply/lp8788-charger.c
>> @@ -651,7 +651,7 @@ static ssize_t lp8788_show_eoc_time(struct device
>> *dev,
>> {
>> struct lp8788_charger *pchg = dev_get_drvdata(dev);
>> char *stime[] = { "400ms", "5min", "10min", "15min",
>> - "20min", "25min", "30min" "No timeout" };
>> + "20min", "25min", "30min", "No timeout" };
>> u8 val;
>>
>> lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);
>>
>
next prev parent reply other threads:[~2017-04-08 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 16:00 [PATCH] power: supply: lp8788: prevent out of bounds array access Giedrius Statkevičius
2017-03-27 23:23 ` Kim, Milo
2017-03-27 23:23 ` Kim, Milo
2017-04-08 10:55 ` Giedrius Statkevičius [this message]
2017-04-11 14:18 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABNMmsBFUoY99JOB-qPR7Dbxn6tOU5ZRcnQc8LqctEW3P=HwUw@mail.gmail.com' \
--to=giedrius.statkevicius@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.