Re: git version 1.9.0 missing git-http-push? - Erik Faye-Lund

From: Erik Faye-Lund <kusmabite@gmail.com>
To: Dave Borowitz <dborowitz@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Marat Radchenko <marat@slonopotamus.org>,
	 msysGit <msysgit@googlegroups.com>,
	Pat Thoyts <patthoyts@gmail.com>,
	 Nick Hengeveld <nickh@reactrix.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: git version 1.9.0 missing git-http-push?
Date: Mon, 28 Apr 2014 21:02:19 +0200	[thread overview]
Message-ID: <CABPQNSaOVrUJVQcE8pyfohP4tgvD+bRPScw-igsFj08H3EoRWA@mail.gmail.com> (raw)
In-Reply-To: <CAD0k6qSUYANxbjjbE4jTW4EeVwOYgBD=bXkSu=akiYC_CB7Ffw@mail.gmail.com>

On Mon, Apr 28, 2014 at 8:39 PM, Dave Borowitz <dborowitz@google.com> wrote:
> On Mon, Apr 28, 2014 at 11:31 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Erik Faye-Lund <kusmabite@gmail.com> writes:
>>
>>> We're using Curl 7.30.0 in msysGit (and thus also Git for Windows), so
>>> we should be able to include it. However, we do not have curl-config
>>> installed.
>>
>> Hmmm, between 2.0-rc0 and 2.0-rc1 there is 61a64fff (Makefile: use
>> curl-config to determine curl flags, 2014-04-15) merged already,
>> which makes this assumption and a claim based on that assumption:
>>
>>     curl-config should always be installed alongside a curl
>>     distribution, and its purpose is to provide flags for building
>>     against libcurl, so use it instead of guessing flags and
>>     dependent libraries.
>>
>> which may make things worse for you guys, unless you are explicitly
>> setting CURLDIR and other Makefile variables.
>
> Yes, I can see that assumption may not always hold. But I'm slightly
> surprised this worked in the first place; are you saying this is a
> system where:
> -curl-config is not installed
> -but -lcurl still works
> -without setting CURLDIR
> ?

Yes, our cURL is installed globally together with the system libraries.

> I think I should probably re-roll the patch to default to the old
> behavior (blind -lcurl) if curl-config returns the empty string, which
> I believe is also the case when the binary is not found.

That sounds like it would work for MsysGit, yeah.

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.