Re: [PATCH v3 0/7] add/rm: honor sparse checkout and warn on sparse paths

[Elijah Newren <newren@gmail.com>]

On Fri, Mar 12, 2021 at 2:48 PM Matheus Tavares
<matheus.bernardino@usp.br> wrote:
>
> Make `rm` honor sparse checkouts, and make both `rm` and `add` warn
> when they are asked to update sparse entries.
>
> Main changes since v2:
>
> Patch 2:
> - Removed unnecessary `rm` in t3705's auxiliary function and added
>   comment about why `update-index --force-remove` is used there.
>
> Patch 4:
> - Replaced the boolean function parameter with a more descriptive enum.
>   This way, readers don't have to go to the function definition to
>   understand what the caller wants.
>
> Patches 5 and 6:
> - Reworded both commit messages and the advice.updateSparsePath docs to
>   avoid saying "pathspecs that *only* match sparse entries", as the
>   situations to which they refer might also include matches among
>   ignored paths.
> - Rephrased the warning message about sparse paths so that it doesn't
>   contradict the message on ignored paths when they are displayed
>   together.
>
> Patch 7:
> - Adjusted the tests to check for the new sparse warning message.

v2 already looked pretty good to me; even if I still had lots of
little comments on that series.  This version addresses all my
remaining concerns with v2.  So this gets my:

Reviewed-by: Elijah Newren <newren@gmail.com>


Thanks for all your work on this!