From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756336Ab3C1OYc (ORCPT ); Thu, 28 Mar 2013 10:24:32 -0400 Received: from mail-qe0-f51.google.com ([209.85.128.51]:58673 "EHLO mail-qe0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756103Ab3C1OYb (ORCPT ); Thu, 28 Mar 2013 10:24:31 -0400 MIME-Version: 1.0 In-Reply-To: <20130327165644.GB14744@infradead.org> References: <1359040242-8269-1-git-send-email-eranian@google.com> <1359040242-8269-12-git-send-email-eranian@google.com> <20130327141425.GC1092@krava.brq.redhat.com> <1364394014.5053.76.camel@laptop> <20130327143437.GE1092@krava.brq.redhat.com> <20130327165644.GB14744@infradead.org> Date: Thu, 28 Mar 2013 15:24:30 +0100 Message-ID: Subject: Re: [PATCH v7 11/18] perf tools: add mem access sampling core support From: Stephane Eranian To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Peter Zijlstra , LKML , Ingo Molnar , "ak@linux.intel.com" , Namhyung Kim Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnaldo, On Wed, Mar 27, 2013 at 5:56 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 27, 2013 at 03:48:15PM +0100, Stephane Eranian escreveu: >> On Wed, Mar 27, 2013 at 3:34 PM, Jiri Olsa wrote: >> > On Wed, Mar 27, 2013 at 03:20:14PM +0100, Peter Zijlstra wrote: >> > > On Wed, 2013-03-27 at 15:14 +0100, Jiri Olsa wrote: >> > > > we have correct cpumode for sample->ip, but I think it's the >> > > > PEBS->dla (sample->addr) where we need to guess.. right? > >> > > kernel mode very much fakes the cpumode/segment stuff for PEBS. PEBS >> > > assumes you're running in a linear/flat mode. > >> > say we hit the sample when kernel accesses the user data, we will endup >> > with IP in kernel space and DATA ptr in user space.. in theory ;-) > >> Yes, this is possible. So I think we could probably leaverage ip__resolve_ams() >> and pass the extra parameter for MAP_VARIABLE vs. MAP_FUNCTION. > > BTW, I fixed up the patches (kernel and user parts) and have them in > perf/mem at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux > > Hope to push it to Ingo today/tomorrow, after some more testing, thanks > Jiri for reviewing it. > > Stephane, if you could give it a try again to see that the fixups I did > (documented in the commit logs, just before my Signed-off-by) are ok, > that would be good. > I tried on a few examples on both NHM (only loads, no TLB) and SNB and got the right answers for my tests, including data symbol resolution. What we discussed with Jiri yesterday can be added later on. Thanks for the integration work. Looks good to me. > - Arnaldo > >> >> > >> > and that would need the cpumode guessing for DATA ptr, because >> > cpumode value is deduced from cs register >> > >> > jirka