From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754095Ab2GFBEd (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Jul 2012 21:04:33 -0400
Received: from mail-lb0-f174.google.com ([209.85.217.174]:45417 "EHLO
	mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752798Ab2GFBEb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Jul 2012 21:04:31 -0400
MIME-Version: 1.0
In-Reply-To: <20120705172654.GG32640@tassilo.jf.intel.com>
References: <1341254598-1379-3-git-send-email-andi@firstfloor.org>
	<1341256733.23484.11.camel@twins>
	<20120702195744.GG11413@one.firstfloor.org>
	<1341260540.23484.25.camel@twins>
	<20120702210008.GB14479@tassilo.jf.intel.com>
	<1341265014.23484.47.camel@twins>
	<20120702215722.GC14479@tassilo.jf.intel.com>
	<CABPqkBSdtV6FTqVestcmy_skyK5AFTeShoT6vDFk34A0XaXWDA@mail.gmail.com>
	<20120703040446.GJ11413@one.firstfloor.org>
	<CABPqkBT4Dgte73hM+im0VP-Px1rXXURcyHhsSA2RYXCTZSdOxg@mail.gmail.com>
	<20120705172654.GG32640@tassilo.jf.intel.com>
Date: Fri, 6 Jul 2012 03:04:29 +0200
Message-ID: <CABPqkBQS5gs7F41-Q4gUoURujst0RpJmn5iwUeUYjFUsFkhPBw@mail.gmail.com>
Subject: Re: [PATCH 2/5] perf, x86: Enable PDIR precise instruction profiling
 on IvyBridge
From: Stephane Eranian <eranian@google.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        Jiri Olsa <jolsa@redhat.com>
Content-Type: text/plain; charset=UTF-8
X-System-Of-Record: true
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 5, 2012 at 7:26 PM, Andi Kleen <ak@linux.intel.com> wrote:
> On Thu, Jul 05, 2012 at 05:45:16PM +0200, Stephane Eranian wrote:
>> On Tue, Jul 3, 2012 at 6:04 AM, Andi Kleen <andi@firstfloor.org> wrote:
>> >> Well, the only way I can think of would be to request that the
>> >> event be programmed with exclusive mode ALWAYS. That
>> >> should not be to hard to add.
>> >
>> > I suspect it would need some special callbacks from the events core,
>> > that's why I only tried on IvyBridge.
>> >x
>> You could simply add a check in the x86 init code like what is done
>> with the pebs events and precise mode.
>
> Ah requiring the user to set exclusive? Maybe. Right now perf does not even
> have an option to set it. Would seem user unfriendly to me though.

Yes, that's what I meant since the beginning. Require exclusive mode
on the event is all we need to enforce the restriction. The scheduling
would still only work on counter 1.

I know that perf record/stat do not support this but given the new event
parser it should not too hard to add an excl term to the syntax. I have
that in libpfm4 now as an option on events. That's clearly a perf_event
option like period or freq and not a HW option like inv, edge.