All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@google.com>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jiri Olsa <jolsa@kernel.org>,
	"ak@linux.intel.com" <ak@linux.intel.com>
Subject: Re: [PATCH 0/3]measure SMI cost
Date: Fri, 31 Mar 2017 14:51:15 -0700	[thread overview]
Message-ID: <CABPqkBR-kbbnzf26qfmqm2sSstd36LDGWFK6+=L-yL+u2iYYPQ@mail.gmail.com> (raw)
In-Reply-To: <1490293551-5552-1-git-send-email-kan.liang@intel.com>

On Thu, Mar 23, 2017 at 11:25 AM,  <kan.liang@intel.com> wrote:
> From: Kan Liang <Kan.liang@intel.com>
>
> Currently, there is no way to measure the time cost in System management
> mode (SMM) by perf.
>
> Intel perfmon supports FREEZE_WHILE_SMM bit in IA32_DEBUGCTL. Once it sets,
> the PMU core counters will freeze on SMI handler. But it will not have an
> effect on free running counters. E.g. APERF counter.
> The cost of SMI can be measured by (aperf - cycles).
>
> A new sysfs entry /sys/device/cpu/freeze_on_smi is introduced to set
> FREEZE_WHILE_SMM bit in IA32_DEBUGCTL.
>
> A new --smi-cost mode in perf stat is implemented to measure the SMI cost
> by calculating cycles and aperf results. In practice, the percentages of
> SMI cycles should be more useful than absolute value. So the output will be
> the percentage of SMI cycles and SMI#.
>
You are talking about the percentage of what cycles?
Wallclock, unhalted_ref_cycles, unhalted_core_cycles?
I
> Here is an example output.
>
>  Performance counter stats for 'sudo echo ':
>
> SMI cycles%          SMI#
>     0.1%              1
>
>        0.010858678 seconds time elapsed
>
>
> Kan Liang (3):
>   perf/x86: add sysfs entry to freeze counter on SMI
>   tools lib api fs: Add sysfs__write_int function
>   perf stat: Add support to measure SMI cost
>
>  arch/x86/events/core.c                 | 10 +++++++
>  arch/x86/events/intel/core.c           | 48 ++++++++++++++++++++++++++++++++++
>  arch/x86/events/perf_event.h           |  3 +++
>  arch/x86/include/asm/msr-index.h       |  1 +
>  tools/lib/api/fs/fs.c                  | 29 ++++++++++++++++++++
>  tools/lib/api/fs/fs.h                  |  4 +++
>  tools/perf/Documentation/perf-stat.txt |  9 +++++++
>  tools/perf/builtin-stat.c              | 48 ++++++++++++++++++++++++++++++++++
>  tools/perf/util/stat-shadow.c          | 33 +++++++++++++++++++++++
>  tools/perf/util/stat.c                 |  2 ++
>  tools/perf/util/stat.h                 |  2 ++
>  11 files changed, 189 insertions(+)
>
> --
> 2.7.4
>

  parent reply	other threads:[~2017-03-31 21:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 18:25 [PATCH 0/3]measure SMI cost kan.liang
2017-03-23 18:25 ` [PATCH 1/3] perf/x86: add sysfs entry to freeze counter on SMI kan.liang
2017-03-23 20:31   ` Peter Zijlstra
2017-03-23 20:48     ` Liang, Kan
2017-03-23 22:23     ` Andi Kleen
2017-03-24  8:16       ` Peter Zijlstra
2017-03-23 20:32   ` Peter Zijlstra
2017-03-24  8:31     ` Thomas Gleixner
2017-03-24 14:15       ` Liang, Kan
2017-03-24 14:23         ` Peter Zijlstra
2017-03-23 18:25 ` [PATCH 2/3] tools lib api fs: Add sysfs__write_int function kan.liang
2017-03-28  3:38   ` Elliott, Robert (Persistent Memory)
2017-03-23 18:25 ` [PATCH 3/3] perf stat: Add support to measure SMI cost kan.liang
2017-03-24  8:44 ` [PATCH 0/3]measure " Thomas Gleixner
2017-03-24 11:40   ` Andi Kleen
2017-03-24 12:07     ` Thomas Gleixner
2017-03-24 14:14       ` Liang, Kan
2017-03-31 21:51 ` Stephane Eranian [this message]
2017-04-01  1:41   ` Liang, Kan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABPqkBR-kbbnzf26qfmqm2sSstd36LDGWFK6+=L-yL+u2iYYPQ@mail.gmail.com' \
    --to=eranian@google.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.