From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751718AbcBOCQr (ORCPT <rfc822;w@1wt.eu>);
	Sun, 14 Feb 2016 21:16:47 -0500
Received: from mail-wm0-f42.google.com ([74.125.82.42]:33524 "EHLO
	mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751502AbcBOCQp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 14 Feb 2016 21:16:45 -0500
MIME-Version: 1.0
In-Reply-To: <20160212204310.GD16005@kernel.org>
References: <CABPqkBT2vGuUhCpchhUt13AxvacDDy2RiLgBfiEqnpK5Q9NLuQ@mail.gmail.com>
	<20160204215310.GB25196@kernel.org>
	<CABPqkBScZ4VkGN_uka7qbjPA_Yp511mp1TJyYuNGbbpyN8pXdQ@mail.gmail.com>
	<20160205134731.GC28242@kernel.org>
	<20160205135118.GD28242@kernel.org>
	<20160205135717.GE28242@kernel.org>
	<20160205142422.GF28242@kernel.org>
	<CABPqkBSQb_spiEBBS=21xobUNqp54=YHV9KKxOCXbA0bZGqFdg@mail.gmail.com>
	<20160211221622.GH32168@kernel.org>
	<CABPqkBT5vnTRU-V+6C6if=5xxnxC2ete1+RE1q+t+jxV64mFGQ@mail.gmail.com>
	<20160212204310.GD16005@kernel.org>
Date: Sun, 14 Feb 2016 18:16:44 -0800
Message-ID: <CABPqkBRPHOqhnOeVVxeUzCm0q_1VoFCBoRTm7D44TnCy1qrSCQ@mail.gmail.com>
Subject: Re: [PATCH v8 2/4] perf inject: add jitdump mmap injection support
From: Stephane Eranian <eranian@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>, Andi Kleen <andi@firstfloor.org>,
        Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
        Rose Belcher <cel@us.ibm.com>,
        Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
        Sonny Rao <sonnyrao@chromium.org>,
        John Mccutchan <johnmccutchan@google.com>,
        David Ahern <dsahern@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Pawel Moll <pawel.moll@arm.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 12, 2016 at 12:43 PM, Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Fri, Feb 12, 2016 at 12:32:53PM -0800, Stephane Eranian escreveu:
> > On Thu, Feb 11, 2016 at 2:16 PM, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > Em Mon, Feb 08, 2016 at 10:53:48AM -0800, Stephane Eranian escreveu:
> > >> > I.e. the MMAP records for the kernel modules comes in ok, humm, because
> > >> > probably you don't hook on PERF_RECORD_MMAP in perf-inject, just on MMAP2, and
> > >> > in those the only difference is the second field, 0x6b98 -> 0x42a0, what is
> > >> > that?
>
> > >> I have both MMAP and MMAP2 hooks for the jit mode of perf inject.
>
> > > IIRC the different in the offsets came from 'perf inject' not preserving
> > > FINISHED_ROUND events.
>
> > That's an oversight. Is there code to repipe this event already?
>
There is a callback for it already. But now, I remember Adrian
suggesting, to change
it to: perf_event__drop_oe(). In fact, if you look at builtin-inject.c
it has a comment about
this.

>
> right, we need to make it test and use what is available, here:
>
> [root@jouet ~]# dnf search alternatives
> Last metadata expiration check performed 1:01:59 ago on Fri Feb 12
> 16:38:51 2016.
> ================================================================= N/S
> Matched: alternatives
> ==================================================================
> galternatives.noarch : Alternatives Configurator
> ghc-base-unicode-symbols.x86_64 : Unicode alternatives for common
> functions and operators
> [root@jouet ~]# rpm -qf `which update-alternatives`
> chkconfig-1.7-1.fc23.x86_64
> [root@jouet ~]# rpm -ql chkconfig | grep alternativ
> /etc/alternatives
> /usr/sbin/alternatives
> /usr/sbin/update-alternatives
> /usr/share/man/man8/alternatives.8.gz
> /usr/share/man/man8/update-alternatives.8.gz
> /var/lib/alternatives


For me on Ubuntu:
$ dpkg -S /usr/sbin/update-java-alternatives
java-common: /usr/sbin/update-java-alternatives

Could you check on Fedora if you do not have that package or its equivalent?