All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@google.com>
To: Anton Blanchard <anton@ozlabs.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf jit: Fix build issue on Ubuntu
Date: Thu, 13 Oct 2016 00:41:05 -0700	[thread overview]
Message-ID: <CABPqkBRjzXtS8AA+XWu3wsY=pWhwG_4jd9W0vFEx-bvdSx=2NA@mail.gmail.com> (raw)
In-Reply-To: <1476325243-15788-1-git-send-email-anton@ozlabs.org>

On Wed, Oct 12, 2016 at 7:20 PM, Anton Blanchard <anton@ozlabs.org> wrote:
>
> From: Anton Blanchard <anton@samba.org>
>
> When building on Ubuntu 16.04, I get the following error:
>
> Makefile:49: *** the openjdk development package appears to me missing, install and try again.  Stop.
>
> The problem is that update-java-alternatives has multiple spaces between
> fields, and cut treats each space as a new delimiter:
>
> java-1.8.0-openjdk-ppc64el     1081       /usr/lib/jvm/java-1.8.0-openjdk-ppc64el
>
> Fix this by using awk, which handles this fine.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>

Works for me. Thanks.
Reviewed-by: Stephane Eranian <eranian@google.com>

>
> ---
>  tools/perf/jvmti/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/jvmti/Makefile b/tools/perf/jvmti/Makefile
> index 5ce61a1..df14e6b 100644
> --- a/tools/perf/jvmti/Makefile
> +++ b/tools/perf/jvmti/Makefile
> @@ -36,7 +36,7 @@ SOLIBEXT=so
>  # The following works at least on fedora 23, you may need the next
>  # line for other distros.
>  ifneq (,$(wildcard /usr/sbin/update-java-alternatives))
> -JDIR=$(shell /usr/sbin/update-java-alternatives -l | head -1 | cut -d ' ' -f 3)
> +JDIR=$(shell /usr/sbin/update-java-alternatives -l | head -1 | awk '{print $$3}')
>  else
>    ifneq (,$(wildcard /usr/sbin/alternatives))
>      JDIR=$(shell alternatives --display java | tail -1 | cut -d' ' -f 5 | sed 's%/jre/bin/java.%%g')
> --
> 2.7.4
>

  reply	other threads:[~2016-10-13  7:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13  2:20 [PATCH] perf jit: Fix build issue on Ubuntu Anton Blanchard
2016-10-13  7:41 ` Stephane Eranian [this message]
2016-10-17 14:53 ` [tip:perf/urgent] " tip-bot for Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABPqkBRjzXtS8AA+XWu3wsY=pWhwG_4jd9W0vFEx-bvdSx=2NA@mail.gmail.com' \
    --to=eranian@google.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=anton@ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.