From: Stephane Eranian <eranian@google.com>
To: Namhyung Kim <namhyung.kim@lge.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com,
peterz@infradead.org, mingo@elte.hu, dsahern@gmail.com,
penberg@kernel.org
Subject: Re: [PATCH] perf tools: fix NO_GTK2 Makefile config error
Date: Thu, 12 Apr 2012 10:55:48 +0200 [thread overview]
Message-ID: <CABPqkBS-MDUJBF6uBxT8heps6Kw=GYVsYHUL_oOWqB-AaiV+nw@mail.gmail.com> (raw)
In-Reply-To: <874nspeddl.fsf@sejong.aot.lge.com>
On Thu, Apr 12, 2012 at 7:19 AM, Namhyung Kim <namhyung.kim@lge.com> wrote:
> Hi, Stephane
>
> On Tue, 10 Apr 2012 12:35:13 +0200, Stephane Eranian wrote:
>> In case the user specified NO_GTK2 on the make cmdline,
>> compilation would fail with undefined symbol because the
>> Makefile would not set the correct cpp variable:
>> NO_GTK2 vs. NO_GTK2_SUPPORT.
>>
>> This patch renames the variable to the correct name.
>>
>
> I already sent a patch for this. Please see below:
>
> https://lkml.org/lkml/2012/4/11/459
>
Ok, I was not copied onto your post. And then the fix is buried with others
unrelated changes, it seems. But fine with me. It just needs to be committed
now.
> Thanks,
> Namhyung
next prev parent reply other threads:[~2012-04-12 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 10:35 [PATCH] perf tools: fix NO_GTK2 Makefile config error Stephane Eranian
2012-04-12 5:19 ` Namhyung Kim
2012-04-12 8:55 ` Stephane Eranian [this message]
2012-04-12 18:47 ` Arnaldo Carvalho de Melo
2012-04-15 8:35 ` [tip:perf/urgent] " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPqkBS-MDUJBF6uBxT8heps6Kw=GYVsYHUL_oOWqB-AaiV+nw@mail.gmail.com' \
--to=eranian@google.com \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.