All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf tools: fix NO_GTK2 Makefile config error
@ 2012-04-10 10:35 Stephane Eranian
  2012-04-12  5:19 ` Namhyung Kim
  2012-04-15  8:35 ` [tip:perf/urgent] " tip-bot for Stephane Eranian
  0 siblings, 2 replies; 5+ messages in thread
From: Stephane Eranian @ 2012-04-10 10:35 UTC (permalink / raw)
  To: linux-kernel; +Cc: acme, peterz, mingo, dsahern, penberg

In case the user specified NO_GTK2 on the make cmdline,
compilation would fail with undefined symbol because the
Makefile would not set the correct cpp variable:
NO_GTK2 vs. NO_GTK2_SUPPORT.

This patch renames the variable to the correct name.
    
Signed-off-by: Stephane Eranian <eranian@google.com>
---

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 820371f..a20d0c5 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -527,7 +527,7 @@ else
 endif
 
 ifdef NO_GTK2
-	BASIC_CFLAGS += -DNO_GTK2
+	BASIC_CFLAGS += -DNO_GTK2_SUPPORT
 else
 	FLAGS_GTK2=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) $(shell pkg-config --libs --cflags gtk+-2.0)
 	ifneq ($(call try-cc,$(SOURCE_GTK2),$(FLAGS_GTK2)),y)

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-04-15  8:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-10 10:35 [PATCH] perf tools: fix NO_GTK2 Makefile config error Stephane Eranian
2012-04-12  5:19 ` Namhyung Kim
2012-04-12  8:55   ` Stephane Eranian
2012-04-12 18:47     ` Arnaldo Carvalho de Melo
2012-04-15  8:35 ` [tip:perf/urgent] " tip-bot for Stephane Eranian

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.