From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754558AbbC0RAG (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 Mar 2015 13:00:06 -0400
Received: from mail-oi0-f45.google.com ([209.85.218.45]:35412 "EHLO
	mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754538AbbC0RAB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 Mar 2015 13:00:01 -0400
MIME-Version: 1.0
In-Reply-To: <20150327165739.GJ23123@twins.programming.kicks-ass.net>
References: <tip-34f439278cef7b1177f8ce24f9fc81dfc6221d3b@git.kernel.org>
	<CABPqkBTKYRU1uwhfWXhWKeqYmWCukXLrinvwtfC9xN4Fy=+2yg@mail.gmail.com>
	<20150327163547.GI23123@twins.programming.kicks-ass.net>
	<CABPqkBT-H8T40FcDZAWahMAajP4NBbMOVs9Awghh598xaoiz9Q@mail.gmail.com>
	<20150327165739.GJ23123@twins.programming.kicks-ass.net>
Date: Fri, 27 Mar 2015 10:00:00 -0700
Message-ID: <CABPqkBT085NLB1qVPy26E7PUcVTyb507nF5fBksJiFEKk69P-A@mail.gmail.com>
Subject: Re: [tip:perf/timer] perf: Add per event clockid support
From: Stephane Eranian <eranian@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        John Stultz <john.stultz@linaro.org>, "H. Peter Anvin" <hpa@zytor.com>,
        David Ahern <dsahern@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 27, 2015 at 9:57 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Mar 27, 2015 at 09:52:25AM -0700, Stephane Eranian wrote:
>> Ok, I see. But on architectures which do not have NMI, they would all
>> be safe. And that would work if they set the PERF_PMU_CAP_NO_NMI flag
>> on their pmu->capabilities.
>
> Indeed so. I have not audited them all as the current 'default' is safe.
>
>> Next, I am trying to understand how perf is going to expose this. I am
>> thinking about this in the context of my jitted code patches.
>
> I send you some preliminary patches for this.
>
>> With this approach, the jit runtime and the perf tool need to agree on
>> the clock they are using. That mean they need to advertise or document
>> the clock they use
>
> This is indeed still missing, I put an XXX question in one of the
> emails to this effect. I suppose we should store the used clockid in the
> data file. I just haven't figured out how all that code works.
>
>> and there needs to be an option in perf record to pass that same
>> clockid.
>
> I did indeed post a patch to do that.

I will switch my jitted patches to your approach to verify that this
actually works.
Thanks.