From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753698AbbC3Tn2 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Mar 2015 15:43:28 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:34012 "EHLO
	mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752752AbbC3Tn1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Mar 2015 15:43:27 -0400
MIME-Version: 1.0
In-Reply-To: <5519A6D8.9060806@gmail.com>
References: <tip-34f439278cef7b1177f8ce24f9fc81dfc6221d3b@git.kernel.org>
	<20150327143201.GG21418@twins.programming.kicks-ass.net>
	<55158F25.9040100@gmail.com>
	<20150327172059.GK23123@twins.programming.kicks-ass.net>
	<551594DD.7050705@gmail.com>
	<20150327201534.GD6291@redhat.com>
	<20150327215942.GL23123@twins.programming.kicks-ass.net>
	<CABPqkBR_ou8E01kRmDOBb72ngcdzBkfVPNUj71XWnsYE6i0Bdg@mail.gmail.com>
	<20150328075549.GG27490@worktop.programming.kicks-ass.net>
	<551986BC.3000409@gmail.com>
	<20150330193318.GF23123@twins.programming.kicks-ass.net>
	<5519A6D8.9060806@gmail.com>
Date: Mon, 30 Mar 2015 12:43:25 -0700
Message-ID: <CABPqkBT8eQM0WVcEqE-wKO06tVtYAF02Wn_r3eKs3j9vW53m8Q@mail.gmail.com>
Subject: Re: [PATCH] perf, record: Add clockid parameter
From: Stephane Eranian <eranian@google.com>
To: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Jiri Olsa <jolsa@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        John Stultz <john.stultz@linaro.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 30, 2015 at 12:41 PM, David Ahern <dsahern@gmail.com> wrote:
> On 3/30/15 1:33 PM, Peter Zijlstra wrote:
>>
>> On Mon, Mar 30, 2015 at 11:24:12AM -0600, David Ahern wrote:
>>>
>>> This works but the result is not always intuitive as to why it failed.
>>>
>>> On a kernel that does not support the clock id you get:
>>>      $ perf sched record -k mono -- sleep 1
>>>      Error:
>>>      clockid not supported.
>>>
>>> And on a kernel that supports clockid but not for NMI:
>>>
>>>      $ perf record -k realtime -a -- sleep 1
>>>      Error:
>>>      clockid not supported.
>>>
>>>      --> H/W counters so realtime is not allowed
>>>
>>> Same message though different root causes.
>>
>>
>> Heh, ok I can fudge that :-)
>>
>
> What about having the kernel return 'not supported' error for the latter --
> H/W counters with unsafe clock?

I have reassembled all the pieces from Peter's patch. I will post it
with V6 of the JIT patches today.