All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@google.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Jiri Olsa <jolsa@redhat.com>,
	mingo@elte.hu, Peter Zijlstra <peterz@infradead.org>
Subject: [RFC] perf record: dead code perf_event__synthesize_id_index()
Date: Wed, 02 May 2018 16:38:33 +0000	[thread overview]
Message-ID: <CABPqkBTm+9Wsa21GVXpogWUDNkpRF4eyZOPGa8QJCvdV2Lz2rA@mail.gmail.com> (raw)

Hi,

It looks like perf_event__synthesize_id_index() is dead code in the current
tip
tree. I don't see any invocation of the function anywhere in perf.I
understand why
you'd want to keep the rest of the code related to  PERF_RECORD_ID_INDEX
because some perf.data file may have this user-level record type. But the
synthesize code is not needed anymore, in my opinion.

Shouldn't we remove this code?

             reply	other threads:[~2018-05-02 16:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 16:38 Stephane Eranian [this message]
2018-05-02 16:57 ` [RFC] perf record: dead code perf_event__synthesize_id_index() Jiri Olsa
2018-05-03  6:15   ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABPqkBTm+9Wsa21GVXpogWUDNkpRF4eyZOPGa8QJCvdV2Lz2rA@mail.gmail.com \
    --to=eranian@google.com \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.