From: Krishna Chaitanya <chaitanya.mgit@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Chaitanya Tata <chaitanya.tata@bluwireless.com>
Subject: Re: [PATCHv2] cfg80211: Skip key deletion for open associations
Date: Tue, 26 Jan 2021 01:37:27 +0530 [thread overview]
Message-ID: <CABPxzYK7jPKbCokST-DMCyvoF_gqhWnBGZvUfgqZTfjeN-X2Ng@mail.gmail.com> (raw)
In-Reply-To: <2027106c42a27eb850217eaae928b7d36e345f4c.camel@sipsolutions.net>
On Tue, Jan 26, 2021 at 1:21 AM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Tue, 2021-01-26 at 00:50 +0530, chaitanya.mgit@gmail.com wrote:
> > From: Chaitanya Tata <chaitanya.mgit@gmail.com>
> >
> > From: Chaitanya Tata <chaitanya.mgit@gmail.com>
>
> That's broken, please check your git mail setup.
Fixed.
>
>
> > * Delete all the keys ... pairwise keys can't really
> > * exist any more anyway, but default keys might.
> > */
> > - if (rdev->ops->del_key) {
> > + if (wdev->connect_keys && rdev->ops->del_key) {
> >
>
> This is wrong, wdev->connect_keys is not needed to make a secure
> connection.
Ah, I guess it's only for the WEP, right? From a quick look, we are not saving
connect params (connect.crypto), will take a deeper look, thanks.
prev parent reply other threads:[~2021-01-25 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 19:20 [PATCHv2] cfg80211: Skip key deletion for open associations chaitanya.mgit
2021-01-25 19:51 ` Johannes Berg
2021-01-25 20:07 ` Krishna Chaitanya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPxzYK7jPKbCokST-DMCyvoF_gqhWnBGZvUfgqZTfjeN-X2Ng@mail.gmail.com \
--to=chaitanya.mgit@gmail.com \
--cc=chaitanya.tata@bluwireless.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.