From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754900AbbBFF1o (ORCPT ); Fri, 6 Feb 2015 00:27:44 -0500 Received: from mail-lb0-f178.google.com ([209.85.217.178]:56912 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbbBFF1n (ORCPT ); Fri, 6 Feb 2015 00:27:43 -0500 MIME-Version: 1.0 In-Reply-To: <1423030563-2090-1-git-send-email-zhouqiao@marvell.com> References: <1423030563-2090-1-git-send-email-zhouqiao@marvell.com> Date: Fri, 6 Feb 2015 13:27:41 +0800 Message-ID: Subject: Re: [PATCH] dma: mmp-pdma: fix irq handler overwrite physical chan issue From: Zhangfei Gao To: Qiao Zhou Cc: "Williams, Dan J" , Vinod Koul , "dmaengine@vger.kernel.org" , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4 February 2015 at 14:16, Qiao Zhou wrote: > Some dma channels may be reserved for other purpose in other layer, > like secure driver in EL2/EL3. PDMA driver can see the interrupt > status, but it should not try to handle related interrupt, since it > doesn't belong to PDMA driver in kernel. These interrupts should be > handled by corresponding client/module.Otherwise, it will overwrite > illegal memory and cause unexpected issues, since pdma driver only > requests resources for pdma channels. > > In PDMA driver, the reserved channels are at the end of total 32 > channels. If we find interrupt bit index is not smaller than total > dma channels, we should ignore it. > > Signed-off-by: Qiao Zhou Acked-by: Zhangfei Gao Thanks for the patch.