From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF9CC636D4 for ; Thu, 2 Feb 2023 18:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232295AbjBBSSV (ORCPT ); Thu, 2 Feb 2023 13:18:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232165AbjBBSSS (ORCPT ); Thu, 2 Feb 2023 13:18:18 -0500 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AA8045BD1 for ; Thu, 2 Feb 2023 10:18:17 -0800 (PST) Received: by mail-pf1-x42d.google.com with SMTP id cr11so1824000pfb.1 for ; Thu, 02 Feb 2023 10:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L7icPoQV0+1TADmGSuaIAYzPqVrS9LznmgHWsZ0YqHU=; b=S09i0i6E6NeqKHUKJRzq9SbeBUrkUks0KwsEdwlNV2s4XhoPD4a0u2/4V1ejKmAGt0 8Dv7PJHssfMBI3x/lspBaI8qh0S1VBhqDgwWhGl69EUkYqxYgWrTPwlVjqLtObkdJlVs 1hTyoMvRuvgNiXGPX8OSl2t0YL4nxh3CxxiI0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L7icPoQV0+1TADmGSuaIAYzPqVrS9LznmgHWsZ0YqHU=; b=Iufvd7bJ0kughfHESBdfO/Og5i7N25bDmjKbCcQ2Yx9vk53Gkc7IbYrxaalGebNroz UlTA9y6RblVO7J4wo98sXKR5xUe4u0NS6dPxq0Xt585Rom8exMJAkseB4zssgSBO4MNg 4J5axdu9JVz5bwzBUBui64DdqsedHBVsOWIXS6hEImGhFjZ9+k4jiAXgpbYraMBUZHdU bGY/JvoxYMWWV4rKcwx7IjkH7wIM0DQTcJ/UACbGBJoU9KvfXrsIsDkLD8U/gS3woJf1 c2px7gq/LnUumPjosCk5z02pfEEWlqkgwpfMyiiYHBZQxbnGGZQ4a+WR3W2sPcTwfAhf 0o8Q== X-Gm-Message-State: AO0yUKVvrZFvHn+NlaPVli9/Ofi8ooF03LzCNQPf0ac93YkxdWLWQJsc M9oaXvgzwS73CsZYv85eodbOgBHRKr+iY7KNFyYuBQ== X-Google-Smtp-Source: AK7set9q0tI/J6IQRKg4GVehPEW0rTa05ZubWhegS631JBzSLxYn4lgMk46uikvk3M9/sXKOpd4Gr5H00U0DKfR/vAI= X-Received: by 2002:a05:6a00:1a92:b0:593:e2fd:ca4f with SMTP id e18-20020a056a001a9200b00593e2fdca4fmr1703061pfv.0.1675361896917; Thu, 02 Feb 2023 10:18:16 -0800 (PST) MIME-Version: 1.0 References: <20230201163420.1579014-1-revest@chromium.org> <20230201163420.1579014-6-revest@chromium.org> In-Reply-To: From: Florent Revest Date: Thu, 2 Feb 2023 19:18:05 +0100 Message-ID: Subject: Re: [PATCH 5/8] ftrace: Make DIRECT_CALLS work WITH_ARGS and !WITH_REGS To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kpsingh@kernel.org, jolsa@kernel.org, xukuohai@huaweicloud.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 2, 2023 at 4:54 PM Mark Rutland wrote: > > On Wed, Feb 01, 2023 at 05:34:17PM +0100, Florent Revest wrote: > > Direct called trampolines can be called in two ways: > > - either from the ftrace callsite. In this case, they do not access any > > struct ftrace_regs nor pt_regs > > - Or, if a ftrace ops is also attached, from the end of a ftrace > > trampoline. In this case, the call_direct_funcs ops is in charge of > > setting the direct call trampoline's address in a struct ftrace_regs > > > > Since "ftrace: pass fregs to arch_ftrace_set_direct_caller()", the later > > case no longer requires a full pt_regs. > > Minor nit, but could we please have the commit ID, e.g. > > | Since commit: > | > | 9705bc70960459ae ("ftrace: pass fregs to arch_ftrace_set_direct_caller()") > | > | The latter case no longer requires a full pt_regs. Sure thing, will do! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B975EC61DA4 for ; Thu, 2 Feb 2023 18:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KSNFL96pKaXtdqLT6HG9nR0JP7VEINW3s+xyLndBlk0=; b=GrKSW9W5c71me2 FFK83SGXYm+I73/L6F1mMnkXNLETS/sCK6xLah0zKsi/AMbbP65y+WaA2EqtpppLc2DxYuwHk0nYN cDBCqvqskTMLqWwJ8GKqClyXSUcLtoq0eAG2hjOy+Vz6e5hD0ukIVShUJhvt1yxxIIvBYdONl18hw M0BhfnuGqb/oNwDtl3D2RMfZhJRIxz78FGym5sRKOY3XbPdW8dmKz4D/o6S6XHioKHR6vDsf/A81Y 9dVIaLfcubo+OC4XeHUyryug70PskpG6tcU9Caf02lBq77hbYoDCWNDOFZsEnEizeBZlrBRZCzSZn hWiaswD/zdy7xEqrPfQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNeAB-00GvR9-LS; Thu, 02 Feb 2023 18:18:23 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNeA8-00GvQ0-2o for linux-arm-kernel@lists.infradead.org; Thu, 02 Feb 2023 18:18:21 +0000 Received: by mail-pf1-x42a.google.com with SMTP id t17so1845305pfj.0 for ; Thu, 02 Feb 2023 10:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L7icPoQV0+1TADmGSuaIAYzPqVrS9LznmgHWsZ0YqHU=; b=S09i0i6E6NeqKHUKJRzq9SbeBUrkUks0KwsEdwlNV2s4XhoPD4a0u2/4V1ejKmAGt0 8Dv7PJHssfMBI3x/lspBaI8qh0S1VBhqDgwWhGl69EUkYqxYgWrTPwlVjqLtObkdJlVs 1hTyoMvRuvgNiXGPX8OSl2t0YL4nxh3CxxiI0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L7icPoQV0+1TADmGSuaIAYzPqVrS9LznmgHWsZ0YqHU=; b=7bVXafTZGq3SV1uCX/+m3ZnkiYSVoLM+XMF3jwMvvwjROu9u0KRJ5w9h4lrrE3iLlO bmnEYFH4fjl/XVP2kvxw6863bNve9SV8utZw4XzgCTYB1OhOfMlH2FltQkn+hF1HC471 e0QvLzJ4bgNHvBYBgjXcFdlBqBGGP0M+JTLVVmfzqDrBVnuNfFnj78tLvWu70PNCKIV7 R5RfbD05ZuQHULxxmneXQctAUj+3kyAfE6E3YeCjhlz1FZkjc0zzG+eSWAwjXT4uhVza m43s/bxSUFwVQT19a/j6KfMPbNxrG62AYyaZqffTZxJxcJy1sif2euO9ciu1aTH38LZU pQRg== X-Gm-Message-State: AO0yUKXHFYIlJuDJ5w7NqCI7c2SCllAaqGNXCLCvC5qEdtnewbLmHT/h 0NKCPD33YD+R+Lmi5EVBeNG7bEgShWDL2Wbp/AN+aw== X-Google-Smtp-Source: AK7set9q0tI/J6IQRKg4GVehPEW0rTa05ZubWhegS631JBzSLxYn4lgMk46uikvk3M9/sXKOpd4Gr5H00U0DKfR/vAI= X-Received: by 2002:a05:6a00:1a92:b0:593:e2fd:ca4f with SMTP id e18-20020a056a001a9200b00593e2fdca4fmr1703061pfv.0.1675361896917; Thu, 02 Feb 2023 10:18:16 -0800 (PST) MIME-Version: 1.0 References: <20230201163420.1579014-1-revest@chromium.org> <20230201163420.1579014-6-revest@chromium.org> In-Reply-To: From: Florent Revest Date: Thu, 2 Feb 2023 19:18:05 +0100 Message-ID: Subject: Re: [PATCH 5/8] ftrace: Make DIRECT_CALLS work WITH_ARGS and !WITH_REGS To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kpsingh@kernel.org, jolsa@kernel.org, xukuohai@huaweicloud.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_101820_159279_A80B818C X-CRM114-Status: GOOD ( 14.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 2, 2023 at 4:54 PM Mark Rutland wrote: > > On Wed, Feb 01, 2023 at 05:34:17PM +0100, Florent Revest wrote: > > Direct called trampolines can be called in two ways: > > - either from the ftrace callsite. In this case, they do not access any > > struct ftrace_regs nor pt_regs > > - Or, if a ftrace ops is also attached, from the end of a ftrace > > trampoline. In this case, the call_direct_funcs ops is in charge of > > setting the direct call trampoline's address in a struct ftrace_regs > > > > Since "ftrace: pass fregs to arch_ftrace_set_direct_caller()", the later > > case no longer requires a full pt_regs. > > Minor nit, but could we please have the commit ID, e.g. > > | Since commit: > | > | 9705bc70960459ae ("ftrace: pass fregs to arch_ftrace_set_direct_caller()") > | > | The latter case no longer requires a full pt_regs. Sure thing, will do! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel