From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9289C636D4 for ; Thu, 2 Feb 2023 17:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232196AbjBBRht (ORCPT ); Thu, 2 Feb 2023 12:37:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232166AbjBBRhq (ORCPT ); Thu, 2 Feb 2023 12:37:46 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCC8974A54 for ; Thu, 2 Feb 2023 09:37:44 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id f16-20020a17090a9b1000b0023058bbd7b2so1916213pjp.0 for ; Thu, 02 Feb 2023 09:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rT9lxIbE1aC6ouLgKeksCMpiSX53tsqaQ/chOF5F5DM=; b=SSF/D16aUlH8isttzJP7c9uokQeid1v6qga5ijrReEho6oTeTzHdpUI7qyx4TP2066 FQ2Rmy9my5puz88apP1nVfqXbh5do5wpLLHxHmR+fBkQEVMMeC+XQFfLiUSicdWT6W4j Kw+iGwKbVmwRADA09uBTkGY9vwEs4tO6uVmeo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rT9lxIbE1aC6ouLgKeksCMpiSX53tsqaQ/chOF5F5DM=; b=vdTPFQYqHKVf8Qu+gvNDt84kjTu9mDzZzft1JhNYEDU4jFlR+fWjC1veq9RZA3aZ/1 DXElFqhYwrxv8AKjW2tY4w2WaW44pBRXEPEeJ+yCqnTTYXvA3uWEMTKA3v7UMllkwUe+ cYrlHBXlJhFZLgWwjyn9BqrItSMTRznuBQU1T7w4OLkDmqwizZLlDlLvkk8L5aa+Ojfi At1SvoHGAkxjODwgJuspo1ZCzyfkHSic5YuS9/SPoqFAJgxW34EksRv0H1ojqDJEmVjc p19GeAe/E0sPZR1NX28hrWrNVdhYifnod+l4pFxrY+YoEcACVLsGGzuNRJ/Qn5YH6ysX 2eBw== X-Gm-Message-State: AO0yUKV3wGpSTdtzgV5yvvRLCp4HcX9gZCiZ2G/lvSis+MvqCQQygkOr yadprbdu9nKrCVKbBT8VUzhWObtzqbZcZZ68aIVevA== X-Google-Smtp-Source: AK7set9jJjaTtddAE+vHzmZXbvQK5j0dCjR1vmVsYlKwkrY2TfxhEwHqMc5gioQc/nHfy1zMGj/DjeOsLtSOifxfOuU= X-Received: by 2002:a17:90a:6c62:b0:22c:445b:d81 with SMTP id x89-20020a17090a6c6200b0022c445b0d81mr671030pjj.104.1675359464436; Thu, 02 Feb 2023 09:37:44 -0800 (PST) MIME-Version: 1.0 References: <20230201163420.1579014-1-revest@chromium.org> <20230201163420.1579014-2-revest@chromium.org> In-Reply-To: From: Florent Revest Date: Thu, 2 Feb 2023 18:37:33 +0100 Message-ID: Subject: Re: [PATCH 1/8] ftrace: Replace uses of _ftrace_direct APIs with _ftrace_direct_multi To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kpsingh@kernel.org, jolsa@kernel.org, xukuohai@huaweicloud.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 2, 2023 at 4:02 PM Mark Rutland wrote: > Looking at samples/ftrace/, as of this patch we have a few samples that are > almost identical, modulo the function being traced, and some different register > shuffling for arguments: > > * ftrace-direct.c and ftrace-direct-multi.c > * ftrace-direct-modify.c and ftrace-direct-modify > > ... perhaps it would be better to just delete the !multi versions ? The multi versions hook two functions and the !multi hook just one but I agree that this granularity in coverage is probably just a maintenance burden and doesn't help with much! :) I'll delete the !multi in v2, as part of the patch 2 and patch 1 will just migrate the selftest to use the multi API. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBB40C61DA4 for ; Thu, 2 Feb 2023 17:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f7BXr0k8+4q0J+nxrM2SfdrL0SZTyUWdKpjYjww8FAU=; b=S+8kjqVay9gOYD yG7Bza80CJmGRgDf+R4KdCt1ljqybAbeirNuC7IwpDizocgaYJKbZV6Irw4jMFpyEpoWLr4KGjLKu kQHK31TaS8TsD2UYTp3O+BCpUp/z1EEtcROfuLOvh0m+85OodTV8X3QnJtt3dFuvDxBvQvZGOomU5 3PcTjOCY0HMosMkWJDHusOyw59TcntPR4rI+awLUa9sgLk4q+hbCrtKgJIwyGGOF56oe5E0lnrJLK C0++ajVx3y2n4EsK1r6rk/m2RfVhcKmWXEXM1UuBfLGtIgPmWYJMmTZDQhV1AVQ0decrAceuGkdQ1 5QMMD6Oe8EBB2rH7pzdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNdWy-00Gq4e-1B; Thu, 02 Feb 2023 17:37:52 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNdWu-00Gq2A-Gp for linux-arm-kernel@lists.infradead.org; Thu, 02 Feb 2023 17:37:49 +0000 Received: by mail-pj1-x1036.google.com with SMTP id on9-20020a17090b1d0900b002300a96b358so2542659pjb.1 for ; Thu, 02 Feb 2023 09:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rT9lxIbE1aC6ouLgKeksCMpiSX53tsqaQ/chOF5F5DM=; b=SSF/D16aUlH8isttzJP7c9uokQeid1v6qga5ijrReEho6oTeTzHdpUI7qyx4TP2066 FQ2Rmy9my5puz88apP1nVfqXbh5do5wpLLHxHmR+fBkQEVMMeC+XQFfLiUSicdWT6W4j Kw+iGwKbVmwRADA09uBTkGY9vwEs4tO6uVmeo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rT9lxIbE1aC6ouLgKeksCMpiSX53tsqaQ/chOF5F5DM=; b=AMSKdSlWsTyNBrRuJd2qGx/14W/NLWRHQ4pPZT68mLvmlD7q//6FR0w/WaBGRWiwAc 9FGwnjpanAPtvayQ2krITRiBvzOResx3YVg/Pl1J58oLyH4kjykkrzobBDlxTOU+UwmR 1pd6EYNz4wYTyN8B/y8KbMMVM+3SF6jCSn+A5+c2pQqIwPCuT1+NFsQvRvBdoCXmvwIE T0d9z0lXNM2MbJhNTBrw73WnuP7A3FfohifA7ME9ZGH+ln0t/AEIeY2g0gc9BugCMjG3 Bb7IpOW1i34Yx1CAf1H4UbvuIn/QrFLK6qeWNVSZ3FO5n/UQzLOqjTo7Ztb+u80vBMgC zUhA== X-Gm-Message-State: AO0yUKVPpsNeZEFQlSh+aF6sYPoKaSdZOzY4d+FsX1ySSNxTWUEibfpq fPGjHaoKLSAhYFtr63DHPB6thnn75Gt9mIAP0K9NDA== X-Google-Smtp-Source: AK7set9jJjaTtddAE+vHzmZXbvQK5j0dCjR1vmVsYlKwkrY2TfxhEwHqMc5gioQc/nHfy1zMGj/DjeOsLtSOifxfOuU= X-Received: by 2002:a17:90a:6c62:b0:22c:445b:d81 with SMTP id x89-20020a17090a6c6200b0022c445b0d81mr671030pjj.104.1675359464436; Thu, 02 Feb 2023 09:37:44 -0800 (PST) MIME-Version: 1.0 References: <20230201163420.1579014-1-revest@chromium.org> <20230201163420.1579014-2-revest@chromium.org> In-Reply-To: From: Florent Revest Date: Thu, 2 Feb 2023 18:37:33 +0100 Message-ID: Subject: Re: [PATCH 1/8] ftrace: Replace uses of _ftrace_direct APIs with _ftrace_direct_multi To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kpsingh@kernel.org, jolsa@kernel.org, xukuohai@huaweicloud.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_093748_586104_6E66EAF1 X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 2, 2023 at 4:02 PM Mark Rutland wrote: > Looking at samples/ftrace/, as of this patch we have a few samples that are > almost identical, modulo the function being traced, and some different register > shuffling for arguments: > > * ftrace-direct.c and ftrace-direct-multi.c > * ftrace-direct-modify.c and ftrace-direct-modify > > ... perhaps it would be better to just delete the !multi versions ? The multi versions hook two functions and the !multi hook just one but I agree that this granularity in coverage is probably just a maintenance burden and doesn't help with much! :) I'll delete the !multi in v2, as part of the patch 2 and patch 1 will just migrate the selftest to use the multi API. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel