All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keno Fischer <keno@juliacomputing.com>
To: Greg Kurz <groug@kaod.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Keno Fischer <keno@alumni.harvard.edu>
Subject: Re: [Qemu-devel] [PATCH 08/13] 9p: darwin: Ignore O_{NOATIME, DIRECT}
Date: Thu, 31 May 2018 12:35:02 -0400	[thread overview]
Message-ID: <CABV8kRzWaLMx68bLF=r6XEHkys6QhgE8ovUgWqD4HBe0Tbh36g@mail.gmail.com> (raw)
In-Reply-To: <20180529233205.59770326@bahia.lan>

>
> Please don't kill the spaces.
>

Sorry, will undo. My editor has strong opinions about styling.

>> +#ifndef CONFIG_DARWIN
>> +        {P9_DOTL_NOATIME, O_NOATIME},
>> +        /* On Darwin, we could map to F_NOCACHE, which is
>> +           similar, but doesn't quite have the same
>> +           semantics. However, we don't support O_DIRECT
>
> But are these semantics worse than dumping the flag ?
>

I don't know. I looked around a bit and most OS abstraction
layers tend to not do this translation automatically:

https://github.com/libuv/libuv/issues/1600

>> +           even on linux at the moment, so we just ignore
>> +           it here. */
>
> Yeah, and I doubt we'll ever support it on linux either. But,
> anyway, why filter these out ? Do they cause a build break ?
>

Yes, neither O_DIRECT nor O_NOATIME are defined on Darwin,
so trying to use them causes errors.

  reply	other threads:[~2018-05-31 16:35 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-26  5:23 [Qemu-devel] [PATCH 00/13] 9p: Add support for Darwin keno
2018-05-26  5:23 ` [Qemu-devel] [PATCH 01/13] 9p: linux: Fix a couple Linux assumptions keno
2018-05-26  6:30   ` Philippe Mathieu-Daudé
2018-05-26 13:30     ` Peter Maydell
2018-05-26 16:17       ` Keno Fischer
2018-05-28 12:31   ` Greg Kurz
2018-05-26  5:23 ` [Qemu-devel] [PATCH 02/13] 9p: Avoid warning if FS_IOC_GETVERSION is not defined keno
2018-05-28 13:52   ` Greg Kurz
2018-05-26  5:23 ` [Qemu-devel] [PATCH 03/13] 9p: Move a couple xattr functions to 9p-util keno
2018-05-29 18:34   ` Greg Kurz
2018-05-31 16:14     ` Keno Fischer
2018-05-31 17:26       ` Greg Kurz
2018-05-31 17:39         ` Keno Fischer
2018-05-26  5:23 ` [Qemu-devel] [PATCH 04/13] 9p: darwin: Handle struct stat(fs) differences keno
2018-05-26  5:23 ` [Qemu-devel] [PATCH 05/13] 9p: darwin: Handle struct dirent differences keno
2018-05-29 20:25   ` Greg Kurz
2018-05-31 16:20     ` Keno Fischer
2018-05-31 19:16       ` Greg Kurz
2018-05-26  5:23 ` [Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences keno
2018-05-29 21:09   ` Greg Kurz
2018-05-31 16:27     ` Keno Fischer
2018-05-31 19:22       ` Greg Kurz
2018-05-31 19:23         ` Keno Fischer
2018-05-31 19:49           ` Greg Kurz
2018-05-26  5:23 ` [Qemu-devel] [PATCH 07/13] 9p: darwin: Properly translate AT_REMOVEDIR flag keno
2018-05-29 20:43   ` Greg Kurz
2018-05-31 16:25     ` Keno Fischer
2018-05-31 19:44       ` Greg Kurz
2018-05-26  5:23 ` [Qemu-devel] [PATCH 08/13] 9p: darwin: Ignore O_{NOATIME, DIRECT} keno
2018-05-29 21:32   ` Greg Kurz
2018-05-31 16:35     ` Keno Fischer [this message]
2018-05-26  5:23 ` [Qemu-devel] [PATCH 09/13] 9p: darwin: Provide a compatibility definition for XATTR_SIZE_MAX keno
2018-05-26 13:34   ` Peter Maydell
2018-05-26 16:00     ` Keno Fischer
2018-05-26  5:23 ` [Qemu-devel] [PATCH 10/13] 9p: darwin: *xattr_nofollow implementations keno
2018-05-30 12:13   ` Greg Kurz
2018-05-26  5:23 ` [Qemu-devel] [PATCH 11/13] 9p: darwin: Mark mknod as unsupported keno
2018-05-30 12:20   ` Greg Kurz
2018-05-31 16:37     ` Keno Fischer
2018-05-31 19:56       ` Greg Kurz
2018-05-31 22:56         ` Keno Fischer
2018-05-31 23:06           ` Keno Fischer
2018-05-31 23:21             ` Keno Fischer
2018-05-26  5:23 ` [Qemu-devel] [PATCH 12/13] 9p: darwin: Provide a fallback implementation for utimensat keno
2018-05-30 12:14   ` Greg Kurz
2018-05-26  5:23 ` [Qemu-devel] [PATCH 13/13] 9p: darwin: configure: Allow VirtFS on Darwin keno
2018-05-28 12:59   ` Greg Kurz
2018-05-31 17:46     ` Keno Fischer
2018-05-31 19:57       ` Greg Kurz
2018-05-26  5:37 ` [Qemu-devel] [PATCH 00/13] 9p: Add support for Darwin no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABV8kRzWaLMx68bLF=r6XEHkys6QhgE8ovUgWqD4HBe0Tbh36g@mail.gmail.com' \
    --to=keno@juliacomputing.com \
    --cc=groug@kaod.org \
    --cc=keno@alumni.harvard.edu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.