From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Avoid using dev_priv->info.gen directly. Date: Wed, 27 Sep 2017 12:32:02 -0700 Message-ID: References: <20170926211346.12009-1-rodrigo.vivi@intel.com> <1506460903.2634.12.camel@intel.com> <20170926214709.2fvs4fosv4g5d2xn@intel.com> <87d16c8vyv.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id A67A16E7DD for ; Wed, 27 Sep 2017 19:32:04 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id b195so22073620wmb.5 for ; Wed, 27 Sep 2017 12:32:04 -0700 (PDT) In-Reply-To: <87d16c8vyv.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Paulo Zanoni , intel-gfx , Hans de Goede , Rodrigo Vivi , Daniel Vetter , Lyude List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBTZXAgMjcsIDIwMTcgYXQgMTI6MDMgQU0sIEphbmkgTmlrdWxhCjxqYW5pLm5pa3Vs YUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+IE9uIFR1ZSwgMjYgU2VwIDIwMTcsIFJvZHJpZ28g Vml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4gd3JvdGU6Cj4+IE9uIFR1ZSwgU2VwIDI2LCAy MDE3IGF0IDA5OjIxOjQzUE0gKzAwMDAsIFBhdWxvIFphbm9uaSB3cm90ZToKPj4+IEVtIFRlciwg MjAxNy0wOS0yNiDDoHMgMTQ6MTMgLTA3MDAsIFJvZHJpZ28gVml2aSBlc2NyZXZldToKPj4+ID4g TGV0J3Mgc3RvcCB0aGlzIHVzYWdlIGJlZm9yZSBpdCBzcHJlYWRzIHNvIG11Y2guCj4+PiA+Cj4+ PiA+IDEuIFRoaXMgY2hlY2sgaXMgbm90IHBhcnQgb2YgdXN1YWwgc2VhcmNoZXMgaGFwcGVuaW5n IHdoZW4gYWRkaW5nCj4+PiA+IG5ldyBwbGF0Zm9ybS4KPj4+ID4gMi4gVGhlcmUgaXMgYWxyZWFk eSBhIGR1cGxpY2F0aW9uIGhlcmUgd2l0aCBJTlRFTF9JTkZPKGRldl9wcml2KS0+Z2VuCj4+PiA+ IGFuZCBJTlRFTF9HRU4oZGV2X3ByaXYpLgo+Pj4gPgo+Pj4gPiBTbyBsZXQncyBwbGVhc2UgYXZv aWQgeWV0IGFub3RoZXIgd2F5Lgo+Pj4gPgo+Pj4gPiBGaXhlczogYjIyY2E5OTViYTFjICgiZHJt L2k5MTU6IHByZXBhcmUgcGlwZSBmb3IgWUNCQ1I0MjAgb3V0cHV0IikKPj4+ID4gRml4ZXM6IDI3 MDgyNDkzZTljNiAoImRybS9pOTE1L3NrbDogVXBkYXRlIEREQiB2YWx1ZXMgYXRvbWljYWxseSB3 aXRoCj4+PiA+IHdtcy9wbGFuZSBhdHRycyIpCj4+Pgo+Pj4gTm90IHN1cmUgaWYgdGhlIEZpeGVz IHRhZ3MgYXJlIGFwcHJvcHJpYXRlIHNpbmNlIHRoaXMgaXMgbm90IGEgYnVnIGZpeC4KPj4KPj4g SSB3b25kZXJlZCB0aGF0Li4uIGJ1dCBzaW5jZSAiZGltIGZpeGVzIiBwcm92aWRlZCBtZSB0aGF0 IHRhZyBhbG9uZyB3aXRoIHRoZQo+PiBsaXN0IG9mIHBlb3BsZSBJIHNob3VsZCBjYyBJIGRlY2lk ZWQgdG8gaW5jbHVkZSBoZXJlLiBJIHRob3VnaHQgaXQKPj4gd291bGRuJ3QgaHVydCBhbmQgYWxz byBtYXliZSBnb29kIHRvIHByb3BhZ2F0ZSB0aGF0IHRvIGV2ZXJ5d2hlcmUgcG9zc2libGUgc28K Pj4gd2UgZG9uJ3QgcmVjaWV2ZSBtb3JlIGNvZGUgYmFzZWQgb24gdGhhdCB1c2FnZS4KPj4KPj4g QnV0IEkgd29uJ3QgbWVyZ2UgdG9kYXkgdG8gZ2l2ZSB0aW1lIHRvIGdldCBKYW5pJ3MgdmlldyBv biB0aGF0Lgo+Cj4gUGxlYXNlIG9ubHkgdXNlIEZpeGVzOiBmb3IgZnVuY3Rpb25hbCBmaXhlcyB0 aGF0IG5lZWQgdG8gYmUKPiBiYWNrcG9ydGVkLiBMaWtlLCBub2JvZHkncyBnb2luZyB0byBiZSBo YXBwaWVyIHJ1bm5pbmcgYSBrZXJuZWwgdGhleQo+IGtub3cgdXNlcyBJTlRFTF9HRU4oKSBjb25z aXN0ZW50bHkuCgpNYWtlcyBzZW5zZS4KTWVyZ2VkIHRvIGRpbnEgd2l0aG91dCB0aGUgIkZpeGVz OiIgdGFncy4KVGhhbmtzIGZvciBhbGwgY29tbWVudHMgYW5kIHJldmlld3MuCgo+Cj4gQlIsCj4g SmFuaS4KPgo+Cj4+Cj4+Pgo+Pj4gUmV2aWV3ZWQtYnk6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56 YW5vbmlAaW50ZWwuY29tPgo+Pj4KPj4+ID4gQ2M6IEx5dWRlIDxjcGF1bEByZWRoYXQuY29tPgo+ Pj4gPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pj4+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+Pj4gPiBD YzogUmFkaGFrcmlzaG5hIFNyaXBhZGEgPHJhZGhha3Jpc2huYS5zcmlwYWRhQGludGVsLmNvbT4K Pj4+ID4gQ2M6IEhhbnMgZGUgR29lZGUgPGhkZWdvZWRlQHJlZGhhdC5jb20+Cj4+PiA+IENjOiBN YXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+Pj4gPiBDYzogTWFhcnRlbiBM YW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4+ID4gQ2M6IFBh dWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+Pj4gPiBDYzogVmlsbGUgU3ly amFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4+PiA+IENjOiBJbXJlIERlYWsg PGltcmUuZGVha0BpbnRlbC5jb20+Cj4+PiA+IENjOiBTaGFzaGFuayBTaGFybWEgPHNoYXNoYW5r LnNoYXJtYUBpbnRlbC5jb20+Cj4+PiA+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGlu dXguaW50ZWwuY29tPgo+Pj4gPiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28u dml2aUBpbnRlbC5jb20+Cj4+PiA+IC0tLQo+Pj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jIHwgNiArKystLS0KPj4+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlv bnMoKyksIDMgZGVsZXRpb25zKC0pCj4+PiA+Cj4+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPj4+ID4gaW5kZXggNDg3YjQzYmEzMTM5Li5mYmE3NmYxYmI2ZGQgMTAw NjQ0Cj4+PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+Pj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4+ID4gQEAgLTkz MTAsMTEgKzkzMTAsMTEgQEAgc3RhdGljIGJvb2wgaGFzd2VsbF9nZXRfcGlwZV9jb25maWcoc3Ry dWN0Cj4+PiA+IGludGVsX2NydGMgKmNydGMsCj4+PiA+ICAgIHBpcGVfY29uZmlnLT5nYW1tYV9t b2RlID0KPj4+ID4gICAgICAgICAgICBJOTE1X1JFQUQoR0FNTUFfTU9ERShjcnRjLT5waXBlKSkg Jgo+Pj4gPiBHQU1NQV9NT0RFX01PREVfTUFTSzsKPj4+ID4KPj4+ID4gLSAgaWYgKElTX0JST0FE V0VMTChkZXZfcHJpdikgfHwgZGV2X3ByaXYtPmluZm8uZ2VuID49IDkpIHsKPj4+ID4gKyAgaWYg KElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwgSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KSB7Cj4+ PiA+ICAgICAgICAgICAgdTMyIHRtcCA9IEk5MTVfUkVBRChQSVBFTUlTQyhjcnRjLT5waXBlKSk7 Cj4+PiA+ICAgICAgICAgICAgYm9vbCBjbHJzcGFjZV95dXYgPSB0bXAgJgo+Pj4gPiBQSVBFTUlT Q19PVVRQVVRfQ09MT1JTUEFDRV9ZVVY7Cj4+PiA+Cj4+PiA+IC0gICAgICAgICAgaWYgKElTX0dF TUlOSUxBS0UoZGV2X3ByaXYpIHx8IGRldl9wcml2LT5pbmZvLmdlbiA+PQo+Pj4gPiAxMCkgewo+ Pj4gPiArICAgICAgICAgIGlmIChJU19HRU1JTklMQUtFKGRldl9wcml2KSB8fCBJTlRFTF9HRU4o ZGV2X3ByaXYpCj4+PiA+ID49IDEwKSB7Cj4+PiA+ICAgICAgICAgICAgICAgICAgICBib29sIGJs ZW5kX21vZGVfNDIwID0gdG1wICYKPj4+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBQSVBFTUlTQ19ZVVY0MjBfTU9ERV9GCj4+PiA+IFVMTF9CTEVORDsKPj4+ID4K Pj4+ID4gQEAgLTE0MjE3LDcgKzE0MjE3LDcgQEAgdm9pZCBpbnRlbF9pbml0X2Rpc3BsYXlfaG9v a3Moc3RydWN0Cj4+PiA+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+Pj4gPiAgICAgICAg ICAgIGRldl9wcml2LT5kaXNwbGF5LmZkaV9saW5rX3RyYWluID0KPj4+ID4gaHN3X2ZkaV9saW5r X3RyYWluOwo+Pj4gPiAgICB9Cj4+PiA+Cj4+PiA+IC0gIGlmIChkZXZfcHJpdi0+aW5mby5nZW4g Pj0gOSkKPj4+ID4gKyAgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOSkKPj4+ID4gICAgICAg ICAgICBkZXZfcHJpdi0+ZGlzcGxheS51cGRhdGVfY3J0Y3MgPSBza2xfdXBkYXRlX2NydGNzOwo+ Pj4gPiAgICBlbHNlCj4+PiA+ICAgICAgICAgICAgZGV2X3ByaXYtPmRpc3BsYXkudXBkYXRlX2Ny dGNzID0gaW50ZWxfdXBkYXRlX2NydGNzOwo+Cj4gLS0KPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3Bl biBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngKCgoKLS0gClJvZHJpZ28gVml2aQpCbG9nOiBodHRwOi8v YmxvZy52aXZpLmVuZy5icgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK