From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] Build: Add --disable-tests configure flag to avoid tests build. Date: Fri, 8 Feb 2013 09:48:35 -0200 Message-ID: References: <1360014747-7227-1-git-send-email-rodrigo.vivi@gmail.com> <20130207215232.GA27876@dyon.amr.corp.intel.com> <20130207223959.GA11819@lundgren.nims.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 85E98E5C84 for ; Fri, 8 Feb 2013 03:48:36 -0800 (PST) Received: by mail-vc0-f181.google.com with SMTP id d16so2274290vcd.40 for ; Fri, 08 Feb 2013 03:48:35 -0800 (PST) In-Reply-To: <20130207223959.GA11819@lundgren.nims.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org Apparently Cairo wasn't the main reason, beucase something at /libs depends on Cairo as well. So cairo dependencie wasn't removed from checks. But now on, when including any dependencies used only for tests please add pkg_check_modules only if tests build enalbed. On Thu, Feb 7, 2013 at 8:40 PM, Ben Widawsky wrote: > On Thu, Feb 07, 2013 at 09:52:32PM +0000, Damien Lespiau wrote: >> On Mon, Feb 04, 2013 at 07:52:27PM -0200, Rodrigo Vivi wrote: >> > Tests are still being built by default. However this request >> > came from OSVs in order to allow them to include i-g-t in their >> > distributions by default avoiding adding more and more dependencies >> > since we are improving and adding more and more tests. >> >> Sorry to be the party crasher here, but the patch doesn't seem to really >> remove dependencies because the default action-if-not-found of >> PKG_CHECK_MODULES will end the configure script. For instance >> >> PKG_CHECK_MODULES(CAIRO, [cairo]) >> >> will end the configure script if cairo is not found. >> >> What are the goals here? remove dependencies? which ones? >> >> Hopefully not too wrong with that stupid FOSDEM flu :) >> >> -- >> Damien > > Takashi asked for it, and reviewed it, so > http://en.wikipedia.org/wiki/Ostrich_algorithm? > > -- > Ben Widawsky, Intel Open Source Technology Center -- Rodrigo Vivi Blog: http://blog.vivi.eng.br