From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 33/89] drm/i915/skl: Sunrise Point PCH detection Date: Mon, 22 Sep 2014 12:34:52 -0700 Message-ID: References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com> <1409830075-11139-34-git-send-email-damien.lespiau@intel.com> <20140922134232.GI10951@strange.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0074698566==" Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 83DC26E4BB for ; Mon, 22 Sep 2014 12:34:53 -0700 (PDT) Received: by mail-wg0-f49.google.com with SMTP id x12so3243030wgg.8 for ; Mon, 22 Sep 2014 12:34:52 -0700 (PDT) In-Reply-To: <20140922134232.GI10951@strange.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org --===============0074698566== Content-Type: multipart/alternative; boundary=e89a8f6479e978a91a0503ac8bdb --e89a8f6479e978a91a0503ac8bdb Content-Type: text/plain; charset=UTF-8 Oh! ok, so let's not block the progress Thanks, so feel free to use: Reviewed-by: Rodrigo Vivi On Mon, Sep 22, 2014 at 6:42 AM, Damien Lespiau wrote: > On Wed, Sep 17, 2014 at 03:18:21PM -0700, Rodrigo Vivi wrote: > > Where can I find these pch device id definitions? > > You'll have to trust Satheesh on that, it's not something we have > documented in the GPU specs. > > -- > Damien > > > On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau < > damien.lespiau@intel.com> > > wrote: > > > > From: Satheeshakrishna M > > > > This patch implements detection of SPT and SPT-LP PCH devices. > > > > v2: Added HAS_PCH_SPT macro > > > > Signed-off-by: Satheeshakrishna M > > Signed-off-by: Damien Lespiau > > --- > > drivers/gpu/drm/i915/i915_drv.c | 10 ++++++++++ > > drivers/gpu/drm/i915/i915_drv.h | 4 ++++ > > 2 files changed, 14 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c > > b/drivers/gpu/drm/i915/i915_drv.c > > index 3d7f823..c6a8a80 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -475,6 +475,16 @@ void intel_detect_pch(struct drm_device *dev) > > DRM_DEBUG_KMS("Found LynxPoint LP > > PCH\n"); > > WARN_ON(!IS_HASWELL(dev)); > > WARN_ON(!IS_ULT(dev)); > > + } else if (id == > INTEL_PCH_SPT_DEVICE_ID_TYPE) { > > + dev_priv->pch_type = PCH_SPT; > > + DRM_DEBUG_KMS("Found SunrisePoint > > PCH\n"); > > + WARN_ON(!IS_SKYLAKE(dev)); > > + WARN_ON(IS_ULT(dev)); > > + } else if (id == > > INTEL_PCH_SPT_LP_DEVICE_ID_TYPE) { > > + dev_priv->pch_type = PCH_SPT; > > + DRM_DEBUG_KMS("Found SunrisePoint LP > > PCH\n"); > > + WARN_ON(!IS_SKYLAKE(dev)); > > + WARN_ON(!IS_ULT(dev)); > > } else > > continue; > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.h > > b/drivers/gpu/drm/i915/i915_drv.h > > index cf4fc86..be82888 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.h > > +++ b/drivers/gpu/drm/i915/i915_drv.h > > @@ -699,6 +699,7 @@ enum intel_pch { > > PCH_IBX, /* Ibexpeak PCH */ > > PCH_CPT, /* Cougarpoint PCH */ > > PCH_LPT, /* Lynxpoint PCH */ > > + PCH_SPT, /* Sunrisepoint PCH */ > > PCH_NOP, > > }; > > > > @@ -2184,8 +2185,11 @@ struct drm_i915_cmd_table { > > #define INTEL_PCH_PPT_DEVICE_ID_TYPE 0x1e00 > > #define INTEL_PCH_LPT_DEVICE_ID_TYPE 0x8c00 > > #define INTEL_PCH_LPT_LP_DEVICE_ID_TYPE 0x9c00 > > +#define INTEL_PCH_SPT_DEVICE_ID_TYPE 0xA100 > > +#define INTEL_PCH_SPT_LP_DEVICE_ID_TYPE 0x9D00 > > > > #define INTEL_PCH_TYPE(dev) (to_i915(dev)->pch_type) > > +#define HAS_PCH_SPT(dev) (INTEL_PCH_TYPE(dev) == PCH_SPT) > > #define HAS_PCH_LPT(dev) (INTEL_PCH_TYPE(dev) == PCH_LPT) > > #define HAS_PCH_CPT(dev) (INTEL_PCH_TYPE(dev) == PCH_CPT) > > #define HAS_PCH_IBX(dev) (INTEL_PCH_TYPE(dev) == PCH_IBX) > > -- > > 1.8.3.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > > Rodrigo Vivi > > Blog: http://blog.vivi.eng.br > > > -- Rodrigo Vivi Blog: http://blog.vivi.eng.br --e89a8f6479e978a91a0503ac8bdb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Oh! ok, so let's not block the progress

=
Thanks, so feel free to use:

Reviewed-by: Rodrigo V= ivi <rodrigo.vivi@intel.com>

On Mon, Sep 22, 2014 at 6:42 AM, Damien Lespiau <= ;damien.lespi= au@intel.com> wrote:
On Wed, Sep 17, 2014 at 03:18:21PM -0700, Rodrigo Vivi wrote: >=C2=A0 =C2=A0 Where can I find these pch device id definitions?

You'll have to trust Satheesh on that, it's not something we= have
documented in the GPU specs.

--
Damien

>=C2=A0 =C2=A0 On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau <damien.lespiau@intel.com>
>=C2=A0 =C2=A0 wrote:
>
>=C2=A0 =C2=A0 =C2=A0 From: Satheeshakrishna M <satheeshakrishna.m@intel.com>
>
>=C2=A0 =C2=A0 =C2=A0 This patch implements detection of SPT and SPT-LP = PCH devices.
>
>=C2=A0 =C2=A0 =C2=A0 v2: Added HAS_PCH_SPT macro
>
>=C2=A0 =C2=A0 =C2=A0 Signed-off-by: Satheeshakrishna M <satheeshakrishna.m@intel.com> >=C2=A0 =C2=A0 =C2=A0 Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>=C2=A0 =C2=A0 =C2=A0 ---
>=C2=A0 =C2=A0 =C2=A0 =C2=A0drivers/gpu/drm/i915/i915_drv.c | 10 +++++++= +++
>=C2=A0 =C2=A0 =C2=A0 =C2=A0drivers/gpu/drm/i915/i915_drv.h |=C2=A0 4 ++= ++
>=C2=A0 =C2=A0 =C2=A0 =C2=A02 files changed, 14 insertions(+)
>
>=C2=A0 =C2=A0 =C2=A0 diff --git a/drivers/gpu/drm/i915/i915_drv.c
>=C2=A0 =C2=A0 =C2=A0 b/drivers/gpu/drm/i915/i915_drv.c
>=C2=A0 =C2=A0 =C2=A0 index 3d7f823..c6a8a80 100644
>=C2=A0 =C2=A0 =C2=A0 --- a/drivers/gpu/drm/i915/i915_drv.c
>=C2=A0 =C2=A0 =C2=A0 +++ b/drivers/gpu/drm/i915/i915_drv.c
>=C2=A0 =C2=A0 =C2=A0 @@ -475,6 +475,16 @@ void intel_detect_pch(struct = drm_device *dev)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DRM_DEBUG_KM= S("Found LynxPoint LP
>=C2=A0 =C2=A0 =C2=A0 PCH\n");
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 WARN_ON(!IS_= HASWELL(dev));
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 WARN_ON(!IS_= ULT(dev));
>=C2=A0 =C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} else if (id =3D=3D INTEL_PCH_SPT_DEVICE= _ID_TYPE) {
>=C2=A0 =C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dev_priv->= pch_type =3D PCH_SPT;
>=C2=A0 =C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0DRM_DEBUG_KMS= ("Found SunrisePoint
>=C2=A0 =C2=A0 =C2=A0 PCH\n");
>=C2=A0 =C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0WARN_ON(!IS_S= KYLAKE(dev));
>=C2=A0 =C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0WARN_ON(IS_UL= T(dev));
>=C2=A0 =C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} else if (id =3D=3D
>=C2=A0 =C2=A0 =C2=A0 INTEL_PCH_SPT_LP_DEVICE_ID_TYPE) {
>=C2=A0 =C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dev_priv->= pch_type =3D PCH_SPT;
>=C2=A0 =C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0DRM_DEBUG_KMS= ("Found SunrisePoint LP
>=C2=A0 =C2=A0 =C2=A0 PCH\n");
>=C2=A0 =C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0WARN_ON(!IS_S= KYLAKE(dev));
>=C2=A0 =C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0WARN_ON(!IS_U= LT(dev));
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 continue; >
>=C2=A0 =C2=A0 =C2=A0 diff --git a/drivers/gpu/drm/i915/i915_drv.h
>=C2=A0 =C2=A0 =C2=A0 b/drivers/gpu/drm/i915/i915_drv.h
>=C2=A0 =C2=A0 =C2=A0 index cf4fc86..be82888 100644
>=C2=A0 =C2=A0 =C2=A0 --- a/drivers/gpu/drm/i915/i915_drv.h
>=C2=A0 =C2=A0 =C2=A0 +++ b/drivers/gpu/drm/i915/i915_drv.h
>=C2=A0 =C2=A0 =C2=A0 @@ -699,6 +699,7 @@ enum intel_pch {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 PCH_IBX,=C2=A0 =C2=A0 = =C2=A0 =C2=A0 /* Ibexpeak PCH */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 PCH_CPT,=C2=A0 =C2=A0 = =C2=A0 =C2=A0 /* Cougarpoint PCH */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 PCH_LPT,=C2=A0 =C2=A0 = =C2=A0 =C2=A0 /* Lynxpoint PCH */
>=C2=A0 =C2=A0 =C2=A0 +=C2=A0 =C2=A0 =C2=A0 =C2=A0PCH_SPT,=C2=A0 =C2=A0 = =C2=A0 =C2=A0 /* Sunrisepoint PCH */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 PCH_NOP,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0};
>
>=C2=A0 =C2=A0 =C2=A0 @@ -2184,8 +2185,11 @@ struct drm_i915_cmd_table {=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0#define INTEL_PCH_PPT_DEVICE_ID_TYPE=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A00x1e00
>=C2=A0 =C2=A0 =C2=A0 =C2=A0#define INTEL_PCH_LPT_DEVICE_ID_TYPE=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A00x8c00
>=C2=A0 =C2=A0 =C2=A0 =C2=A0#define INTEL_PCH_LPT_LP_DEVICE_ID_TYPE=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0x9c00
>=C2=A0 =C2=A0 =C2=A0 +#define INTEL_PCH_SPT_DEVICE_ID_TYPE=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A00xA100
>=C2=A0 =C2=A0 =C2=A0 +#define INTEL_PCH_SPT_LP_DEVICE_ID_TYPE=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0x9D00
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0#define INTEL_PCH_TYPE(dev) (to_i915(dev)-&g= t;pch_type)
>=C2=A0 =C2=A0 =C2=A0 +#define HAS_PCH_SPT(dev) (INTEL_PCH_TYPE(dev) =3D= =3D PCH_SPT)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0#define HAS_PCH_LPT(dev) (INTEL_PCH_TYPE(dev= ) =3D=3D PCH_LPT)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0#define HAS_PCH_CPT(dev) (INTEL_PCH_TYPE(dev= ) =3D=3D PCH_CPT)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0#define HAS_PCH_IBX(dev) (INTEL_PCH_TYPE(dev= ) =3D=3D PCH_IBX)
>=C2=A0 =C2=A0 =C2=A0 --
>=C2=A0 =C2=A0 =C2=A0 1.8.3.1
>
>=C2=A0 =C2=A0 =C2=A0 _______________________________________________ >=C2=A0 =C2=A0 =C2=A0 Intel-gfx mailing list
>=C2=A0 =C2=A0 =C2=A0 Intel-gfx@lists.freedesktop.org
>=C2=A0 =C2=A0 =C2=A0 http://lists.freedesktop.org/mailman/li= stinfo/intel-gfx
>
>=C2=A0 =C2=A0 --
>=C2=A0 =C2=A0 Rodrigo Vivi
>=C2=A0 =C2=A0 Blog: http://blog.vivi.eng.br
>



--
=
Rodrigo Vivi
=C2=A0
--e89a8f6479e978a91a0503ac8bdb-- --===============0074698566== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0074698566==--