From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Add functions to force psr exit Date: Fri, 28 Jun 2013 15:05:49 -0300 Message-ID: References: <1372338222-30460-1-git-send-email-rodrigo.vivi@gmail.com> <1372441930-18280-1-git-send-email-rodrigo.vivi@gmail.com> <20130628175736.GE32183@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-vc0-f170.google.com (mail-vc0-f170.google.com [209.85.220.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CEF9E653D for ; Fri, 28 Jun 2013 11:05:50 -0700 (PDT) Received: by mail-vc0-f170.google.com with SMTP id hf12so925813vcb.29 for ; Fri, 28 Jun 2013 11:05:49 -0700 (PDT) In-Reply-To: <20130628175736.GE32183@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Rodrigo Vivi , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Fri, Jun 28, 2013 at 2:57 PM, Chris Wilson wrote: > On Fri, Jun 28, 2013 at 02:52:10PM -0300, Rodrigo Vivi wrote: >> PSR tracking engine in HSW doesn't detect automagically some directly copy area >> operations through scanout so we will have to kick it manually and >> reschedule it to come back to normal operation as soon as possible. > > Does force_exit correspond with any names/actions in the documentation? > If not, care to consider intel_edp_psr_wakeup() as a less confusing name? Yes, it correspond to name of setting 11 to bits 31:30 of 0x64860. Besides to be honest wakeup confuses me more. It seems ambiguous, I mean wake up from srd state (force exit) or wake up psr functionality (normal)? > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre -- Rodrigo Vivi Blog: http://blog.vivi.eng.br