From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Subject: Re: [PATCH 27/89] drm/i915/skl: SKL shares the same
 underrun interrupt as BDW
Date: Tue, 16 Sep 2014 18:39:34 -0700
Message-ID: <CABVU7+uspGchqJPGAcF3-SwhikVHjazC2KVNmc_oB9-8-MWf1Q@mail.gmail.com>
References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com>
 <1409830075-11139-28-git-send-email-damien.lespiau@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1117338724=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
 [74.125.82.181])
 by gabe.freedesktop.org (Postfix) with ESMTP id 0AB1D6E0FB
 for <intel-gfx@lists.freedesktop.org>; Tue, 16 Sep 2014 18:39:34 -0700 (PDT)
Received: by mail-we0-f181.google.com with SMTP id w62so654950wes.26
 for <intel-gfx@lists.freedesktop.org>; Tue, 16 Sep 2014 18:39:34 -0700 (PDT)
In-Reply-To: <1409830075-11139-28-git-send-email-damien.lespiau@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

--===============1117338724==
Content-Type: multipart/alternative; boundary=089e01228f16a69fc1050338f0d6

--089e01228f16a69fc1050338f0d6
Content-Type: text/plain; charset=UTF-8

the rest of DE_PIPE_INTERRUPT definition is different from BDW to SKL but
the underrun is indeed the same!

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau <damien.lespiau@intel.com>
wrote:

> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c
> b/drivers/gpu/drm/i915/i915_irq.c
> index e9979f5..c62a2e4 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -503,7 +503,7 @@ static bool
> __intel_set_cpu_fifo_underrun_reporting(struct drm_device *dev,
>                 ironlake_set_fifo_underrun_reporting(dev, pipe, enable);
>         else if (IS_GEN7(dev))
>                 ivybridge_set_fifo_underrun_reporting(dev, pipe, enable,
> old);
> -       else if (IS_GEN8(dev))
> +       else if (IS_GEN8(dev) || IS_GEN9(dev))
>                 broadwell_set_fifo_underrun_reporting(dev, pipe, enable);
>
>         return old;
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

--089e01228f16a69fc1050338f0d6
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">the rest of DE_PIPE_INTERRUPT definition is different from=
 BDW to SKL but the underrun is indeed the same!<div><br></div><div>Reviewe=
d-by: Rodrigo Vivi &lt;<a href=3D"mailto:rodrigo.vivi@intel.com">rodrigo.vi=
vi@intel.com</a>&gt;</div></div><div class=3D"gmail_extra"><br><div class=
=3D"gmail_quote">On Thu, Sep 4, 2014 at 4:26 AM, Damien Lespiau <span dir=
=3D"ltr">&lt;<a href=3D"mailto:damien.lespiau@intel.com" target=3D"_blank">=
damien.lespiau@intel.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmai=
l_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left=
:1ex">Signed-off-by: Damien Lespiau &lt;<a href=3D"mailto:damien.lespiau@in=
tel.com">damien.lespiau@intel.com</a>&gt;<br>
---<br>
=C2=A0drivers/gpu/drm/i915/i915_irq.c | 2 +-<br>
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_ir=
q.c<br>
index e9979f5..c62a2e4 100644<br>
--- a/drivers/gpu/drm/i915/i915_irq.c<br>
+++ b/drivers/gpu/drm/i915/i915_irq.c<br>
@@ -503,7 +503,7 @@ static bool __intel_set_cpu_fifo_underrun_reporting(str=
uct drm_device *dev,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ironlake_set_fifo_u=
nderrun_reporting(dev, pipe, enable);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 else if (IS_GEN7(dev))<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ivybridge_set_fifo_=
underrun_reporting(dev, pipe, enable, old);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0else if (IS_GEN8(dev))<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0else if (IS_GEN8(dev) || IS_GEN9(dev))<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 broadwell_set_fifo_=
underrun_reporting(dev, pipe, enable);<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 return old;<br>
<span class=3D"HOEnZb"><font color=3D"#888888">--<br>
1.8.3.1<br>
<br>
_______________________________________________<br>
Intel-gfx mailing list<br>
<a href=3D"mailto:Intel-gfx@lists.freedesktop.org">Intel-gfx@lists.freedesk=
top.org</a><br>
<a href=3D"http://lists.freedesktop.org/mailman/listinfo/intel-gfx" target=
=3D"_blank">http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br>
</font></span></blockquote></div><br><br clear=3D"all"><div><br></div>-- <b=
r><div>Rodrigo Vivi</div><div>Blog: <a href=3D"http://blog.vivi.eng.br" tar=
get=3D"_blank">http://blog.vivi.eng.br</a></div><div>=C2=A0</div>
</div>

--089e01228f16a69fc1050338f0d6--

--===============1117338724==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1117338724==--