From: Rodrigo Vivi <rodrigo.vivi@gmail.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2 01/25] drm/i915: vlv: clean up GTLC wake control/status register macros
Date: Thu, 24 Apr 2014 18:04:53 -0300 [thread overview]
Message-ID: <CABVU7+v5jHoKhMQsP=zfm__0mNuE4Ep9iyviM7nRZjf74Z+Twg@mail.gmail.com> (raw)
In-Reply-To: <1397496286-29649-2-git-send-email-imre.deak@intel.com>
Apparently Ville already Reviewed this one, but since I was checking
the doc and it was right feel free to also use: Reviewed-by: Rodrigo
Vivi <rodrigo.vivi@gmail.com>
same for next 2 patches.
On Mon, Apr 14, 2014 at 2:24 PM, Imre Deak <imre.deak@intel.com> wrote:
> These will be needed by the upcoming VLV RPM helpers.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 5 +++--
> drivers/gpu/drm/i915/i915_reg.h | 10 ++++++++--
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 8f5ffab..af8493a 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -4459,8 +4459,9 @@ int i915_gem_init(struct drm_device *dev)
>
> if (IS_VALLEYVIEW(dev)) {
> /* VLVA0 (potential hack), BIOS isn't actually waking us */
> - I915_WRITE(VLV_GTLC_WAKE_CTRL, 1);
> - if (wait_for((I915_READ(VLV_GTLC_PW_STATUS) & 1) == 1, 10))
> + I915_WRITE(VLV_GTLC_WAKE_CTRL, VLV_GTLC_ALLOWWAKEREQ);
> + if (wait_for((I915_READ(VLV_GTLC_PW_STATUS) &
> + VLV_GTLC_ALLOWWAKEACK), 10))
> DRM_DEBUG_DRIVER("allow wake ack timed out\n");
> }
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 8f84555..ee768f0 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -4996,9 +4996,15 @@ enum punit_power_well {
> #define FORCEWAKE_ACK_HSW 0x130044
> #define FORCEWAKE_ACK 0x130090
> #define VLV_GTLC_WAKE_CTRL 0x130090
> +#define VLV_GTLC_RENDER_CTX_EXISTS (1 << 25)
> +#define VLV_GTLC_MEDIA_CTX_EXISTS (1 << 24)
> +#define VLV_GTLC_ALLOWWAKEREQ (1 << 0)
> +
> #define VLV_GTLC_PW_STATUS 0x130094
> -#define VLV_GTLC_PW_RENDER_STATUS_MASK 0x80
> -#define VLV_GTLC_PW_MEDIA_STATUS_MASK 0x20
> +#define VLV_GTLC_ALLOWWAKEACK (1 << 0)
> +#define VLV_GTLC_ALLOWWAKEERR (1 << 1)
> +#define VLV_GTLC_PW_MEDIA_STATUS_MASK (1 << 5)
> +#define VLV_GTLC_PW_RENDER_STATUS_MASK (1 << 7)
> #define FORCEWAKE_MT 0xa188 /* multi-threaded */
> #define FORCEWAKE_KERNEL 0x1
> #define FORCEWAKE_USER 0x2
> --
> 1.8.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
next prev parent reply other threads:[~2014-04-24 21:04 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 17:24 [PATCH v2 00/25] vlv: add support for RPM Imre Deak
2014-04-14 17:24 ` [PATCH v2 01/25] drm/i915: vlv: clean up GTLC wake control/status register macros Imre Deak
2014-04-24 21:04 ` Rodrigo Vivi [this message]
2014-04-14 17:24 ` [PATCH v2 02/25] drm/i915: vlv: clear master interrupt flag when disabling interrupts Imre Deak
2014-04-14 17:24 ` [PATCH v2 03/25] drm/i915: vlv: add RC6 residency counters Imre Deak
2014-04-14 17:24 ` [PATCH v2 04/25] drm/i915: fix the RC6 status debug print Imre Deak
2014-04-14 17:24 ` [PATCH v2 05/25] drm/i915: remove the i915_dpio debugfs entry Imre Deak
2014-04-14 17:24 ` [PATCH v2 06/25] drm/i915: get a runtime PM ref for debugfs entries where needed Imre Deak
2014-04-14 17:24 ` [PATCH v2 07/25] drm/i915: move getting struct_mutex lower in the callstack during GPU reset Imre Deak
2014-04-14 17:24 ` [PATCH v2 08/25] drm/i915: get a runtime PM ref for the deferred GT powersave enabling Imre Deak
2014-04-25 7:59 ` Daniel Vetter
2014-04-25 8:14 ` Imre Deak
2014-04-25 9:09 ` Daniel Vetter
2014-04-25 8:01 ` Daniel Vetter
2014-04-14 17:24 ` [PATCH v2 09/25] drm/i915: get a runtime PM ref for the deferred GPU reset work Imre Deak
2014-04-16 12:11 ` Ville Syrjälä
2014-04-18 12:47 ` [PATCH v3] " Imre Deak
2014-04-22 19:38 ` Daniel Vetter
2014-04-22 20:34 ` Imre Deak
2014-04-22 21:05 ` Daniel Vetter
2014-04-22 22:13 ` [PATCH v4] " Imre Deak
2014-04-23 7:07 ` Daniel Vetter
2014-04-23 7:52 ` Imre Deak
2014-04-25 8:00 ` Daniel Vetter
2014-04-14 17:24 ` [PATCH v2 10/25] drm/i915: gen2: move error capture of IER to its correct place Imre Deak
2014-04-16 12:22 ` Ville Syrjälä
2014-04-16 12:57 ` Imre Deak
2014-04-24 21:06 ` Rodrigo Vivi
2014-04-14 17:24 ` [PATCH v2 11/25] drm/i915: add missing error capturing of the PIPESTAT reg Imre Deak
2014-04-16 12:17 ` Ville Syrjälä
2014-04-18 11:44 ` Imre Deak
2014-04-18 12:55 ` [PATCH v3 " Imre Deak
2014-04-23 7:53 ` Ville Syrjälä
2014-04-14 17:24 ` [PATCH v2 12/25] drm/i915: vlv: check port power domain instead of only D0 for eDP VDD on Imre Deak
2014-04-14 17:24 ` [PATCH v2 13/25] drm/i915: fix unbalanced GT powersave enable / disable calls Imre Deak
2014-04-14 17:24 ` [PATCH v2 14/25] drm/i915: sanitize enable_rc6 option Imre Deak
2014-04-16 12:28 ` Ville Syrjälä
2014-04-16 12:37 ` Imre Deak
2014-04-18 13:01 ` [PATCH v3 " Imre Deak
2014-04-23 7:58 ` Ville Syrjälä
2014-04-14 17:24 ` [PATCH v2 15/25] drm/i915: disable runtime PM if RC6 is disabled Imre Deak
2014-04-14 17:24 ` [PATCH v2 16/25] drm/i915: make runtime PM interrupt enable/disable platform independent Imre Deak
2014-04-14 17:24 ` [PATCH v2 17/25] drm/i915: factor out gen6_update_ring_freq Imre Deak
2014-04-16 17:31 ` Ville Syrjälä
2014-04-18 13:16 ` [PATCH v3 " Imre Deak
2014-04-23 7:59 ` Ville Syrjälä
2014-04-14 17:24 ` [PATCH v2 18/25] drm/i915: make runtime PM swizzling/ring_freq init platform independent Imre Deak
2014-04-14 17:24 ` [PATCH v2 19/25] drm/i915: reinit GT power save during resume Imre Deak
2014-04-16 17:46 ` Ville Syrjälä
2014-04-18 10:51 ` Imre Deak
2014-04-22 17:21 ` [PATCH v3 " Imre Deak
2014-04-23 8:06 ` Ville Syrjälä
2014-04-14 17:24 ` [PATCH v2 20/25] drm/i915: vlv: setup RPS min/max frequencies once during init time Imre Deak
2014-04-14 17:24 ` [PATCH v2 21/25] drm/i915: vlv: factor out vlv_force_gfx_clock Imre Deak
2014-04-16 17:49 ` Ville Syrjälä
2014-04-18 13:35 ` [PATCH v3 21/25] drm/i915: vlv: factor out vlv_force_gfx_clock and check for pending force-off Imre Deak
2014-04-23 8:11 ` Ville Syrjälä
2014-04-14 17:24 ` [PATCH v2 22/25] drm/i915: vlv: increase timeout when forcing on the GFX clock Imre Deak
2014-04-25 14:04 ` Daniel Vetter
2014-04-14 17:24 ` [PATCH v2 23/25] drm/i915: add various missing GTI/Gunit register definitions Imre Deak
2014-04-24 21:17 ` Rodrigo Vivi
2014-04-24 21:49 ` Imre Deak
2014-04-30 14:32 ` Ville Syrjälä
2014-05-05 11:43 ` Imre Deak
2014-05-05 12:13 ` [PATCH v3 " Imre Deak
2014-05-05 12:21 ` Ville Syrjälä
2014-04-14 17:24 ` [PATCH v2 24/25] drm/i915: propagate the error code from runtime PM callbacks Imre Deak
2014-04-15 13:39 ` [PATCH v3 " Imre Deak
2014-04-30 18:05 ` Ville Syrjälä
2014-04-30 18:53 ` Imre Deak
2014-05-05 12:44 ` Ville Syrjälä
2014-05-05 13:18 ` Imre Deak
2014-04-14 17:24 ` [PATCH v2 25/25] drm/i915: vlv: add runtime PM support Imre Deak
2014-04-16 12:39 ` Ville Syrjälä
2014-04-16 14:53 ` Daniel Vetter
2014-04-16 16:01 ` Imre Deak
2014-04-22 17:28 ` [PATCH v3 " Imre Deak
2014-04-22 22:09 ` [PATCH v4] drm/i915: get a runtime PM ref for the deferred GPU reset work Imre Deak
2014-04-24 21:02 ` Rodrigo Vivi
2014-04-30 17:35 ` [PATCH v3 25/25] drm/i915: vlv: add runtime PM support Ville Syrjälä
2014-05-05 9:33 ` Daniel Vetter
2014-05-05 12:19 ` [PATCH v4 " Imre Deak
2014-04-14 17:41 ` [PATCH v2 26/25] drm/i915: vlv: enable runtime PM Imre Deak
2014-05-06 19:39 ` Daniel Vetter
2014-04-17 11:00 ` [PATCH v2 00/25] vlv: add support for RPM Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABVU7+v5jHoKhMQsP=zfm__0mNuE4Ep9iyviM7nRZjf74Z+Twg@mail.gmail.com' \
--to=rodrigo.vivi@gmail.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.