From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 385F5C4363D for ; Wed, 21 Oct 2020 03:50:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD25C2098B for ; Wed, 21 Oct 2020 03:50:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VDLrprWi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2411844AbgJUDuR (ORCPT ); Tue, 20 Oct 2020 23:50:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732257AbgJUDuR (ORCPT ); Tue, 20 Oct 2020 23:50:17 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 760E5C0613D3 for ; Tue, 20 Oct 2020 20:50:15 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id i2so916510ljg.4 for ; Tue, 20 Oct 2020 20:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E/mlH7Rkpa560PVMbUdTwC6pWnOxYOo+/fb/Tvvof+c=; b=VDLrprWiZQP1zgfYnCdWehDecFvFE8lLk2598g65QwFqRqjJuAbNrrsyUbHO3TBBiA RNeEvd75eXYxluuk+Cu/HNJrmvtIQzlDNm7VEbC7jTnP5bVTXKpvnrRvr7/bAVwBS91N /NvldJ79ishaAK9RU5azOKXGhwt5Kq6uWfg+atxycc3yqJ3RTZKrRPuRNVkeGtOBakA2 a//YGod/Ht5R29AqDJTt/yE1D0np2h2h2RA5SjOEMuepkEeG5Lqp45fOTjSrv6lxtp9Y NWdkX7ClsfOqlN0kQmn7kX5jxGTJu8V3XEiTl7WEHSvgM493TBWo9XOqJZDXH5SIh4Wo RT5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E/mlH7Rkpa560PVMbUdTwC6pWnOxYOo+/fb/Tvvof+c=; b=gtcg2c6Jox4ujqS2xgP3MPWyA4q4Q6Y/A5FXDvib2xQjKXjYybPzee/h0hQ6Liv5RA S201+wuMQ14N02fLlKqLRSBDoTC2fdkJRcvbmdayObNVgUqxQndq+cJ9GXOoDIzFbu3c +SBWpSucyCAi6485eZ77vP4utgBhLsVDVSmKZSzZ0XS5t8V5i9kUrQe0rAqI4WDg1ayZ uQPUOeE54MQB0Rbxc65IV3JpCSwc5GdbRmXQdIW5A7tNIApjNgU/RitfEhQMHpc/aq6g 7SkaGrzDDlrmZlYZ300wnPxajZXOqp8jARIhHzgeVekskAl5ZWjNEYtOeHxh2vVrnkkp GURA== X-Gm-Message-State: AOAM531WkLsUNuv26tL6MOLVzWYVhrYFX/+A0O88Fv6mZ8UrvkR2wbe8 ZwKxjdECo10Foc2Nok0+NBRujs0wVOAHBvqMOp5feA== X-Google-Smtp-Source: ABdhPJwp/7M/XgPSYhhApxLoSbfNbAEmtcui4MpeS5LXnKrtmlOBsQfsmhZEIWsjp4lufL41ROXzGdDWeIK5Oyx0wtU= X-Received: by 2002:a2e:7c0f:: with SMTP id x15mr412496ljc.401.1603252213693; Tue, 20 Oct 2020 20:50:13 -0700 (PDT) MIME-Version: 1.0 References: <20201020055856.1270482-1-davidgow@google.com> <87d01die4o.fsf@mail.parknet.co.jp> In-Reply-To: <87d01die4o.fsf@mail.parknet.co.jp> From: David Gow Date: Wed, 21 Oct 2020 11:50:02 +0800 Message-ID: Subject: Re: [PATCH v2] fat: Add KUnit tests for checksums and timestamps To: OGAWA Hirofumi Cc: Brendan Higgins , Shuah Khan , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 20, 2020 at 2:51 PM OGAWA Hirofumi wrote: > > David Gow writes: > > > diff --git a/fs/fat/misc.c b/fs/fat/misc.c > > index f1b2a1fc2a6a..445ad3542e74 100644 > > --- a/fs/fat/misc.c > > +++ b/fs/fat/misc.c > > @@ -229,6 +229,7 @@ void fat_time_fat2unix(struct msdos_sb_info *sbi, struct timespec64 *ts, > > ts->tv_nsec = 0; > > } > > } > > +EXPORT_SYMBOL_GPL(fat_time_fat2unix); > > Hm, can this export only if FAT_KUNIT_TEST is builtin or module (maybe > #if IS_ENABLED(...))? And #if will also be worked as the comment too. > That's possible, but I'd prefer to export it unconditionally for two reasons: 1. It'd make it possible to build the fat_test module without having to rebuild the whole kernel/fat. 2. It'd be consistent with fat_time_unix2fat(), which is exported for use in vfat/msdos anyway. Neither of those are dealbreakers, though, so if you'd still prefer this to be behind an ifdef, I'll change it. -- David