From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B303C64E7B for ; Tue, 1 Dec 2020 07:35:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0A9E2087C for ; Tue, 1 Dec 2020 07:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GHXUq2Yp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728155AbgLAHet (ORCPT ); Tue, 1 Dec 2020 02:34:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727116AbgLAHes (ORCPT ); Tue, 1 Dec 2020 02:34:48 -0500 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67573C0613D3 for ; Mon, 30 Nov 2020 23:34:08 -0800 (PST) Received: by mail-lj1-x241.google.com with SMTP id 142so1231306ljj.10 for ; Mon, 30 Nov 2020 23:34:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3sAfYzfnHpBDQQEiR5AB4kL1wrJ/tmzzqABS0iM18lo=; b=GHXUq2YpLuIQ36kaJyi6gm+57jEHYfI6XasZB7E8uDctHdzu7RWhpv4EGD1pUV/Lea UP63nqdng6ZhpZg7NP/OTVWmHJslZ3spK7pjGIxQZopEsEIbHuDtkiHmy+u0uCYnw2g0 Q8QgCGLR1UUBHiRPmDdQ0vecTsMRD6KLthMZh291cZxqPcR+VuBSfUcvOFjWGkZPhHCR aUL7Nsv4eECy7to6BV2N/MdGNpvpXZvSxNRV8gWapBmFggYOHvWFkYzaXAOKpB9IYayy W3lXzunc5ErjdF5fCTPCwSciYu8c0xP+gFsvM+PRdjBTOF8JxdxmjtZNhsXjiurggb1v w2Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3sAfYzfnHpBDQQEiR5AB4kL1wrJ/tmzzqABS0iM18lo=; b=OkXZ1N8x/71KIiia0nc7S4ymBmEbhfQhFqvbPvlHlA4TughrADGR6/Uh+7WZYUjROv 1e3q28Llhkd3cu0zaNk5d4mN3GF+3nXnBjF+nsx+O1Agtn0pnS7aegZLuiGU/W35E9EC kCkkIAnLklLhlhc37lMQp36gRKSoABt838Zrr0rtze51/VGewDFhpWzGs5QU22ii3aV9 OChmbj1eNcZrDwARmxon4NPW0k7sHqABsj/jUeccDH7IfEUogqZ2GCWlHplJLyBUQzIU Av4AsLpiOH7/iBEih3BIenw66gudqPlQb0VrajkFd/C4ob8kvZtolpu8j/MaUkLt3sK6 fA5Q== X-Gm-Message-State: AOAM530S6nNsXiPOSl/Fd9Q2hnAHQ7y+SZK+ZRa2vg56PascmcNLLcgZ I/9FEh6aDmOJPXVJG7m36t2ECh38NoIkauJs7SOTTg== X-Google-Smtp-Source: ABdhPJxsHo7jWyLvtclHc5phZMJ2NRcTEMgll8C8jkpEWdcV6iozaUa6EbEg14cZVBhgXvtZiTb3kqSxHi6+e2yLbEA= X-Received: by 2002:a2e:8504:: with SMTP id j4mr673944lji.169.1606808046741; Mon, 30 Nov 2020 23:34:06 -0800 (PST) MIME-Version: 1.0 References: <20201130233242.78413-1-dlatypov@google.com> <20201130233242.78413-5-dlatypov@google.com> In-Reply-To: <20201130233242.78413-5-dlatypov@google.com> From: David Gow Date: Tue, 1 Dec 2020 15:33:55 +0800 Message-ID: Subject: Re: [PATCH 5/5] minor: kunit: tool: s/get_absolute_path/test_data_path in unit test To: Daniel Latypov Cc: Brendan Higgins , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov wrote: > > 1. the name is a lie. It gives relative paths, e.g. if I run from the > same dir as the test file, it gives './test_data/' > > 2. it's only used for generating paths to tools/testing/kunit/test_data/ > So we can tersen things by making it less general. > > Signed-off-by: Daniel Latypov > --- This is an excellent and overdue rename/replacement. My only note is re: the concerns I have in patch 2, where I think we probably ought to make this function actually return an absolute path. It seems from the code (and the function name) that that was the intent, so if we can fix it, that'd be ideal. Personally, though, I'd still prefer the new test_data_path(), just have it be an actually absolute path. -- David