From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files Date: Wed, 23 May 2018 08:54:18 -0700 Message-ID: References: <20180522165842.233949-1-groeck@google.com> <20180523135609.GK4828@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yw0-f194.google.com (mail-yw0-f194.google.com [209.85.161.194]) by alsa0.perex.cz (Postfix) with ESMTP id 95D8F26707F for ; Wed, 23 May 2018 17:54:31 +0200 (CEST) Received: by mail-yw0-f194.google.com with SMTP id p144-v6so6847502ywg.7 for ; Wed, 23 May 2018 08:54:31 -0700 (PDT) In-Reply-To: <20180523135609.GK4828@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel , Liam Girdwood , "Patel, Chintan M" , Guenter Roeck List-Id: alsa-devel@alsa-project.org On Wed, May 23, 2018 at 6:56 AM Mark Brown wrote: > > On Wed, May 23, 2018 at 03:54:54PM +0200, Takashi Iwai wrote: > > > And I'm wondering whether we should move these definitions to uapi > > headers. > > Yes, we should. Are you sure ? They used to be in sound/soc/intel/skylake/skl-tplg-interface.h. I took my clue from sound/soc/soc-topology.c, where the v4 structures are also declared locally and not in the uapi files. Guenter