From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name Date: Thu, 4 Apr 2019 10:36:35 -0700 Message-ID: References: <20190404171007.160878-1-ncrews@chromium.org> <20190404171007.160878-3-ncrews@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190404171007.160878-3-ncrews@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Nick Crews Cc: Enric Balletbo i Serra , Benson Leung , linux-leds@vger.kernel.org, Jacek Anaszewski , Pavel Machek , alexandre.belloni@bootlin.com, Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel , Duncan Laurie , Simon Glass , Dmitry Torokhov List-Id: linux-leds@vger.kernel.org On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wrote: > > We want all backlights for the system keyboard to > use a common name, so the name "platform::kbd_backlight" > would be better than the current "chromeos::kbd_backlight" > name. Normally this wouldn't be worth changing, but the new > Wilco keyboard backlight driver uses the "platform" name. > We want to make it so all Chrome OS devices are consistent, > so we'll change the name here too. > Wondering - who is the "we" you are talking about ? Guenter > The Power Manager daemon only looks for LEDs that match the > pattern "*:kbd_backlight", so this change won't affect that. > > Signed-off-by: Nick Crews > --- > drivers/platform/chrome/cros_kbd_led_backlight.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/platform/chrome/cros_kbd_led_backlight.c > index aa409f0201fb..c56c8405f39c 100644 > --- a/drivers/platform/chrome/cros_kbd_led_backlight.c > +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c > @@ -77,7 +77,7 @@ static int keyboard_led_probe(struct platform_device *pdev) > if (!cdev) > return -ENOMEM; > > - cdev->name = "chromeos::kbd_backlight"; > + cdev->name = "platform::kbd_backlight"; > cdev->max_brightness = ACPI_KEYBOARD_BACKLIGHT_MAX; > cdev->flags |= LED_CORE_SUSPENDRESUME; > cdev->brightness_set = keyboard_led_set_brightness; > -- > 2.20.1 >