From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932989AbcI3TGu (ORCPT <rfc822;w@1wt.eu>);
        Fri, 30 Sep 2016 15:06:50 -0400
Received: from mail-qk0-f171.google.com ([209.85.220.171]:34829 "EHLO
        mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933778AbcI3TGn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 30 Sep 2016 15:06:43 -0400
MIME-Version: 1.0
In-Reply-To: <VI1PR0401MB25606B7501E38D64C37E33CE89C10@VI1PR0401MB2560.eurprd04.prod.outlook.com>
References: <1471986651-51139-1-git-send-email-groeck@chromium.org>
 <1471986651-51139-2-git-send-email-groeck@chromium.org> <VI1PR0401MB25606B7501E38D64C37E33CE89C10@VI1PR0401MB2560.eurprd04.prod.outlook.com>
From: Guenter Roeck <groeck@google.com>
Date: Fri, 30 Sep 2016 12:06:42 -0700
Message-ID: <CABXOdTfMRFLohkH7aVOXwEi3cGh=nOPYToEVEY-9xJ8yYH9BBQ@mail.gmail.com>
Subject: Re: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)
To: Jun Li <jun.li@nxp.com>
Cc: Guenter Roeck <groeck@chromium.org>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>,
        Bruce Ashfield <bruce.ashfield@windriver.com>,
        Bin Gao <bin.gao@intel.com>, Pranav Tipnis <pranav.tipnis@intel.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 29, 2016 at 11:37 PM, Jun Li <jun.li@nxp.com> wrote:
> Hi Guenter,
>> -----Original Message-----
>> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-
>> owner@vger.kernel.org] On Behalf Of Guenter Roeck
>> Sent: Wednesday, August 24, 2016 5:11 AM
>> To: Felipe Balbi <felipe.balbi@linux.intel.com>
>> Cc: Chandra Sekhar Anagani <chandra.sekhar.anagani@intel.com>; Bruce
>> Ashfield <bruce.ashfield@windriver.com>; Bin Gao <bin.gao@intel.com>;
>> Pranav Tipnis <pranav.tipnis@intel.com>; Heikki Krogerus
>> <heikki.krogerus@linux.intel.com>; linux-kernel@vger.kernel.org; linux-
>> usb@vger.kernel.org; Guenter Roeck <groeck@chromium.org>
>> Subject: [RFC PATCH v3 1/2] usb: typec: USB Type-C Port Manager (tcpm)
>>
> ...
>> diff --git a/include/linux/usb/pd.h b/include/linux/usb/pd.h
>> new file mode 100644
>> index 000000000000..6b1679af7a25
>> --- /dev/null
>> +++ b/include/linux/usb/pd.h
>
> ...
>
>> +#define PDO_VAR(min_mv, max_mv, max_ma)                                      \
>> +     ((PDO_TYPE_VAR << PDO_TYPE_SHIFT) |                             \
>> +      ((((min_mv) / 50) & PDO_VAR_MIN_VOLT_MASK) <<                  \
>> +       PDO_VAR_MIN_VOLT_SHIFT) |                                     \
>> +      ((((max_mv) / 50) & PDO_VAR_MAX_VOLT_MASK) <<                  \
>> +       PDO_VAR_MAX_VOLT_SHIFT) |                                     \
>> +      ((((max_ma) / 50) & PDO_VAR_MAX_CURR_MASK) <<                  \
>
> ((((max_ma) / 10) & PDO_VAR_MAX_CURR_MASK) <<                  \
>

Thanks, fixed. PDO_BATT has a similar problem, which I noticed while
fixing the above.

Guenter