From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753117AbcKRVXl (ORCPT <rfc822;w@1wt.eu>);
        Fri, 18 Nov 2016 16:23:41 -0500
Received: from mail-qk0-f181.google.com ([209.85.220.181]:35647 "EHLO
        mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752421AbcKRVXi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 18 Nov 2016 16:23:38 -0500
MIME-Version: 1.0
In-Reply-To: <20161118163704.1236495-1-arnd@arndb.de>
References: <20161118163704.1236495-1-arnd@arndb.de>
From: Guenter Roeck <groeck@google.com>
Date: Fri, 18 Nov 2016 13:23:36 -0800
Message-ID: <CABXOdTfTFOM2nWM3x6ECgxvuEjiv1RUt=8HhEzYiPjF+a3B0iw@mail.gmail.com>
Subject: Re: [PATCH] phy: rockchip-inno-usb2: add extcon dependency
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Guenter Roeck <groeck@chromium.org>,
        Frank Wang <frank.wang@rock-chips.com>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 18, 2016 at 8:36 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> If extcon is a loadable module and rockchip-inno-usb2 is built-in,
> we get a link failure:
>
> drivers/phy/phy-rockchip-inno-usb2.o: In function `rockchip_usb2phy_probe':
> phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x1ec): undefined reference to `extcon_get_edev_by_phandle'
> phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x25c): undefined reference to `devm_extcon_dev_allocate'
> phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x2a8): undefined reference to `devm_extcon_dev_register'
> phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0xa28): undefined reference to `extcon_register_notifier'
>
> Adding a hard dependency avoids the problem. Alternatively we could
> use "depends on EXTCON || !EXTCON" to allow building with extcon
> disabled completely, but the other PHY drivers with extcon support
> also just have a dependency, so this is more consistent.
>
> Fixes: 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looking into the source, extcon support is now mandatory for this
driver, so adding the dependency makes sense.

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---
>  drivers/phy/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 53cab9f3323b..b135ff1ab12d 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -366,6 +366,7 @@ config PHY_ROCKCHIP_INNO_USB2
>         depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
>         depends on COMMON_CLK
>         depends on USB_SUPPORT
> +       depends on EXTCON
>         select GENERIC_PHY
>         select USB_COMMON
>         help
> --
> 2.9.0
>