From: Samuli Piippo <samuli.piippo@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-qt5][PATCH 2/2] qtbase: Add packageconfigs for renameat2 and getentropy use
Date: Fri, 23 Feb 2018 10:00:18 +0200 [thread overview]
Message-ID: <CABXoSoUtZuS+u_YjAPQYUKwoMPtxUXP6ABNDBq-Ww03O7_9Gaw@mail.gmail.com> (raw)
In-Reply-To: <CAMKF1soxS4aUMzd5d+uiHvnEjFEh5vyUvZcGQ_9CUdNugb7LvQ@mail.gmail.com>
renameat2 is a system call without a libc wrapper, so the configure
test will always fail. The system call will still be used if that is
defined, so PACKAGECONFIG doesn't make sense for it.
On 23 February 2018 at 04:17, Khem Raj <raj.khem@gmail.com> wrote:
> On Thu, Feb 22, 2018 at 5:27 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> On Wed, Feb 21, 2018 at 08:29:40PM -0800, Khem Raj wrote:
>>> These features depend on underlying syscall support in kernel
>>> and if older kernels are in use, then we can have a knob to
>>> turn them off.
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> recipes-qt/qt5/qtbase_git.bb | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/recipes-qt/qt5/qtbase_git.bb b/recipes-qt/qt5/qtbase_git.bb
>>> index e495b8c..843648f 100644
>>> --- a/recipes-qt/qt5/qtbase_git.bb
>>> +++ b/recipes-qt/qt5/qtbase_git.bb
>>> @@ -71,7 +71,7 @@ PACKAGECONFIG_DISTRO ?= ""
>>> PACKAGECONFIG_RELEASE ?= "release"
>>> # This is in qt5.inc, because qtwebkit-examples are using it to enable ca-certificates dependency
>>> # PACKAGECONFIG_OPENSSL ?= "openssl"
>>> -PACKAGECONFIG_DEFAULT ?= "dbus udev evdev widgets tools libs freetype tests"
>>> +PACKAGECONFIG_DEFAULT ?= "dbus udev evdev widgets tools libs freetype tests renameat2 getentropy"
>>
>> Should renameat2 be enabled by default?
>>
>> Either the test for it is broken in 5.11 or it's not available in
>> default setup.
>>
>
> Its ok to keep them enabled by default. but I think this is a bug that
> should be reported
> to upstream QT, if the feature is knobbale then it should have worked.
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
next prev parent reply other threads:[~2018-02-23 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 4:29 [meta-qt5][PATCH 1/2] qtbase: Replace -isystem with -I Khem Raj
2018-02-22 4:29 ` [meta-qt5][PATCH 2/2] qtbase: Add packageconfigs for renameat2 and getentropy use Khem Raj
2018-02-23 1:27 ` Martin Jansa
2018-02-23 2:17 ` Khem Raj
2018-02-23 8:00 ` Samuli Piippo [this message]
2018-02-23 14:53 ` Khem Raj
2018-02-22 5:03 ` [meta-qt5][PATCH 1/2] qtbase: Replace -isystem with -I Khem Raj
2018-02-24 4:49 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABXoSoUtZuS+u_YjAPQYUKwoMPtxUXP6ABNDBq-Ww03O7_9Gaw@mail.gmail.com \
--to=samuli.piippo@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.